Page MenuHomePhabricator
Create Task
Maniphest T22076

UI problems with mulitlabel images which have more than one layer
Closed, ResolvedPublic
Actions

Description

Changing color, changing visibility,... of labels which are not assigned to the first layer of a multilabel image causes some problems. Due to the incorrect call of the GetLabel() function the default value (Layer 0) is allways used to get the label.

Related Objects

Event Timeline

metzger created this task.Nov 9 2016, 3:30 PM
kislinsk triaged this task as Normal priority.Nov 9 2016, 3:38 PM
kalali added a subscriber: kalali.Nov 9 2016, 4:20 PM

This problem has also been tackled in T19933, which should be tested.
I stay in contact with @goch to finish the task and integrate the topic branch.

metzger added a comment.Nov 9 2016, 5:15 PM

Pushed new branch T22076-CorrectCallOfGetLabelWithActiveLayer.

metzger added a comment.Nov 9 2016, 5:18 PM

After adding/deleting a label there is no update of the label widget.
Also there is a problem if you delete the first layer. The segmented areas still remain on the image.

metzger mentioned this in rMITKf6c7e08bc13d: Merge branch 'T22076-CorrectCallOfGetLabelWithActiveLayer'.Nov 9 2016, 5:51 PM
• goch moved this task from Backlog to Suggested on the MITK (2016-11) board.Nov 25 2016, 4:30 PM
• goch mentioned this in rMITKba5543120a81: Merge remote-tracking branch 'origin/T22076….Nov 25 2016, 5:38 PM
• goch moved this task from Suggested to Included on the MITK (2016-11) board.Nov 25 2016, 6:32 PM
kislinsk added a comment.Dec 15 2016, 2:24 PM

Is this resolved @goch @metzger?

• goch added a comment.Dec 19 2016, 12:05 PM
In T22076#86648, @metzger wrote:

After adding/deleting a label there is no update of the label widget.
Also there is a problem if you delete the first layer. The segmented areas still remain on the image.

It seems at least the second issue mentioned still exists.

• goch added a comment.Dec 19 2016, 1:01 PM

I will revisit this issue once T19933 has been merged to check what open issues remain and open a corresponding task.

• goch added a comment.Dec 21 2016, 9:57 AM

Pushed new branch T22076-AssortedLabelSetFixes.

• goch mentioned this in rMITKfeb938874bc6: Merge branch 'T22076-AssortedLabelSetFixes'.Dec 21 2016, 10:02 AM
• goch mentioned this in rMITKbe60df21f1e6: Merge branch 'T22076-AssortedLabelSetFixes'.Dec 21 2016, 12:44 PM
• goch mentioned this in rMITK935f73a3eeff: Merge branch 'T22076-AssortedLabelSetFixes'.Dec 21 2016, 1:26 PM
• goch mentioned this in rMITK840b695ddcb4: Merge remote-tracking branch 'origin/T22076-AssortedLabelSetFixes' into….Dec 22 2016, 2:14 PM
kalali added a comment.Jan 2 2017, 6:50 PM
In T22076#90853, @goch wrote:

I will revisit this issue once T19933 has been merged to check what open issues remain and open a corresponding task.

Please see the new squashed branch: T19933-Outline-of-segmentation-fix.

• goch closed this task as Resolved.Jan 19 2017, 5:13 PM

Should be resolved. If any other issues crop up new tasks should be opened.

MITK · MIC · IMSY · DKFZ