Actual behavior:
Windows/Preferences/Segmentation offers two choices for displaying 2D segmentations:
Selecting the second option still shows an outline of the segmentation, while reducing the opacity of the segmentation.
Expected behavior:
Selecting the second option should not show an outline of the segmentation, as this is sometimes not preferred, especially not for small segmentations.
| Restricted Differential Revision | |
| Restricted Differential Revision | |
| Restricted Differential Revision | |
| Restricted Differential Revision |
This is a fix for this problem, but since there might be more to do than just changing the property to "labelset.contour.active" the task remains open.
Also, as mentioned in T19658, the changing of the contour-visibility is only applied 'after explicit window update'.
Furthermore, as mentioned in T19472 by @kuznetsov, there might already exist a fix, which could also tackle this problem.
Active contour with multi-label segmentation remains an open issue.
This will be investigated during the multi-label segmentation integration.
Active contour with multi-label segmentation has been added with the integration branch.
However, some unexpected behavior remains, which may be connected with T19658 (red contour initially appears sometimes).
Looking at @kuznetsov solution in https://github.com/MITK/MITK/pull/141 he seems to prefer another way of visualizing segmentations and their contours: Either the segmentation is shown or the contour is show without a transparent segmentation surface. Non-active labels are shown with their segmentation surface and full opacity (this can be changed via the 'labelset.contour.all' property).
We have to discuss the different approaches.
Removed contour modification from the preference page, so this task is invalid.
Instead, the new 'Qlabelsetwidget' offers enough options to change the opacity and the visibility of the labels.
Additionally I added an option to set the 'labelset.contour.active' property so the contour can be enabled or disabled via the 'Qlabelsetwidget'.
Furthermore, the 'labelset.contour.all' property was removed, since we are currently not able to draw multiple contours of different labels.
I'm mixing some things up here, as the task was originally concerning the single label segmentation.
The change of the preference options happened in the multi label segmentation preference page.
There is still an issue with the single label segmentation, so this task remains open.
The segmentation outline can now be turned off and on on the segmentation preference page. This option holds both for single and multi label segmentations.
But since the preference page does only work if the corresponding plugin is opened in the MITK workbench, the segmentation plugin (single label) has to be activated (not necessarilly focused / visible).
For multi label segmentations the approach 'outline without face - face without outline' does not work. Therefore another task is opened for discussion (see T22328)
Pushed new branch T19933-Outline-of-segmentation-fix.
Squashed the important commits of the T19933-Turn-off-outline-of-segmentation-integration branch on top of the T22076-AssortedLabelSetFixes branch.
Both the Segmentation preference page and the MultiLabel preference page now can be used to change the visibility of the segmentation outlines.
Pushed new branch T19933-Outline-of-segmentation-fix-rebase.
Based on branch instead of the merge commit, so it could be merged in the release branch