Page MenuHomePhabricator
Create Task
Maniphest T22572

Migrate plugins from deprecated org.mitk.gui.qt.common.legacy dependency to org.mitk.gui.qt.common
Closed, ResolvedPublic
Actions

Description

PR follows.

Related Objects
Search...

Event Timeline

espak created this task.Feb 24 2017, 7:40 PM
espak added a comment.Feb 24 2017, 7:44 PM

PR 175:
https://github.com/MITK/MITK/pull/175

espak added a comment.Feb 24 2017, 7:55 PM

The code compiles, at least everything that I could switch on. :)

I did not launch the apps and did not do any manual testing. Also did not run ctest, although the changes are in the plugins and the tests are mostly for the modules, I guess.

Each commit is one plugin.

I migrated all the plugins so that the legacy module can be physically removed, but did not remove it.

We do not need all of these plugins, only a few:

  • moviemaker
  • basicimageprocessing
  • segmentation
  • multilabelsegmentation
  • imagecropper
  • measurementtoolbox
  • pointsetinteraction

and the registration looks interesting but have not tried it.

kislinsk added a project: Pull Request.Feb 24 2017, 9:59 PM
kislinsk claimed this task.Mar 3 2017, 1:31 PM
kislinsk triaged this task as Normal priority.
kislinsk added a comment.Mar 3 2017, 2:27 PM

Pushed new branch T22572-no-common-legacy.

kislinsk mentioned this in rMITKcb39da8b0686: Merge remote-tracking branch 'NifTK/T22572-no-common-legacy' into T22572-no….Mar 3 2017, 2:29 PM
kislinsk added a comment.Mar 3 2017, 2:31 PM

Hi, cool PR! 👍
Only had a very straight forward merge conflict and a forgotten migration from std::vector<mitk::DataNode*> to QList<mitk::DataNode::Pointer>. However, the interactions doesn't work anymore. For example, neither segmentation, clipping plane, nor point set work. I start to investigate what's going on, or what isn't.

kislinsk added a comment.Mar 7 2017, 2:39 PM

Seems to be related to the migration towards ILifeCycleAwarePart views, as the old Activated/Deactivated stuff apparently doesn't match to the new mechanism. For example, the interactions don't work because the selection is explicitly cleared in the Deactivated() method when clicking into the editor. I fixed the QmitkPointSetInteractionView so far. Needs to be tested manually, though, as it's always a strange feeling when simply deleting code and it still seems to work (again).

kislinsk added a subscriber: neher.Mar 10 2017, 10:32 AM

@neher

T22572-no-common-legacy
  • IVIM
  • Preprocessing
  • QBallReconstruction
  • TbssSkeletonization
  • TensorReconstruction
  • TractbasedSpatialStatistics
  • DiffusionTensorEstimation
kislinsk mentioned this in rMITKb964cb893e87: Merge branch 'T22572-no-common-legacy'.Apr 28 2017, 9:36 AM
kislinsk added a comment.Apr 28 2017, 10:16 AM

Pushed new branch T22572-Fixes.

kislinsk mentioned this in rMITK15bc436377fe: Merge branch 'T22572-Fixes'.Apr 28 2017, 10:17 AM
kislinsk mentioned this in rMITKf9b806075511: Merge branch 'T22572-Fixes'.Apr 28 2017, 11:45 AM
kislinsk mentioned this in rMITK7e7aa1d5edc9: Merge branch 'T22572-Fixes'.Apr 28 2017, 2:57 PM
kislinsk mentioned this in rMITK82856d37fe55: Merge branch 'T22572-Fixes'.Apr 28 2017, 3:30 PM
kislinsk added a comment.Apr 28 2017, 3:32 PM

Quickfixed Segmentation plugin. Need to investigate further.

kalali mentioned this in T22847: 'OnSelectionChanged' of 'Single'Segmentation plugin does not work anymore.May 15 2017, 11:45 AM
kislinsk added a subtask: T22847: 'OnSelectionChanged' of 'Single'Segmentation plugin does not work anymore.May 15 2017, 1:36 PM
kalali closed subtask T22847: 'OnSelectionChanged' of 'Single'Segmentation plugin does not work anymore as Resolved.Jun 26 2017, 3:15 PM
kislinsk closed this task as Resolved.Jul 5 2017, 8:58 AM
kislinsk added a subscriber: kalali.

I'm closing this one. The segmentation plugin was fixed by @kalali & friends. Other plugins that rely on IZombieViewPart should have the same error (QmitkFunctionality's activated/deactivated was mapped directly which does now different things), but we will open separate tasks for them.

Thank you, @espak and @kalali. 👍

espak added a comment.Jul 14 2017, 3:43 PM

I wanted to open new tasks for the individual plugins that need a similar fix as the segmentation plugin, so that we can track the progress.

I did a file search for "zombie", but only found it in three plugins:

  1. In QmitkViewCoordinator in org.mitk.gui.qt.common
  1. In QmitkPartialVolumeAnalysisView in org.mitk.gui.qt.diffusionimaging.
  1. In QmitkToFUtilView in org.mitk.gui.qt.tofutil.

The first class was *not* a QmitkFunctionality, so I assume it is not affected. The latter two plugins we do not use.

So, no problems have been discovered with the other plugins?

Shall we create individual tasks for each affected plugins so that this does not get forgotten?

Cheers

MITK · MIC · IMSY · DKFZ