Page MenuHomePhabricator

Change plugin icons when darktheme is on
Closed, ResolvedPublic

Assigned To
Authored By
Aug 18 2017, 5:21 PM
Referenced Files
F852967: Capture.PNG
Aug 19 2017, 12:31 AM
"Party Time" token, awarded by kirchnth.

Event Timeline

check out the brach - this actually worked and isn't even very shitty code
i applied it to to help icons and it only works after a workbench restart
I'm on holiday for a week ... tell me if i should implement it like that

The goal is to make it more general and easy to maintain without the need to add even more icon versions. Marco had the nice idea that we should change the color of the icons in the svg files to a magic color that is easy to parse and replace. I vote for a green screen color #00ff00. When loading the svg files from the resources, this magic color is simply replaced by a fitting color specified by the theme before it is processed by Qt to finally create the icon. BAM! 🙂

We could even specify a secondary magic color if necessary.

Capture.PNG (152×1 px, 30 KB)

Note that the multi widget icon doesn't work.

Deleted branch T23281-addingIconAltToPluginMaybe.