Page MenuHomePhabricator

Easy: Remove PolyDataGLMapper2D
Closed, ResolvedPublic

Description

mitk::PoinData is no longer used by any part of MITK. It should be removed together with all associated classes (mappers etc.), in particular

  • mitk::PointDataVtkMapper3D
  • mitk::PolyDataGLMapper2D
NOTE: mitk::PolyDataGLMapper2D could possibly be used for rendering other (arbitrary) VTK based structures as well, but this is not done in MITK. However, it should be checked if mitk::PolyDataGLMapper2D should be retained for other purposes.

Event Timeline

[SVN revision 29487]
FIX (#2337): removed deprecated mitk::PointData and mitk::PointDataVtkMapper3D

[SVN revision 29488]
COMP (#2337): removed deprecated include

mitk::PolyDataGLMapper2D was not removed.

If this is considered important it should be specified in an extra bug.

Todo: Remove PolyDataGLMapper2D.h and PolyDataGLMapper2D.cpp and all the correspoding includes. Very simple cosmetic change.

Should be redirected to someone new in rendering for a first feeling of success ;).

Markus and I decided to review this Mapper again. This mapper is not using mitk::PointData at all and could be usefull for rendering vtkPolyData in 2D.

Markus and I talked about this. This is a simple example but the documentation is bad and it contains "FIXME" comments. Additionally, it is more or less a duplicate of the SurfaceGLMapper2D and hence should be removed.

This bug is not very important, but pretty old and hence it should be fixed.

Todo: Remove PolyDataGLMapper2D.cpp + .h

Current release is finished. Reseting target milestone...

New remote branch pushed: bug-2337-RemovePolyDataGLMapper2D

[e5e3c0]: Merge branch 'bug-2337-RemovePolyDataGLMapper2D'

Merged commits:

2014-01-15 13:33:32 Adrian Winterstein [7a8809]
Changed deprecated notice to release tag.


2014-01-08 15:43:58 Adrian Winterstein [293184]
Set PolyDataGLMapper2D deprecated.


2014-01-08 15:29:49 Adrian Winterstein [9531b8]
Removed useless includes of PolyDataGLMapper2D.

Class is documented as deprecated, now. Can be removed after release 2014-03.

User wintersa has pushed new remote branch:

bug-2337-RemovePolyDataGLMapper2D_ActualRemoving

[aeacab]: Merge branch 'bug-2337-RemovePolyDataGLMapper2D_ActualRemoving'

Merged commits:

2014-04-09 13:45:37 Adrian Winterstein [ef0476]
Class PolyDataGLMapper2D removed.