Page MenuHomePhabricator
Create Task
Maniphest T23554

MitkChart: Memory management of QmitkChartxyData
Closed, ResolvedPublic
Actions

Description

in QmitkChartWidget:

150 new QmitkChartxyData(data1DConverted, ...)
176 new QmitkChartxyData(data2DConverted, ...)

However, the pointer is never deleted again. Make sure it is.

Revisions and Commits

rMITK MITK
rMITK093ae5d32b9d Fix T23554

Related Objects

Event Timeline

hentsch created this task.Oct 16 2017, 10:08 AM
hentsch changed the visibility from "Custom Policy" to "Public (No Login Required)".
hentsch changed the edit policy from "Custom Policy" to "All Users".
hentsch added a subscriber: • kleina.
kahl claimed this task.Nov 10 2017, 2:33 PM
kahl added a comment.Nov 10 2017, 3:10 PM

Pushed new branch T23554-MitkChart-memory-management.

kahl closed this task as Resolved by committing rMITK093ae5d32b9d: Fix T23554.Nov 10 2017, 3:33 PM
kahl mentioned this in rMITKfaecce95ffa6: Merge branch 'T23554-MitkChart-memory-management'.
kahl added a commit: rMITK093ae5d32b9d: Fix T23554.
hentsch added a subscriber: kalali.Nov 13 2017, 8:46 AM

There's a problem with the Ubuntu build:

c++: error: CMakeFiles/MitkChart.dir/src/QmitkChartWidget.cpp.o: Datei oder Verzeichnis nicht gefunden

Modules/Chart/src/QmitkChartWidget.cpp
In file included from /opt/Qt5.6.0/5.6/gcc_64/include/QtCore/qlist.h:37:0,
                 from /opt/Qt5.6.0/5.6/gcc_64/include/QtCore/qobject.h:43,
                 from /opt/Qt5.6.0/5.6/gcc_64/include/QtWidgets/qwidget.h:38,
                 from /opt/Qt5.6.0/5.6/gcc_64/include/QtWidgets/QWidget:1,
                 from /home/mbivm10/docubuild/MITK/Modules/Chart/include/QmitkChartWidget.h:20,
                 from /home/mbivm10/docubuild/MITK/Modules/Chart/src/QmitkChartWidget.cpp:17:
/opt/Qt5.6.0/5.6/gcc_64/include/QtCore/qalgorithms.h: In instantiation of ‘void qDeleteAll(const Container&) [with Container = std::vector<QmitkChartxyData*>*]’:
/home/mbivm10/docubuild/MITK/Modules/Chart/src/QmitkChartWidget.cpp:132:24:   required from here
/opt/Qt5.6.0/5.6/gcc_64/include/QtCore/qalgorithms.h:325:15: error: request for member ‘begin’ in ‘c’, which is of pointer type ‘std::vector<QmitkChartxyData*>* const’ (maybe you meant to use ‘->’ ?)
     qDeleteAll(c.begin(), c.end());
               ^
/opt/Qt5.6.0/5.6/gcc_64/include/QtCore/qalgorithms.h:325:15: error: request for member ‘end’ in ‘c’, which is of pointer type ‘std::vector<QmitkChartxyData*>* const’ (maybe you meant to use ‘->’ ?)
kalali added a comment.Nov 13 2017, 8:48 AM

See here https://phabricator.mitk.org/rMITKa7b4b26e567394772b1e0b5b0cecbaac513d19d8
Does this help?

hentsch reopened this task as Open.Nov 13 2017, 9:04 AM
nolden added a subscriber: nolden.Nov 13 2017, 9:08 AM

I included this in my "clang" branch since I thought it was a local problem. You can cherry pick the fix, don't know when I can merge

hentsch mentioned this in rMITKbb0e49fdfb5b: Merge branch 'T23554-MitkChart-memory-management'.Nov 14 2017, 9:03 AM
hentsch closed this task as Resolved.Nov 14 2017, 9:03 AM
kahl mentioned this in T23919: Changing raw pointer to smart pointer in MITK chart.Dec 8 2017, 9:46 AM
MITK · MIC · IMSY · DKFZ