Page MenuHomePhabricator

PACS scroll leads to an infinite loop if no image is loaded
Closed, ResolvedPublic

Description

To reproduce:

  • open the MITK workbench (without any image loaded -> ImageNavigator should be disabled)
  • go to Preferences -> Editors -> Standard Multi Widget and enable "Use PACS like mouse interaction [...]
  • hold the middle-mouse button and move the mouse to perform the scroll-action

-> MITK will freeze because of an infinite loop inside mitk::DisplayInteractor::Scroll

This happens because the 'autoRepeat' mode tries to wrap around the image slices if the minimum or maximum slice is reached. However, in this case it will never be able to find a slice "in between".

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kalali created this task.

I admit that this bug is highly unlikely to experience in the normal workflow. Since I'm re-designing the interaction concept, I will fix this, though.

kalali updated the task description. (Show Details)

Has been solved on top of T26476.

If D538 is accepted, 146a8d8 needs to be considered and cherry-picked, too.

kalali added a revision: Restricted Differential Revision.Fri, Oct 15, 11:18 AM