Page MenuHomePhabricator | MITK

Create decoration manager for render windows widgets
Open, NormalPublic

Description

A decoration manager is responsible for setting / changing the decoration of the render windows, such as

  • department logo
  • border colors
  • corner annotation text / color
  • background color

Currently, this is mainly done by the custom/std multi widget editor, that also holds the custom/std multi widget.
It is reasonable to move the responsibility to an own class.

Event Timeline

kalali triaged this task as Normal priority.Apr 17 2018, 4:33 PM
kalali created this task.
kalali added a comment.EditedApr 19 2018, 4:49 PM

Need to find a way to synchronize the preferences with the default values of the render window widgets of the multi widget.
Problem: Preferences are used in the preference manager, which has no access to the multi widget (editor).

kalali added a comment.EditedApr 19 2018, 5:05 PM

Having a dynamically adjustable number of render windows inside the multi widget editor, it is not reasonable to allow background- and decoration-color changes inside the preferences for each render window individually.
Instead a color-list / color-map could be used that predefines some color-settings for an arbitrary number of render windows.
Changing the colors / decorations individually for a render window happens somewhere else (e.g. via a button in the render window or the multi widget itself).

Idea:

  • Use color-lists, that are selectable in the preference page.
  • Add checkbox to enable / disable render window specific decoration buttons. These buttons allow to set the decorations for each render window individually.
kalali claimed this task.Apr 20 2018, 3:36 PM
kalali added a comment.May 8 2018, 9:43 AM

First draft of a decoration manager was added; currently only a black-and-white color style is available. Render window individual decorations are currently not implemented.

floca added a subscriber: floca.May 8 2018, 4:04 PM

Why don't you let developers of new editors take care if they have or need preference settings? Just give them a usable interface to modify windows to their likeing. Where the information comes from is not our business.

Or was your propsal just for the our new editor? Thank I think it is a pragmatic approach.

kalali added a comment.May 8 2018, 5:43 PM

This was a proposal for the new editor, since it might contain too many render windows to change the decoration color for each render window via the preference page.
However, this decoration manager can be used to set the colors and decorations 'OnPreferencesChanged'.

kalali removed kalali as the assignee of this task.Feb 13 2019, 2:19 PM
kalali added a project: Restricted Project.Feb 13 2019, 2:22 PM
hettich added a subscriber: hettich.Jun 5 2019, 7:34 PM