Creating Annotations in fast succession assigns them the same GUIDs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• jungsi
	Jan 25 2019, 12:04 PM

Description

Where did I experience the bug

I created multiple Annotations in a loop.
When I tried inspecting them with the OverlayManagerPlugin it showed the properties for only the first Annotation no matter the selection.

What is the root cause of the bug

When Annotations are added to an AnnotationRenderer they are registered as a microservice and assigned a GUID in

mitk::Annotation::RegisterAsMicroservice (in Annotation.cpp starting at line 328)

The GUID is generated using a mitk::UIDGenerator("org.mitk.services.Annotation.id_", 16)
As this function is called in fast succession (in the same second) the time portion for the GUID is the same.
The issue is that the following random part of the GUID also happens to be the same.

When I add annotations in a loop and log the generated GUIDs I get

When I sleep for two seconds inbetween each annotation this is the resulting log output

Related Objects

Mentioned In: T27033: Clean up stale remote branches
T14333: Improve mitk::UIDGenerator
rMITK67b6b1731eb4: Fixed overflow in UIDGenerator to get real random UIDs Improve UIDGeneratorTest
rMITK1c0308943f81: Fixed overflow in UIDGenerator to get real random UIDs Improve UIDGeneratorTest
T25942: Annotation instances should not be services (?)

Event Timeline

• jungsi triaged this task as Low priority.Jan 25 2019, 12:04 PM

• jungsi created this task.

One question: Did I understood it correctly, each annotation is added as a microservice? So when I add two Label annotations, I will have to additional microservice instances registered?

Yes, that is correct

void mitk::Annotation::RegisterAsMicroservice(us::ServiceProperties props)
{
  if (m_ServiceRegistration != nullptr)
    m_ServiceRegistration.Unregister();
  us::ModuleContext *context = us::GetModuleContext();
  // Define ServiceProps
  mitk::UIDGenerator uidGen = mitk::UIDGenerator("org.mitk.services.Annotation.id_", 16);
  props[US_PROPKEY_ID] = uidGen.GetUID();
  m_ServiceRegistration =
    context->RegisterService(this, props);
}

When I query the service registry I receive multiple service references.

Oh, uh. One can do it that way, but I am not sure if I would realy like to have each instance of an annotation as an on service in the registry. In other cases (like property aliasis or descriptions) we have one service and you register the specific instances there. But I will open up another tasks for this discussion.

floca mentioned this in T25942: Annotation instances should not be services (?).Jan 30 2019, 5:01 PM