Page MenuHomePhabricator

jungsi (Simon Jung)
User

Projects

User Details

User Since
Apr 3 2017, 9:50 AM (170 w, 1 d)

Recent Activity

Jul 19 2019

jungsi moved T23742: Implement proof of concept for new segmentation data type from MITK Meeting to Backlog on the Request for Discussion board.
Jul 19 2019, 9:33 AM · MITK

Jul 12 2019

jungsi added a comment to T23742: Implement proof of concept for new segmentation data type.
  • Auflistung von Anforderungen!
  • Check
    • Dicom Derived Tag (verbinden der repräsentationen und originale) (Source)
    • Dicom Surface Segmentation
    • Source Entity und Image (Tags) Referenced Image and Instance Sequence
  • Bei Contour Tools Contours speichern
  • Mischen der Masterrepräsentationen in Anwendung und Speichern
  • Komplexität bei Arbeit mit binär und fractional (Toolunterstützung)
  • Wird ContourModel noch woanders verwendet? Noch aktuell?
  • Complexity Plugin
  • Tool defines what data works
  • Wishlist GUI abstrakt toolkitunabhängig definieren (Parameterdefinition)
Jul 12 2019, 2:34 PM · MITK

Jul 5 2019

jungsi moved T23742: Implement proof of concept for new segmentation data type from Backlog to MITK Meeting on the Request for Discussion board.
Jul 5 2019, 10:16 AM · MITK
jungsi added a project to T23742: Implement proof of concept for new segmentation data type: Request for Discussion.

Regarding the segmentation data type the PolySeg project should be kept in mind as it offers flexibility in the representation of the segments.
They also define a segmentation and a segment class although neither of them directy "is" the data. A segment keeps a list of representations (i.e. vtkDataObjects in their case) that actually hold the image / surface / contour data.
Making the segment directy inherit from Image creates a strong bond to the representation as labelmask (binary or fractional) but leaves out representation of contours and surfaces for example.
In this regard one proposal would roughly follow this class layout:


Here one segment could be represented as one label (or as contours, a surface, etc.).
In the case of a labelmap it would make sense to hold a binary image or as Stefan mentioned uint16 or unsigned short for fractional labels.

Jul 5 2019, 10:16 AM · MITK

Jun 6 2019

jungsi committed rMITKf023337cb38a: Updated reference tracking of the mapper service (authored by jungsi).
Updated reference tracking of the mapper service
Jun 6 2019, 3:19 PM

Jun 5 2019

jungsi committed rMITK1e45ac1b329c: Fixed wrong fileName and dataType (authored by jungsi).
Fixed wrong fileName and dataType
Jun 5 2019, 2:07 PM
jungsi committed rMITKefa663751cd2: corrected the layout's file name (authored by jungsi).
corrected the layout's file name
Jun 5 2019, 2:00 PM
jungsi committed rMITKc91a20cb518d: Removed comment and unneded layouts (authored by jungsi).
Removed comment and unneded layouts
Jun 5 2019, 2:00 PM
jungsi committed rMITK4d78894bce7f: Added tests for the annotation factory Moved default values of the layout… (authored by jungsi).
Added tests for the annotation factory Moved default values of the layout…
Jun 5 2019, 2:00 PM
jungsi committed rMITK5c088fc6b49e: Added example annotation layout (authored by jungsi).
Added example annotation layout
Jun 5 2019, 2:00 PM
jungsi committed rMITK16bb2a7f36ae: Added tests for the new annotation data providers (authored by jungsi).
Added tests for the new annotation data providers
Jun 5 2019, 2:00 PM
jungsi committed rMITK5a816adcbfe8: Architectural change: Allowed definition of lambdas to configure a data… (authored by jungsi).
Architectural change: Allowed definition of lambdas to configure a data…
Jun 5 2019, 1:59 PM
jungsi committed rMITK2daab83aba40: Added TimeStepProvider and used it in TemporoSpatialPropertyProvider (authored by jungsi).
Added TimeStepProvider and used it in TemporoSpatialPropertyProvider
Jun 5 2019, 1:59 PM
jungsi committed rMITK304a57534a6b: Make AnnotationTemporoSpatialPropertyProvider derive from… (authored by jungsi).
Make AnnotationTemporoSpatialPropertyProvider derive from…
Jun 5 2019, 1:59 PM
jungsi committed rMITK5372b0a45bac: Simplyfied DataProviders (authored by jungsi).
Simplyfied DataProviders
Jun 5 2019, 1:59 PM
jungsi committed rMITKfc4f16d1a153: Added view to plugin (authored by jungsi).
Added view to plugin
Jun 5 2019, 1:59 PM
jungsi committed rMITK9fc67cb87e45: Fixed linker errors plus small refactoring (authored by jungsi).
Fixed linker errors plus small refactoring
Jun 5 2019, 1:59 PM
jungsi committed rMITKaf2159e50c28: Major refactoring of plugin activator making use of prior extracted classes (authored by jungsi).
Major refactoring of plugin activator making use of prior extracted classes
Jun 5 2019, 1:59 PM
jungsi committed rMITK07342afe9dc4: Extracted loading functionality of annotation presets to seperate class (authored by jungsi).
Extracted loading functionality of annotation presets to seperate class
Jun 5 2019, 1:59 PM
jungsi committed rMITK34383a2c2a8c: Extracted node selection listener to seperate class (authored by jungsi).
Extracted node selection listener to seperate class
Jun 5 2019, 1:59 PM
jungsi committed rMITKa7042b8f377d: Added standard / default annotation data providers (authored by jungsi).
Added standard / default annotation data providers
Jun 5 2019, 1:59 PM
jungsi committed rMITK2ed269fa24c3: Add return value to CreateAnnotationsFromConfiguration (authored by jungsi).
Add return value to CreateAnnotationsFromConfiguration
Jun 5 2019, 1:59 PM
jungsi committed rMITK2df27eec4d22: Major refactoring distributing the set of responsibilities of AnnotationFactory… (authored by jungsi).
Major refactoring distributing the set of responsibilities of AnnotationFactory…
Jun 5 2019, 1:59 PM
jungsi committed rMITK9015833b7f9f: Refactored annotation plugin and extended tests (authored by jungsi).
Refactored annotation plugin and extended tests
Jun 5 2019, 1:59 PM
jungsi committed rMITKb2e293fc9d47: Refactoring and renaming. Cleanup of includes and include guards (authored by jungsi).
Refactoring and renaming. Cleanup of includes and include guards
Jun 5 2019, 1:58 PM
jungsi committed rMITK03a5b94fcf1e: Added function to save the actual configuration to json (authored by jungsi).
Added function to save the actual configuration to json
Jun 5 2019, 1:58 PM
jungsi committed rMITKa6a6a73c064f: Refactored the annotation factory, fixed SliceChanged method not being called. (authored by jungsi).
Refactored the annotation factory, fixed SliceChanged method not being called.
Jun 5 2019, 1:58 PM
jungsi committed rMITKb9f1ea760079: Added logo annotation (as of now with absolute path only) (authored by jungsi).
Added logo annotation (as of now with absolute path only)
Jun 5 2019, 1:58 PM
jungsi committed rMITK046cad94c611: Ideas regarding custom interdependent DataSources (authored by jungsi).
Ideas regarding custom interdependent DataSources
Jun 5 2019, 1:58 PM
jungsi committed rMITK7f21a1867077: Added first simple tests (authored by jungsi).
Added first simple tests
Jun 5 2019, 1:58 PM
jungsi committed rMITK03e00a9a026f: First draft of the annotations plugin responsible for creating the standard… (authored by jungsi).
First draft of the annotations plugin responsible for creating the standard…
Jun 5 2019, 1:58 PM
jungsi committed rMITK89d71e094673: First draft of the Annotation Module extension for dynamic data (authored by jungsi).
First draft of the Annotation Module extension for dynamic data
Jun 5 2019, 1:58 PM

Feb 1 2019

jungsi committed rMITK2e78ba8c1a96: Merge branch 'T25971-error-bars-in-chart-plugin' (authored by jungsi).
Merge branch 'T25971-error-bars-in-chart-plugin'
Feb 1 2019, 4:43 PM
jungsi closed Restricted Maniphest Task, a subtask of T25683: Chart Example Plugin, as Resolved.
Feb 1 2019, 4:43 PM · MITK
jungsi committed rMITKc9ca2a9dd640: Error bars can now be testet in the example plugin Fixes T25971 (authored by jungsi).
Error bars can now be testet in the example plugin Fixes T25971
Feb 1 2019, 4:43 PM
jungsi closed Restricted Maniphest Task, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 1 2019, 3:10 PM · Restricted Project, MITK
jungsi committed rMITK84eae8aa0a63: Merge branch 'T25968-error-bars-x-direction' (authored by jungsi).
Merge branch 'T25968-error-bars-x-direction'
Feb 1 2019, 2:40 PM
jungsi committed rMITKa56d642610b2: Enable error bars in x direction Fixes T25968 (authored by jungsi).
Enable error bars in x direction Fixes T25968
Feb 1 2019, 2:35 PM
jungsi committed rMITK244c9a325fba: Enabled asymmetric error bars Fixes T25969 (authored by jungsi).
Enabled asymmetric error bars Fixes T25969
Feb 1 2019, 1:15 PM
jungsi committed rMITK8a4bdaa35c8d: Merge branch 'T25867-chart-error-bars' (authored by jungsi).
Merge branch 'T25867-chart-error-bars'
Feb 1 2019, 11:25 AM

Jan 28 2019

jungsi added a comment to T25927: Creating Annotations in fast succession assigns them the same GUIDs.

Yes, that is correct

Jan 28 2019, 9:29 AM · MITK

Jan 25 2019

jungsi triaged T25927: Creating Annotations in fast succession assigns them the same GUIDs as Low priority.
Jan 25 2019, 12:04 PM · MITK

Sep 25 2018

jungsi committed rMITK86bbf56add57: Merge branch T25447-adaptRowCountOfImageStatisticsTableModel (authored by jungsi).
Merge branch T25447-adaptRowCountOfImageStatisticsTableModel
Sep 25 2018, 4:21 PM
jungsi committed rMITK059b8913dec3: Using the member variable for the row count instead of a temporary (authored by jungsi).
Using the member variable for the row count instead of a temporary
Sep 25 2018, 4:15 PM

Sep 12 2018

jungsi committed rMITK0e8172446db7: Fixed missing include and function body. Did some cleanup of the… (authored by jungsi).
Fixed missing include and function body. Did some cleanup of the…
Sep 12 2018, 10:52 AM

Sep 10 2018

jungsi committed rMITK99be8db6d334: Cleanup of the CoreObjectFactory (authored by jungsi).
Cleanup of the CoreObjectFactory
Sep 10 2018, 3:35 PM
jungsi committed rMITKb88c780e5a14: Removed functionality to react to unregistering services for now (authored by jungsi).
Removed functionality to react to unregistering services for now
Sep 10 2018, 3:35 PM
jungsi committed rMITKe674d82334dc: Moved tracking from COF to DataNodes (authored by jungsi).
Moved tracking from COF to DataNodes
Sep 10 2018, 3:35 PM
jungsi committed rMITK943233539a2a: Removed SUPPORTED from service property names (authored by jungsi).
Removed SUPPORTED from service property names
Sep 10 2018, 3:35 PM
jungsi committed rMITKd24d272b5a35: Migrated service for paper (authored by jungsi).
Migrated service for paper
Sep 10 2018, 3:35 PM
jungsi committed rMITK9692f1b8878e: Added consumer and service tracking in COF (authored by jungsi).
Added consumer and service tracking in COF
Sep 10 2018, 3:35 PM
jungsi committed rMITK01efff1b4656: Refactored Module (authored by jungsi).
Refactored Module
Sep 10 2018, 3:35 PM
jungsi committed rMITKb64de06e5d7d: temp change that AMS registers two services for 2D and 3D (authored by jungsi).
temp change that AMS registers two services for 2D and 3D
Sep 10 2018, 3:35 PM
jungsi committed rMITK2eb931ebb5de: Plugin commit (authored by jungsi).
Plugin commit
Sep 10 2018, 3:35 PM
jungsi committed rMITK61d8e1a8f8e6: Added example mapper service module (authored by jungsi).
Added example mapper service module
Sep 10 2018, 3:35 PM
jungsi committed rMITKd34cdc83986e: Created module for service monitoring (authored by jungsi).
Created module for service monitoring
Sep 10 2018, 3:35 PM
jungsi committed rMITK3f1732ba7fed: Changed typeid to GetStaticNameOfClass() (authored by jungsi).
Changed typeid to GetStaticNameOfClass()
Sep 10 2018, 3:34 PM
jungsi committed rMITK143f14ce6687: First prototype of mapper services (authored by jungsi).
First prototype of mapper services
Sep 10 2018, 3:34 PM
jungsi added a comment to T25425: Provide mapper functionality using CppMicroServices.

Pushed new branch T25425-MapperAsServices.

Sep 10 2018, 3:34 PM · MITK
jungsi triaged T25425: Provide mapper functionality using CppMicroServices as Normal priority.
Sep 10 2018, 3:19 PM · MITK

Jul 9 2018

jungsi added a comment to T25030: Image navigator time slider moves twice.

Using the most recent master on my laptop (my pc build failed) I couldn't reliably reproduce the issue.
Maybe it's specific to the imageStatistics branch or my machine.

Jul 9 2018, 3:34 PM · MITK (2020)
jungsi added a comment to T25030: Image navigator time slider moves twice.

Should also have mentioned that I tested this on branch T24182-newImageStatisticsPlugin.
Im building the master atm so I'll report if it has the same result

Jul 9 2018, 11:22 AM · MITK (2020)
jungsi added a comment to T25030: Image navigator time slider moves twice.

Of course, steps to reproduce:

  • Load MITK-Data\3D+t-ITKIO-TestData\LinearModel_4D_arbitrary_time_geometry.nrrd
  • Doing a normal press should now step 2 time steps at once
  • Doing a really short press should allow you to single step

One more thing to try:

  • Start MITK in Debug configuration
  • Load MITK-Data\Pic2DplusT.nrrd
  • Stepping should work fine
  • Set a breakpoint on QmitkImageStatisticsReloadedView::OnTimeChanged
  • Stepping once should now always trigger the event twice (and the slider gets moved two steps as well)
Jul 9 2018, 9:26 AM · MITK (2020)
jungsi committed rMITK801e1c0230e7: Corrected check for nullptr Fixes T25036 (authored by jungsi).
Corrected check for nullptr Fixes T25036
Jul 9 2018, 9:12 AM

Jul 6 2018

jungsi created T25030: Image navigator time slider moves twice.
Jul 6 2018, 1:38 PM · MITK (2020)
jungsi committed rMITK8b12ef1f519f: Added observer for image navigator time step change event Fix T24653 (authored by jungsi).
Added observer for image navigator time step change event Fix T24653
Jul 6 2018, 11:55 AM

Feb 16 2018

jungsi added a reverting change for rMITK2c48d69e2360: Resolved T24171 removed getter functions in MitkChart: rMITK38883d82b045: Revert "Resolved T24171 removed getter functions in MitkChart".
Feb 16 2018, 3:44 PM
jungsi committed rMITK38883d82b045: Revert "Resolved T24171 removed getter functions in MitkChart" (authored by jungsi).
Revert "Resolved T24171 removed getter functions in MitkChart"
Feb 16 2018, 3:44 PM
jungsi committed rMITK3ea3a896611d: T23543: Added test driver and three basic tests (authored by jungsi).
T23543: Added test driver and three basic tests
Feb 16 2018, 3:44 PM

Feb 15 2018

jungsi committed rMITK9ea938ba7f3e: Removed the outer groupBox (authored by jungsi).
Removed the outer groupBox
Feb 15 2018, 4:00 PM
jungsi committed rMITKfd876e8d0124: Set sizeHint for ChartWidget to stop it from growing to large vertically (authored by jungsi).
Set sizeHint for ChartWidget to stop it from growing to large vertically
Feb 15 2018, 4:00 PM
jungsi committed rMITKb65dff163184: Fixed warning about layout reassignment (authored by jungsi).
Fixed warning about layout reassignment
Feb 15 2018, 4:00 PM

Feb 9 2018

jungsi committed rMITKd9f66c3344ba: Updated both modules' layout to automatically resize (authored by jungsi).
Updated both modules' layout to automatically resize
Feb 9 2018, 1:38 PM
jungsi committed rMITK5d3a274116ca: Implemented basic QmitkIntensityProfileVisualizationWidget (authored by jungsi).
Implemented basic QmitkIntensityProfileVisualizationWidget
Feb 9 2018, 1:38 PM

Feb 8 2018

jungsi committed rMITK259ecbaa4224: Merge branch 'T24204-QMitkHistogramVisualizationWidget' into T24182… (authored by jungsi).
Merge branch 'T24204-QMitkHistogramVisualizationWidget' into T24182…
Feb 8 2018, 5:11 PM
jungsi committed rMITKf2c4b4b54eb1: Changed the name of the ui file (authored by jungsi).
Changed the name of the ui file
Feb 8 2018, 4:12 PM
jungsi committed rMITKa3572122d8f2: Changes according to styleguide (authored by jungsi).
Changes according to styleguide
Feb 8 2018, 3:43 PM
jungsi committed rMITK70dab9dd9abe: Removed unused Stack Widget (authored by jungsi).
Removed unused Stack Widget
Feb 8 2018, 3:43 PM
jungsi committed rMITK8c202de3a12e: Implemented public API and slots (authored by jungsi).
Implemented public API and slots
Feb 8 2018, 3:08 PM
jungsi committed rMITK93940e72681f: Added module skeleton for custom HistogramWidget (authored by jungsi).
Added module skeleton for custom HistogramWidget
Feb 8 2018, 11:45 AM

Jan 19 2018

jungsi added a comment to T23593: Segmentation tool button font color is black with dark theme.

Concluding my findings:
Colors are defined in ...\mitk\Plugins\org.blueberry.ui.qt\resources\darkstyle.qss

Jan 19 2018, 12:05 PM · Restricted Project, MITK
jungsi added a comment to T23593: Segmentation tool button font color is black with dark theme.

The text color is indeed driven by the QWidget lines shown above.
Changing it could look like this:


Note that the color chosen is merely an example. Someone with a bit more understanding of design should decide for the final hex value to be used.

Jan 19 2018, 9:44 AM · Restricted Project, MITK

Jan 4 2018

jungsi added a comment to T23593: Segmentation tool button font color is black with dark theme.

This seems to be a stylesheet setting regarding disabled elements.
If an image is chosen and the buttons get enabled they change to the right color as seen here:


This issue isn't restricted to the Segmentation tool but seems to regard all disabled elements in other tools as well.
When checking the darkstyle.qss file it can be noted that all disabled elements get attributed a blackish color as seen for QWidget as example here:

To change the color of disabled text this stylesheet is most likely the place to modify although I couldn't figure out right away which classes are affected. Maybe someone with deepler knowledge can help out. I'll take a close look on Community Day

Jan 4 2018, 3:47 PM · Restricted Project, MITK

Jun 27 2017

jungsi committed rRTTB97ff61979668: Merged T21862 (authored by jungsi).
Merged T21862
Jun 27 2017, 11:31 AM
jungsi committed rRTTB8b45e3adc6c6: Fixed T21862 (authored by jungsi).
Fixed T21862
Jun 27 2017, 11:31 AM
jungsi committed rRTTBb8c5cc49ff0b: Changes after code review (authored by jungsi).
Changes after code review
Jun 27 2017, 11:31 AM
jungsi committed rRTTB03027d965fc5 (authored by jungsi).
Jun 27 2017, 11:31 AM

May 5 2017

jungsi placed T22218: Es gibt noch Funktionen in rttb, die nicht getestet sind up for grabs.
May 5 2017, 12:44 PM · Restricted Project

May 2 2017

jungsi moved T22218: Es gibt noch Funktionen in rttb, die nicht getestet sind from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 2 2017, 9:50 AM · Restricted Project

Apr 27 2017

jungsi added a comment to T22218: Es gibt noch Funktionen in rttb, die nicht getestet sind.

Originally I was planning on reviewing all of the three coverage tools and present them here. This consumes a substantial amount of time though and I could further improve the efficiency of analyzing code coverage with OpenCppCoverage. These are the reasons why the other two tools won't be discussed here as of now.
Instead I'll try to give you a detailed description of what I think is the easiest way to analyze the code coverage with OpenCppCoverage.

Analyzation toolchain

I wrote a little executable to do the hard work (i.e. searching the Test names and additional parameters in the CMakeLists files of the test folder).
Usage:


So as we see we need "only" five arguments for the tool to work.

Apr 27 2017, 4:03 PM · Restricted Project

Apr 12 2017

jungsi added a comment to T22218: Es gibt noch Funktionen in rttb, die nicht getestet sind.

I looked further into OpenCppCoverage due to the fact that it is also available as a visual studio extension and thus could be integrated in the daily workflow easily.

Apr 12 2017, 4:50 PM · Restricted Project

Apr 10 2017

jungsi added a comment to T22218: Es gibt noch Funktionen in rttb, die nicht getestet sind.

For this task it should be considered to look into Test Coverage / Code coverage and what Software can help us identify the parts of code that aren't tested yet.

Basic coverage criteria

With code coverage software there are several different criteria the tool can look out for. The main ones are (from "weakest" to the most strict one):

  • Function coverage: Has each function in the program been called by at least one test?
  • Statement coverage: Has each statement in the program been executed?
  • Branch coverage: Has each branch (i.e. if, else, case, etc.) been excecuted?
  • Condition coverage: Has each Boolean sub-expression evaluated both true and false at least once?

This is only a brief introduction to the different criterea. Anyone that is interested in a visual example can have a look here:
https://www.johner-institut.de/blog/iec-62304-medizinische-software/code-coverage/

Apr 10 2017, 11:01 AM · Restricted Project
jungsi claimed T22218: Es gibt noch Funktionen in rttb, die nicht getestet sind.
Apr 10 2017, 9:34 AM · Restricted Project