Page MenuHomePhabricator | MITK

Update TestingMacros
Closed, ResolvedPublic

Description

mitkImageStatisticsCalculatorTest uses old testing macros. These should be updated to CPPUNIT

Event Timeline

kraeuter created this task.Feb 8 2019, 1:58 PM
kraeuter triaged this task as Normal priority.

This old macros could be the reason for T25716

I read through the logs after testing and the tests now fail completely when on of the conditions isn´t met.
I compared the testing logs with the master and noticed, that the fails existed before but the test didn´t notify accordingly.

Following tests fail because the noted condition is not met:
->Pic3D

std::abs(kurtosisObject - kurtosis) < mitk::eps

->Pic3D SagittalPF

std::abs(varianceObject - variance) < mitk::eps

->Pic3D CoronalPF

std::abs(varianceObject - variance) < mitk::eps
old macro: minIndex also fails (exp: 127 calc: 128)

->Pic3DImageMask lb1

std::abs(varianceObject - variance) < mitk::eps

->Pic3DImageMask lb2

std::abs(varianceObject - variance) < mitk::eps

->Pic3DIgnorePixelValue

Expression: std::abs(kurtosisObject - kurtosis) < mitk::eps

->US4DCyl AxialPF

std::abs(varianceObject - variance) < mitk::eps

->US4DCyl CoronalPF

std::abs(varianceObject - variance) < mitk::eps
old macro: minIndex also fails (exp: 169 calc: 170)

->US4DCyl IgnorePixelValue

std::abs(varianceObject - variance) < mitk::eps
hentsch closed this task as Resolved.Thu, Mar 28, 3:59 PM
hentsch claimed this task.

done in f29b6e694d1a