Page MenuHomePhabricator

Prepare Qt 5.13 compatibility
Closed, ResolvedPublic

Description

Currently MITK does not build with Qt version >= 5.13 , mostly because of deprecated methods. In general we will stick with 5.12 since it is a long term support release of Qt, but this task will track preparations for Qt 5.13 compatibility.

Revisions and Commits

Event Timeline

nolden triaged this task as Low priority.Oct 2 2019, 1:54 PM
nolden created this task.
kislinsk added a subscriber: kislinsk.

At least on Windows the Qt 5.13.1 CMake scripts do not work when trying to find Qt5UiTools as the script isn't able to find the release and debug library paths of Qt5Core. I had to manually set the corresponding CMake variables in the MITK-superbuild, the CTK-superbuild, the CTK-build, and the MITK-build.

We need to fix CTK as well.

For now we should stick with the Qt 5.12 LTS, as long as 5.13 does not work reliably (see Windows issue above). We can add a CMake warning/error for now that does not allow to proceed configuring MITK with Qt > 5.12.

Status as of now:

  • releases/2018-04: Qt >5.12 is not allowed anymore, minimum required version still 5.11.1
  • master: Qt > 5.12 is not allowed anymore, minimum required version now also 5.12

on MITK master:

commit c556e27481e6aa22919dcd0161556382ba4feb3e (HEAD -> master, origin/master, origin/HEAD)
Merge: 813e0bf265 e24e19794d
Author: Stefan Dinkelacker <s.dinkelacker@dkfz-heidelberg.de>
Date: Thu Oct 17 11:08:56 2019 +0200

Merge branch 'T26721-Qt-5.12'

... if trying to build with Qt version 5.12.5:

CMake Error at CMakeLists.txt:268 (message):
**Qt version 5.12 is not yet supported.  We recommend using the latest
long-term support version 5.12.x.**

On the other hand if trying to build with Qt version 5.11.3 (Debian/Devuan package) cmake complains that Qt was too old and wanted at least 5.12

Looks like some conflicting spec ? {version x | 5.12 <= x < 5.12} = {}

nolden renamed this task from Fix Qt 5.13 compatibility to Prepare Qt 5.13 compatibility.Oct 19 2019, 9:27 AM
nolden updated the task description. (Show Details)

Oops, thanks for the fix. 👍

kislinsk raised the priority of this task from Low to Normal.
kislinsk edited projects, added MITK (v2021.02), Cleared; removed MITK.
kislinsk edited subscribers, added: neher; removed: ericheim, hettich, kalali.

I wasn't able to build CTK with Qt 5.12.8 on Windows with Visual Studio 2019 16.6.0 and CMake 3.17.1 because of linker errors related to QLinkedList. I just tried the latest Qt 5.15 and at least CTK builds successfully. @neher told me some days ago that Qt 5.13 and/or 5.14 worked as well for him, so we should probably remove the hard check against Qt versions greater or equal to 5.13.

Qt 5.15 is not working with qwt 6.1, though.

edit: Not yet, but very soon: https://sourceforge.net/p/qwt/bugs/314/ Was able to build qwt with the latest snapshot of the 6.1 branch.

Our current version of VTK does not work with Qt 5.15. I'm just going back to 5.12.6 for now, as I didn't plan to pump so much time into this issue.

Sigh, CTK with Qt 5.12.6 fails with the same linker error (definitely worked in the past). I guess it is VS 2019 16.6.0 then.

When using Qt 5.13 on Ubuntu 20.04 I had no issues with our third party libraries, only a lot of deprecated warnings as errors in MITK and other minor issues.

kislinsk edited projects, added MITK; removed Cleared, MITK (v2021.02).
neher added a revision: Restricted Differential Revision.Jun 18 2020, 9:38 AM
kislinsk claimed this task.

Deleted branch T26721-Qt-5.13.