Page MenuHomePhabricator

New signal type signature leads to undefined signals
Closed, ResolvedPublic

Description

In D250 a change was made to the QmitkAbstractNodeSelectionWidget: https://phabricator.mitk.org/D250#inline-1868 which changed the type signature of the signal being emitted by sub-classes. This leads to undefined signals and thus broken signal-slot connections.

I propose to re-check the refactored plugins and change the connect's from something like this

connect(selectionSlot, SIGNAL(CurrentSelectionChanged(QList<mitk::DataNode::Pointer>)), selectionReceiver, SLOT(ChangeServiceSelection(QList<mitk::DataNode::Pointer>)));

to something like this

connect(selectionSlot, &QmitkAbstractNodeSelectionWidget::CurrentSelectionChanged, selectionReceiver, &QmitkSelectionServiceConnector::ChangeServiceSelection);

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kalali triaged this task as Unbreak Now! priority.Mar 3 2020, 2:12 PM
kalali created this task.
kalali added a revision: Restricted Differential Revision.
floca added a revision: Restricted Differential Revision.Mar 4 2020, 4:50 PM

@kalali Was this task only meant for CurrentSelectionChanged connections or all old style connections?

Only for the CurrentSelectionChanged, since this led to an error and if we fix it, we might use the new syntax anyway. I think refactoring all old style connections could be a task for a dedicated hacking day - maybe with some batch-refactoring?

floca claimed this task.

Ok. Then this task can be closed.

@kalali An extra task is a good idea. Could you create one and enter your ideas? Thanks.