Currently our clang format file seems to enforce
type *name
while most of our code base is
type* name
this generates a lot of code noise in diffs if using features in VS2019 to auto format directly.
Further I think the style in the code base
type* name
makes more sense nowadays, because I would put the priority on method signatures and not on c-ish data definitions.
Want to discuss and clarify it.
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Wontfix | None | T24402 Improve clang-format support | ||
| Resolved | kislinsk | T27190 Clang format style for * and & at variables |
Agree, but I also recommend to disable the auto-formatting in VS2019, as we had quite some inconsistencies in the past with it. When we agreed on a final clang-format, we should apply it to the whole code base (master) and after that look into reenabling the feature in VS2019.
Hi there! 🙂
This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑
Best wishes,
The MITK devs
there is a DerivePointerAlignment option which basically unifies it on a file by file basis, in case there is no agreement. But I agree to Ralf with using the "left" style and put it next to the type
This task was closed here on Phabricator since it was migrated to GitLab. Please continue on GitLab.