Page MenuHomePhabricator

Suppress or fix all build warnings
Open, NormalPublic


Currently the MITK build produces a lot of warnings. They are mostly non-critical, but this behaviour makes it difficult to spot new ones, either during developemt or on the dashboard. I suggest we go through the actual warning types that show up and decide weather

  1. fix it everywhere and turn on warning as error for that specific warning
  2. suppress it completely if it's too much effort to fix it now and file another task for it
  3. suppress it completely as irrelevant and document this in the code

Benefit would be a warning-free situation which hopefully prevents future errors and bugs.

Event Timeline

kislinsk triaged this task as Normal priority.Jun 18 2020, 11:04 PM
kalali added a project: Restricted Project.

I think this is a good tasks that can be done by everyone. Check the warnings on your local MITK build and see if you can fix them.
Also, go to -> "Build" column -> "Warn" column (inside the "Nightly" section) and click on the number of your system (e.g. See if you can fix some of the mentioned warnings (e.g.

/home/ubuntu/jenkins-agent/MITK/Nightly/src/MITK/Modules/ContourModel/DataManagement/mitkContourElement.cpp: In member function ‘void mitk::ContourElement::InsertVertexAtIndex(const Point3D&, bool, mitk::ContourElement::VertexSizeType)’:
[CTest: warning matched] /home/ubuntu/jenkins-agent/MITK/Nightly/src/MITK/Modules/ContourModel/DataManagement/mitkContourElement.cpp:107:13: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
   if (index >= 0 && this->GetSize() > index)

Also: Many warnings are related to doxygen so please have a look if you can fix something there (missing references etc.).