Page MenuHomePhabricator
Create Task
Maniphest T27377

Suppress or fix all build warnings
Open, NormalPublic
Actions

Description

Currently the MITK build produces a lot of warnings. They are mostly non-critical, but this behaviour makes it difficult to spot new ones, either during developemt or on the dashboard. I suggest we go through the actual warning types that show up and decide weather

  1. fix it everywhere and turn on warning as error for that specific warning
  2. suppress it completely if it's too much effort to fix it now and file another task for it
  3. suppress it completely as irrelevant and document this in the code

Benefit would be a warning-free situation which hopefully prevents future errors and bugs.

Event Timeline

nolden created this task.May 6 2020, 1:55 PM
kalali added a subscriber: kalali.May 6 2020, 2:30 PM
kislinsk triaged this task as Normal priority.Jun 18 2020, 11:04 PM
kislinsk edited projects, added MITK, Next Milestone; removed MITK (v2021.02).Mar 10 2021, 9:09 AM
floca edited projects, added MITK (v2021.10); removed Next Milestone, MITK.Apr 9 2021, 6:27 PM
kislinsk edited projects, added MITK (v2022.04); removed MITK (v2021.10).Nov 10 2021, 4:32 PM
kalali moved this task from Backlog to Cycle on the MITK (v2022.04) board.Nov 18 2021, 1:36 PM
kalali added a project: Restricted Project.

I think this is a good tasks that can be done by everyone. Check the warnings on your local MITK build and see if you can fix them.
Also, go to https://cdash.mitk.org/index.php?project=MITK -> "Build" column -> "Warn" column (inside the "Nightly" section) and click on the number of your system (e.g. https://cdash.mitk.org/viewBuildError.php?type=1&buildid=15376). See if you can fix some of the mentioned warnings (e.g.

/home/ubuntu/jenkins-agent/MITK/Nightly/src/MITK/Modules/ContourModel/DataManagement/mitkContourElement.cpp: In member function ‘void mitk::ContourElement::InsertVertexAtIndex(const Point3D&, bool, mitk::ContourElement::VertexSizeType)’:
[CTest: warning matched] /home/ubuntu/jenkins-agent/MITK/Nightly/src/MITK/Modules/ContourModel/DataManagement/mitkContourElement.cpp:107:13: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
   if (index >= 0 && this->GetSize() > index)

Also: Many warnings are related to doxygen so please have a look if you can fix something there (missing references etc.).
s434n added a subscriber: s434n.Apr 28 2022, 1:35 PM
kislinsk edited projects, added Next Milestone, MITK; removed MITK (v2022.04).Apr 29 2022, 1:38 PM
kislinsk edited projects, added MITK (v2023.12); removed MITK, Next Milestone.May 17 2023, 2:57 PM
kislinsk edited projects, added MITK (v2024.06); removed MITK (v2023.12).Dec 5 2023, 10:38 AM
MITK · MIC · IMSY · DKFZ