Page MenuHomePhabricator

"Reinit" warning visible too long
Closed, ResolvedPublic

Description

  • start application
  • activate "segmentation" perspective
  • load Pic3D

effect: the "perform reinit on patient image" warning is still visible
wanted: the warning should be hidden

(the warning is hidden as soon as the user clicks anywhere in DataManager)

Probably related to the other selection issues. Sabrina, could you look into this?

Related Objects

Event Timeline

Actually right now this is not only the "reinit" warning but all three warning labels: "Select an image!", "Perform 'reinit' on patient image!" and "Select or create a segmentation!".

The cause seems to be that QmitkSegmentationView::UpdateFromCurrentDataManagerSelection() is not working as expected. Somehow the selection cannot be queried like that at the point where QmitkSegmentationView is initialized.

Michi or Sascha, do you know any reason why DataManager or the selection service create such a behavior? Did I implement QmitkSegmentationView::UpdateFromCurrentDataManagerSelection() wrongly?

Following the three steps listed in the bug description loads the Pic3D file as excepted. In the datamanager, nothing is selected, hence the "warnings" of the segmentation view are still here. This is actually normal behaviour.

There was a discussion about automatically selecting the newly loaded data. This would probably solve your problem.

You are right, this "nothing is selected" is what I expect. With the mentioned method QmitkSegmentationView::UpdateFromCurrentDataManagerSelection() I try to query the current selection. Right after loading an image I would expect to get a selection object that represents an empty selection. Instead I get no valid selection at all.

Michi, could this be an error in DataManager? Do you provide an empty selection on creation/initialization of DataManager?

[SVN revision 20086]
FIX (#2832): pay attention to DataTreeNodeSelections instead of IStructuredSelections to solve initial empty selection problem

last commit fixes this issue for me

Merging "applicazion modules" component with "ExtApp plugins"