Page MenuHomePhabricator

Redesign StateMachine loading mechanism
Closed, DuplicatePublic

Description

Follow-Up Bug of #2413.

Open feature requests:

  • Split StateMachine.xml to Bundles, so that Bundles that need a StateMachine get it initialized automatically on activation.
  • Clean up the State machines. This is actually a by-product of point one.
  • Seperate EventMapper init from StateMachines (?)

Related Objects

Event Timeline

needs intensive redesign an no quickhacks, Working so far fine so not v1.0 relevant

splitting all state machine patterns into bundle files will end in many redundant patterns. Many bundles use for example pattern "pointsetinteraction" and multiple initialization would be the consequence.
I would rather recommend to make it optional if a bundle wants to add a special pattern by loading an xml file containing patterns. Then StateMachineFactory would have to check if the pattern already exists and throw a warning if so.

This has been handled in a new ticket, T13664. Is integrated into MITK master by now.