Page MenuHomePhabricator

[Segmentation] Deactivating tool resets interactions to earlier state
Closed, WontfixPublic


To reproduce:

  1. Open any image in the workbench
  2. Enable PACS mode (Windows -> Preferences -> Editors/Standard Multi Widget -> Use PACS like mouse mode interaction)
  3. Open the Segmentation plugin
  4. Create a new segmentation
  5. Activate any segmentation tool (e.g. Add)
  6. Select a different PACS tool (e.g. Pan)
  7. Deactivate the segmentation tool
  8. Try using the currently selected PACS tool. Although it is still selected in the sidebar, the previous PACS tool (i.e. the one selected before the segmentation tool was activated) is in effect

This task was split up from T26485 as it is connected to that issue, but goes beyond its solution.

Currently, when a segmentation tool is selected, any active DisplayInteractor and DisplayActionEventBroadcast instance (or rather: their config) is saved and then updated to not handle left-mouse-button events, reserving this type of interaction for the segmentation tool. When the tool is deactivated, all configs are restored to the previously saved state. This works well for default MITK interaction, but not for PACS. When the PACS tool is changed during this time, the configuration will still be reset to whatever was the state before activating the segmentation tool.
Some possible approaches have been mentioned in T26485, but since this bug seems to be very rare for users to encounter, is has been split off as it is not as urgent and needs more thought about intended behavior.

Event Timeline

s434n triaged this task as Low priority.Jul 15 2021, 4:59 PM
s434n created this task.
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! ๐Ÿ™‚

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. ๐Ÿš‘

Best wishes,
The MITK devs