[Segmentation] Redundant label "recomputation" for Otsu/Watershed (& nnUNet) when any of the Preview-generated labels are selected to Confirm
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	a178n
	Nov 18 2021, 3:17 PM

Description

In the segmentation tools deriving from AutoMLSegmentationWithPreviewTool tool manager class viz. Otsu and Watershed, when Preview labels are selected for Confirmation; the tool requests the segmentation to be recomputed. In other words, ComputeMLPreview method is called again when a label in the QmitkSimpleLabelListWidget is selected for the first time.

Steps:

Load image into the workbench
Open Segmentation plugin -> Otsu Tool
Click Preview (now OtsuTool3D.ComputeMLPreview method is called to compute a segmentation)
Now click on any of the labels listed in the list widget below.

Again, a redundant call is made to OtsuTool3D.ComputeMLPreview method to recompute the same segmentation.

However, a redundant recomputation never really happens numerically due to some checks implemented in the tool's ComputeMLPreview method to circumvent this behaviour. This is why we don't see a performance drop.

Revisions and Commits

rMITK MITK
	Restricted Differential Revision	rMITK9543f93caadb T29185 Refactor AutoSegmentationTool classes
	Restricted Differential Revision	rMITKfe3e2ae908a3 Fixed review commments
	Restricted Differential Revision	rMITKaaa3d384878c fixed gcc compile errors
	Restricted Differential Revision	rMITK79e4b0b81cc4 BREAKING: Renamed several tool classes
	Restricted Differential Revision	rMITK5add0c5486cf BREAKING: Removed AutoMLSegmentationWithPreviewTool.
	Restricted Differential Revision	rMITK7ed8a5d64e8c BREAKING: Added support of multiple labels to AutoSegmentationWithPreviewTool
	Restricted Differential Revision	rMITKe496dde90787 Fixed reinitializing of LabelSetImage
	Restricted Differential Revision	rMITK7313be2dbf04 Merged class AutoSegmentationTool with AutoSegmentationWithPreviewTool

Related Objects
Search...

		Status	Assigned	Task
		Resolved	floca	T28866 [Segmentation] Redundant label "recomputation" for Otsu/Watershed (& nnUNet) when any of the Preview-generated labels are selected to Confirm
		Resolved	floca	T29185 [Seg] Refactor AutoSegTools and deprecate AutoMLSegWithPreviewTool class

Event Timeline

a178n created this task.Nov 18 2021, 3:17 PM

After some analysis, it is understood that there is a difference in the modified time of the tool and the segmentation. This is detected in the AutoMLSegmentationWithPreviewTool.DoUpdatePreview method if-case of this->GetMTime() > m_MLPreviewNode->GetData()->GetMTime().
This change in time happens because tool->IsTimePointChangeAwareOn() is called after the tool->UpdatePreview() call is made in the tool's GUI class, eg. QmitkOtsuTool3DGUI

floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.Dec 1 2021, 10:50 AM

After being discussed in the MITK meeting, the decision is to include an option in the tools for users to select if the segmentation call should be made dynamically for every time step or not. This option can be provided either in the tool itself or in the Preferences. Thus, users can decide when the tool becomes IsTimePointChangeAwareOn()or IsTimePointChangeAwareOff().
This would further imply that the tool->GetMTime() won't change after a Preview is made and thus, a redundant call to ComputeMLPreview can be avoided.