Page MenuHomePhabricator

[GrowCut] "Undo" only changes slices with seed images
Open, NormalPublic

Description

When pressing the Undo button after confirming a GrowCut segmentation, it reverts only those slices that were previously drawn in as seed images for the GrowCut algorithm, and only one by one (each click reverts a single slice). The rest of the image volume that was filled out by the GrowCut tool can not be reverted.
I would expect "Undo" to revert the complete confirmation in a single step.

Event Timeline

s434n triaged this task as Normal priority.May 4 2023, 1:46 PM
s434n created this task.
floca added a subscriber: floca.

grow cut (as all preview tools) does not generate any undo point right now. What you witness is the undo of your seed painting up front.

We were hesitant to add undo for whole volume due to memory foot print (we should discuss that).

floca added a subtask: Unknown Object (Maniphest Task).May 4 2023, 2:54 PM

Thats because 3D Tools in total do not support undo redo currently.
Sofar we havent dared due to the memory footprint (as it would mean storing copies of the volume); but also never tested it.
May be we should ceck if it is OK in conjunction with compression (introduced by @kislinsk some time ago) and if needed limitations (a max step limit, or clearing the history if the segmentation is finished), to avoid extrem memory consumption due to long undo/redo history.