Page MenuHomePhabricator

RenderingManager crashes
Closed, ResolvedPublic

Description

Avoid a crash when RenderingManager::AddRenderWindow( ) is called after RenderingManager::RequestUpdate( ).

Event Timeline

xplanes added a subscriber: xplanes.

Unified patch

hi xplanes,

we tried to reproduce this, however we didnt get the renderingmanager crashed.

can you tell us more about how the vtkRenderWindow is created and then added to the renderingmanager.

AddRenderWindow is normally not used except in the constructor of QmitkRenderWindow.

Do you have an own (maybe non-QT?) implementation of a renderwindow?

We think this one is not 1.0 relvant because we cannot reproduce this with our Qt based RenderWindows.

(In reply to comment #2)

Do you have an own (maybe non-QT?) implementation of a renderwindow?

Xavi (xplanes) is working at UPF Barcelona on the GIMIAS project. They have integrated MITK in a wxWidgets (non-QT) application.

The patch still makes sense as an additional safety check. Or it is a hint that the design is not optimal ...

I would just check the iterators returned by "find()" for validity.

[250107]: Merge branch 'bug-3289-check-iterators-in-renderingmanager'

Merged commits:

2012-05-30 16:37:08 Sascha Zelzer [7b27e3]
Check if iterators do not point to "end".

MITK-1-0 keyword is obsolete, we use Target Milestones in the future.