The mbilog utility library looks quite messed up and behaves platform dependent.
In a review we should check
- the specification
- tests
- implementation
If specification or tests don't exist, we should define them.
Some obvious shortcomings of the code:
- comments in mbilog.h are only used for license information and for deactivating code
- The FormatSmart method behaves different on Windows; the implementation of this different behavior involves repetition of code parts
- Method names as search2p1 or search2p2 do not follow the MITK style guide
- Variable names as r, s, xs, lft, rgt are not readable
- there is code commented out although we use a version control system