Page MenuHomePhabricator

Review and clean mbilog
Closed, InvalidPublic

Description

The mbilog utility library looks quite messed up and behaves platform dependent.

In a review we should check

  • the specification
  • tests
  • implementation

If specification or tests don't exist, we should define them.

Some obvious shortcomings of the code:

  • comments in mbilog.h are only used for license information and for deactivating code
  • The FormatSmart method behaves different on Windows; the implementation of this different behavior involves repetition of code parts
  • Method names as search2p1 or search2p2 do not follow the MITK style guide
  • Variable names as r, s, xs, lft, rgt are not readable
  • there is code commented out although we use a version control system

Event Timeline

Merging "Utilities" component into "Other"

Resetting all bugs without active assignee flag to "CONFIRMED". Change status to IN_PROGRESS if you are working on it.

Parts of this bug are handled in T10793 and T10540. Should we close this one?

@Daniel: please reopen if you think there is still something missing.

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:33 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:37 PM
kislinsk removed a project: Bulk Edit.