Page MenuHomePhabricator
Create Task
Maniphest T5245

Redesign LevelWindowWidget
Closed, InvalidPublic
Actions

Description

The existing LevelWindowWidget was implemented long time ago. The behavior of the slider is very inconsistent. For example when you move the slider up and down very fast the size of the slider is changed (in order to that also the level and window parameters are modified). Furthermore the widget was built up using a lot of decimal numbers in the code. Nobody could reconstruct the idea behind these numbers (This could e.g. the issue of T2188 where 30px are missing for the mouseMoveEvent).

One possible solution could be to use a spanSlider instead of creating a slider by reimplementing the paintEvent. A first version of the spanSlider (using QxtSpanSlider) is attached to this bug as a patch. To use the new SpanSlider in the application you need to replace the QmitkSliderLevelWindowWidget with the QmitkSpanSliderLevelWindowWidget in QmitkLevelWindowWidget.ui.

Related Objects

Event Timeline

• wald added projects: MITK, Bugzilla.Aug 25 2010, 4:55 PM
• wald added a subscriber: • wald.

New design of the WindowLevelWidget using spanSlider

5245RedesignWindowLevelWidgetUsingQxtSpanSlider.patch6 KBDownload

fritzsck added a subscriber: fritzsck.Aug 25 2010, 6:08 PM

NRRD image file (first unzip!): Image with codomain between zero and one for testing of the level-window mechanism

Michael_FA.zip315 KBDownload

fritzsck added a comment.Sep 29 2010, 2:08 PM

Alex, are you working on the bug? Should we add the party flag?

• goch added a subscriber: • goch.Dec 15 2010, 1:53 PM

The size change when the slider is moved up and down very quickly could be due to the feature, that the window extent can be changed by moving the mouse left or right while the button is pressed instead of up and down.

• vanbruggen added a subscriber: • vanbruggen.Jan 12 2011, 3:22 PM

Going to look at it. At least to get it working for windows with a range smaller than 1.

• vanbruggen added a comment.Jan 12 2011, 3:39 PM

wrote and applied for core modification.

• vanbruggen added a comment.Jan 12 2011, 5:41 PM

We need to define better what we want this widget to do exactly.

maleike added a subscriber: maleike.Jan 19 2011, 4:05 PM

Marco, perhaps you have a different opinion, as I was not at last bug squashing party.

The initial bug description, Thomas' last comment and the wiki page describe three different things. I think this should be sorted properly:

  • if only smaller scales are important, that is fine
  • if a graphical redesign is intended, that would also be fine

In any case, comment #7 is right.

• vanbruggen added a comment.Jan 19 2011, 4:19 PM

For me, only the domain size is an issue. The thing about interaction that caused some confusion turned out to be merely a feature (changing window size by moving the mouse left or right). I would commit only this domain change and then close the bug. Redesigning the whole thing is in my opinion no party bug.

• vanbruggen added a comment.Jan 26 2011, 1:57 PM

The discription does not match what has been actually done.

fritzsck mentioned this in T5610: Create public and internal diffusion imaging perspectives.Oct 6 2010, 4:10 PM
kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:33 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:37 PM
kislinsk removed a project: Bulk Edit.
MITK · MIC · IMSY · DKFZ