Page MenuHomePhabricator
Feed Advanced Search

Dec 7 2020

wiesenfa added a comment to T27494: Check which files are still relevant.

kept select.if(), winner(), extract.workfolow and compareRanks()
and removed everything not supported anymore.
as.warehouse (benchmarkUtils) is not exported, recommend to leave because this may come handy for specific situations

Dec 7 2020, 1:07 PM · challengeR
wiesenfa moved T27494: Check which files are still relevant from Backlog to In Progress on the challengeR (v1.0) board.
Dec 7 2020, 12:56 PM · challengeR
wiesenfa moved T27943: Plot function stability() raises error when used with default values from Backlog to In Progress on the challengeR (v1.0) board.
Dec 7 2020, 11:21 AM · challengeR (v1.0)
wiesenfa added a comment to T27494: Check which files are still relevant.

removed second()

Dec 7 2020, 11:19 AM · challengeR

Dec 4 2020

wiesenfa committed rCHALLENGER6144decf510d: delete funciton second() (unmaintained) (authored by wiesenfa).
delete funciton second() (unmaintained)
Dec 4 2020, 8:49 PM
wiesenfa placed T27971: Provide code for podium plot in vignette "Visualizations" up for grabs.
Dec 4 2020, 8:46 PM · challengeR (v1.0)
wiesenfa added a comment to T27971: Provide code for podium plot in vignette "Visualizations".

What is the problem?
in the extend of the vignette it would be simply

Dec 4 2020, 8:46 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER2e04538d9e1d: podium default topright legend (authored by wiesenfa).
podium default topright legend
Dec 4 2020, 8:44 PM
wiesenfa moved T27915: Podium plot shrinks for long algorithm names from In Progress to Done on the challengeR (v1.0) board.
Dec 4 2020, 8:40 PM · challengeR (v1.0)
wiesenfa added a comment to T27915: Podium plot shrinks for long algorithm names.

legend now always at bottom and dynamically adjusts to number of algorithms and algorithm name length.
Took me almost the day...

Dec 4 2020, 8:40 PM · challengeR (v1.0)
wiesenfa moved T27748: Decide on limit for algorithms in plot legends from In Progress to Done on the challengeR (v1.0) board.
Dec 4 2020, 8:39 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER26eb63cdef48: report podium plot dynamic legend bottom (authored by wiesenfa).
report podium plot dynamic legend bottom
Dec 4 2020, 8:38 PM
wiesenfa committed rCHALLENGER019b63757493: bottom legend in line plot if n.algorithms>20 (authored by wiesenfa).
bottom legend in line plot if n.algorithms>20
Dec 4 2020, 8:38 PM
wiesenfa committed rCHALLENGERdad94cd28be0: bottom legend in stacked frequency if n.tasks>20 (authored by wiesenfa).
bottom legend in stacked frequency if n.tasks>20
Dec 4 2020, 8:38 PM
wiesenfa added a comment to T27748: Decide on limit for algorithms in plot legends.

max number of tasks / algorithms now 20 in stacked frequency and line plots, respectively for legend appear on right, otherwise put on bottom of plot. could also be put to lower number

Dec 4 2020, 12:00 PM · challengeR (v1.0)
wiesenfa added a comment to T27748: Decide on limit for algorithms in plot legends.

only podium plots and line plots actually require algorithms in legend, otherwise algorithm is identifiable from x-axis or facet label. Now, these redundant legends are removed.
besides that stacked frequency plots have colored tasks and respective legend

Dec 4 2020, 11:52 AM · challengeR (v1.0)
wiesenfa committed rCHALLENGER126a4af6fa0c: remove legend if algorithm identifiable in x-axis (authored by wiesenfa).
remove legend if algorithm identifiable in x-axis
Dec 4 2020, 11:41 AM
wiesenfa committed rCHALLENGER4b396c8ddc14: introduce n.tasks in Rmd (authored by wiesenfa).
introduce n.tasks in Rmd
Dec 4 2020, 11:41 AM
wiesenfa committed rCHALLENGER527c8578ee15: introduce n.tasks and n.algorithms in Rmd files (authored by wiesenfa).
introduce n.tasks and n.algorithms in Rmd files
Dec 4 2020, 11:41 AM
wiesenfa committed rCHALLENGERced7c6c06339: improve reporting of used aggregation method (authored by wiesenfa).
improve reporting of used aggregation method
Dec 4 2020, 11:41 AM
wiesenfa committed rCHALLENGER11b645ebaac1: hide output of task names in report 4.2.1 (authored by wiesenfa).
hide output of task names in report 4.2.1
Dec 4 2020, 11:41 AM
wiesenfa moved T27915: Podium plot shrinks for long algorithm names from Backlog to In Progress on the challengeR (v1.0) board.
Dec 4 2020, 9:55 AM · challengeR (v1.0)
wiesenfa moved T27748: Decide on limit for algorithms in plot legends from Backlog to In Progress on the challengeR (v1.0) board.
Dec 4 2020, 9:55 AM · challengeR (v1.0)
wiesenfa moved T27707: na.treat obligatory for report from In Progress to Done on the challengeR (v1.0) board.
Dec 4 2020, 9:36 AM · challengeR (v1.0)
wiesenfa moved T27707: na.treat obligatory for report from Backlog to In Progress on the challengeR (v1.0) board.
Dec 4 2020, 9:36 AM · challengeR (v1.0)
wiesenfa committed rCHALLENGER6ee0e3a4dbd1: messages if na.treat not specified and NA present (authored by wiesenfa).
messages if na.treat not specified and NA present
Dec 4 2020, 9:35 AM

Dec 3 2020

wiesenfa claimed T27748: Decide on limit for algorithms in plot legends.
Dec 3 2020, 10:22 PM · challengeR (v1.0)
wiesenfa moved T27963: Task names printed as R output in Sec. 3.1 of multi-task report from In Progress to Done on the challengeR (v1.0) board.
Dec 3 2020, 10:21 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER1df7fcff2ba7: hide unnecessary text (authored by wiesenfa).
hide unnecessary text
Dec 3 2020, 10:21 PM
wiesenfa moved T27963: Task names printed as R output in Sec. 3.1 of multi-task report from Backlog to In Progress on the challengeR (v1.0) board.
Dec 3 2020, 10:14 PM · challengeR (v1.0)
wiesenfa moved T28033: +scale_* seems to not work in combination with ggList objects from In Progress to Done on the challengeR (v1.0) board.
Dec 3 2020, 10:11 PM · challengeR (v1.0)
wiesenfa added a comment to T28033: +scale_* seems to not work in combination with ggList objects.

works again for single task visualizations. in case multiple plots (a list of plots) is created %++% instead of + must be used for scale_*_() etc
mention in vignette

Dec 3 2020, 10:09 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER2c873612bef5: return gg object if single task (authored by wiesenfa).
return gg object if single task
Dec 3 2020, 10:06 PM
wiesenfa moved T28033: +scale_* seems to not work in combination with ggList objects from Backlog to In Progress on the challengeR (v1.0) board.
Dec 3 2020, 9:52 PM · challengeR (v1.0)
wiesenfa added a comment to T28016: embed web app in package.

ok. just an idea, thought this might help issues with the server because people can run stuff by themselves and still seize the user interface.
can be closed or considered later

Dec 3 2020, 8:48 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGEReaba380339a2: podium: allow linetype and symbol depend on algo (authored by wiesenfa).
podium: allow linetype and symbol depend on algo
Dec 3 2020, 3:38 PM
wiesenfa moved T28055: respect color scheme also for box plots from In Progress to Done on the challengeR (v1.0) board.
Dec 3 2020, 1:57 PM · challengeR (v1.0)
wiesenfa moved T28055: respect color scheme also for box plots from Backlog to In Progress on the challengeR (v1.0) board.
Dec 3 2020, 1:57 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER403c0cc189b4: return gg object for single tasks, respect color scheme (authored by wiesenfa).
return gg object for single tasks, respect color scheme
Dec 3 2020, 1:56 PM
wiesenfa created T28055: respect color scheme also for box plots.
Dec 3 2020, 12:03 PM · challengeR (v1.0)

Nov 27 2020

wiesenfa claimed T28033: +scale_* seems to not work in combination with ggList objects.
Nov 27 2020, 3:23 PM · challengeR (v1.0)
wiesenfa created T28033: +scale_* seems to not work in combination with ggList objects.
Nov 27 2020, 1:55 PM · challengeR (v1.0)

Nov 26 2020

wiesenfa created T28016: embed web app in package.
Nov 26 2020, 8:48 AM · challengeR (v1.0)

Nov 23 2020

wiesenfa claimed T27971: Provide code for podium plot in vignette "Visualizations".
Nov 23 2020, 12:08 PM · challengeR (v1.0)
wiesenfa claimed T27963: Task names printed as R output in Sec. 3.1 of multi-task report.
Nov 23 2020, 12:07 PM · challengeR (v1.0)

Nov 12 2020

wiesenfa claimed T27943: Plot function stability() raises error when used with default values.
Nov 12 2020, 1:20 PM · challengeR (v1.0)
wiesenfa added a comment to T27943: Plot function stability() raises error when used with default values.

It has to be
ordering= names(meanRanks)
i.e. a vector of algorithm names in the ranking order
see reportMultiple.Rmd: ordering_consensus=names(params$consensus)

Nov 12 2020, 1:20 PM · challengeR (v1.0)

Nov 9 2020

wiesenfa claimed T27925: Use cases of annotator option.
Nov 9 2020, 9:48 AM · challengeR
wiesenfa added a comment to T27925: Use cases of annotator option.

will check old documentation/nature communications example

Nov 9 2020, 9:48 AM · challengeR
wiesenfa claimed T27707: na.treat obligatory for report .
Nov 9 2020, 9:46 AM · challengeR (v1.0)
wiesenfa added a comment to T27707: na.treat obligatory for report .

will set a message in as.challenge() that na.treat needed for report and sanity check in report()

Nov 9 2020, 9:46 AM · challengeR (v1.0)

Nov 6 2020

wiesenfa moved T27708: ggplot2 dendrogram from v1.0 to Backlog on the challengeR board.
Nov 6 2020, 11:29 AM · challengeR
wiesenfa claimed T27915: Podium plot shrinks for long algorithm names.
Nov 6 2020, 11:26 AM · challengeR (v1.0)
wiesenfa added a comment to T27925: Use cases of annotator option.

should be working but hasn't been really tested lately. only applies to rank then aggregate. originates from nature communications paper and should be explained there.
For testing I could again compare to Annette's code used at that time.
Wouldn't drop it but you are right that documentation is missing

Nov 6 2020, 11:25 AM · challengeR

Nov 4 2020

wiesenfa moved T27360: compatibility with R4.0.0 from Backlog to Done on the challengeR (v1.0) board.
Nov 4 2020, 8:07 PM · challengeR (v1.0)
wiesenfa claimed T27360: compatibility with R4.0.0.
Nov 4 2020, 8:07 PM · challengeR (v1.0)
wiesenfa added a comment to T27360: compatibility with R4.0.0.

I'm using R 4.0.2 since summer without issues

Nov 4 2020, 8:06 PM · challengeR (v1.0)
wiesenfa added a comment to T27775: only export functions to be used by user.

also roxygen import and also intitialization of S3 methods have to be written in roxygen then and the namespace file is then entirely written by roxygenization (ideally indcluding help)

Nov 4 2020, 8:05 PM · challengeR

Nov 3 2020

wiesenfa added a comment to T27360: compatibility with R4.0.0.

I think this may be closed. There have not been any problems with R 4 and R 4 is generally unproblematic.
Agreed?

Nov 3 2020, 8:41 PM · challengeR (v1.0)
wiesenfa added a comment to T27915: Podium plot shrinks for long algorithm names.

hm, how do you propose to deal with that? Adapt font size of algorithm names? These might get tiny then....

Nov 3 2020, 8:39 PM · challengeR (v1.0)

Oct 15 2020

wiesenfa added a comment to T27794: Stacked frequency plots should switch to single page layout.

stabilityByAlgorithmStacked is now replaced by stabilityByAlgorithm(....., stacked=TRUE)

Oct 15 2020, 2:43 PM · challengeR (v1.0)
wiesenfa moved T27794: Stacked frequency plots should switch to single page layout from In Progress to Done on the challengeR (v1.0) board.
Oct 15 2020, 2:40 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER2fd21713233a: Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into… (authored by wiesenfa).
Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into…
Oct 15 2020, 2:40 PM
wiesenfa committed rCHALLENGER6a7e604bf5f8: Merge branch 'feature/T27794-stackedFrequencies' into develop (authored by wiesenfa).
Merge branch 'feature/T27794-stackedFrequencies' into develop
Oct 15 2020, 2:40 PM
wiesenfa committed rCHALLENGER75ee76a039c2: use print.ggList (authored by wiesenfa).
use print.ggList
Oct 15 2020, 2:40 PM
wiesenfa committed rCHALLENGERd6b7074d84e7: replace stabilityByAlgorithmStacked by stabilityByAlgorithm(...,stacked=T) (authored by wiesenfa).
replace stabilityByAlgorithmStacked by stabilityByAlgorithm(...,stacked=T)
Oct 15 2020, 2:40 PM
wiesenfa moved T27794: Stacked frequency plots should switch to single page layout from Backlog to In Progress on the challengeR (v1.0) board.
Oct 15 2020, 11:27 AM · challengeR (v1.0)
wiesenfa claimed T27794: Stacked frequency plots should switch to single page layout.
Oct 15 2020, 11:27 AM · challengeR (v1.0)

Oct 12 2020

wiesenfa added a comment to T27708: ggplot2 dendrogram .

disadvantage would be dependency on another package facilitating ggplot2 dendrograms

Oct 12 2020, 2:30 PM · challengeR
wiesenfa added a comment to T27708: ggplot2 dendrogram .

current implementation is fine. However, we said it would be nice if all plots (if directly called by users and not within the report) would have the same syntax and could be layouted with ggplot2 syntax. current implementation is using basic R graphics.

Oct 12 2020, 2:30 PM · challengeR
wiesenfa added a comment to T27326: autolayout networks in multi task report ugly.

turned off in v1.0, everything else postponed

Oct 12 2020, 2:27 PM · challengeR

Oct 8 2020

wiesenfa moved T27802: Revise signature of function testThenRank from In Progress to Done on the challengeR (v1.0) board.
Oct 8 2020, 1:20 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER96a5812ece30: fix respect alpha (authored by wiesenfa).
fix respect alpha
Oct 8 2020, 1:20 PM
wiesenfa added a comment to T27802: Revise signature of function testThenRank.

This was a tricky bug, thanks!
alpha is now respected, argument FUN is removed. significance ranking is considered an aggregation step, so testThenRank() is nothing else than aggregateThenRank(FUN="significance").
Note that testThenRank will pass all arguments to decision.challenge(), i.e. it will respect arguments:

Oct 8 2020, 1:15 PM · challengeR (v1.0)
wiesenfa moved T27494: Check which files are still relevant from In Progress to Backlog on the challengeR (v1.0) board.
Oct 8 2020, 12:36 PM · challengeR
wiesenfa moved T27802: Revise signature of function testThenRank from Backlog to In Progress on the challengeR (v1.0) board.
Oct 8 2020, 12:34 PM · challengeR (v1.0)
wiesenfa moved T27456: Extraction of task subset from (bootstrap) ranking does not raise an error for invalid task name from In Progress to Done on the challengeR (v1.0) board.
Oct 8 2020, 12:33 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER7b50eff1c116: subset error messages (authored by wiesenfa).
subset error messages
Oct 8 2020, 12:32 PM
wiesenfa committed rCHALLENGER356105ac93b4: fix test for invalid task name (authored by wiesenfa).
fix test for invalid task name
Oct 8 2020, 12:32 PM
wiesenfa committed rCHALLENGER4d4c7820d18f: adapt test for invalid task names (authored by wiesenfa).
adapt test for invalid task names
Oct 8 2020, 12:32 PM
wiesenfa committed rCHALLENGER85d2f7a263b1: error messages invalid task names (authored by wiesenfa).
error messages invalid task names
Oct 8 2020, 12:32 PM
wiesenfa moved T27456: Extraction of task subset from (bootstrap) ranking does not raise an error for invalid task name from Backlog to In Progress on the challengeR (v1.0) board.
Oct 8 2020, 12:16 PM · challengeR (v1.0)
wiesenfa moved T27793: Plot titles are missing in some line plots from In Progress to Done on the challengeR (v1.0) board.
Oct 8 2020, 11:55 AM · challengeR (v1.0)
wiesenfa committed rCHALLENGER7ae1fb0d69e3: task title in line plot (authored by wiesenfa).
task title in line plot
Oct 8 2020, 11:55 AM
wiesenfa moved T27793: Plot titles are missing in some line plots from Backlog to In Progress on the challengeR (v1.0) board.
Oct 8 2020, 11:30 AM · challengeR (v1.0)
wiesenfa moved T27778: turn off networks from In Progress to Done on the challengeR (v1.0) board.
Oct 8 2020, 11:29 AM · challengeR (v1.0)
wiesenfa committed rCHALLENGERce25f3551296: outcomment networks (authored by wiesenfa).
outcomment networks
Oct 8 2020, 11:29 AM
wiesenfa moved T27778: turn off networks from Backlog to In Progress on the challengeR (v1.0) board.
Oct 8 2020, 11:25 AM · challengeR (v1.0)
wiesenfa moved T27804: Message text from violin plot is cut off in the PDF report from In Progress to Done on the challengeR (v1.0) board.
Oct 8 2020, 10:58 AM · challengeR (v1.0)
wiesenfa committed rCHALLENGER885d495f0efe: violin text improve (authored by wiesenfa).
violin text improve
Oct 8 2020, 10:57 AM
wiesenfa moved T27804: Message text from violin plot is cut off in the PDF report from Backlog to In Progress on the challengeR (v1.0) board.
Oct 8 2020, 7:47 AM · challengeR (v1.0)

Oct 5 2020

wiesenfa claimed T27778: turn off networks.
Oct 5 2020, 10:16 AM · challengeR (v1.0)

Oct 2 2020

wiesenfa closed T27811: turn off networks in report as Invalid.

redundant

Oct 2 2020, 9:45 PM · challengeR (v1.0)
wiesenfa created T27811: turn off networks in report.
Oct 2 2020, 1:05 PM · challengeR (v1.0)
wiesenfa moved T27286: interactive plots from v1.0 to Backlog on the challengeR board.
Oct 2 2020, 12:58 PM · challengeR
wiesenfa claimed T27456: Extraction of task subset from (bootstrap) ranking does not raise an error for invalid task name.
Oct 2 2020, 12:57 PM · challengeR (v1.0)
wiesenfa claimed T27793: Plot titles are missing in some line plots.
Oct 2 2020, 11:19 AM · challengeR (v1.0)
wiesenfa claimed T27802: Revise signature of function testThenRank.
Oct 2 2020, 11:18 AM · challengeR (v1.0)
wiesenfa claimed T27804: Message text from violin plot is cut off in the PDF report.
Oct 2 2020, 11:18 AM · challengeR (v1.0)

Oct 1 2020

wiesenfa added a comment to T27794: Stacked frequency plots should switch to single page layout.

stacked frequency plots are quite neglected. They are not mentioned in the paper. Are they interesting or should they be removed entirely?

Oct 1 2020, 12:05 PM · challengeR (v1.0)