Page MenuHomePhabricator

Segmentation tool button font color is black with dark theme
Closed, ResolvedPublic

Assigned To
Authored By
kislinsk
Oct 24 2017, 1:43 PM
Tags
Referenced Files
F945382: ChangedColor.PNG
Jan 19 2018, 9:44 AM
F936693: enabled.PNG
Jan 4 2018, 3:47 PM
F936698: qss_disabled.PNG
Jan 4 2018, 3:47 PM
F890951: Capture.PNG
Oct 24 2017, 1:43 PM

Description

Capture.PNG (281×288 px, 8 KB)

Event Timeline

This seems to be a stylesheet setting regarding disabled elements.
If an image is chosen and the buttons get enabled they change to the right color as seen here:

enabled.PNG (356×616 px, 13 KB)

This issue isn't restricted to the Segmentation tool but seems to regard all disabled elements in other tools as well.
When checking the darkstyle.qss file it can be noted that all disabled elements get attributed a blackish color as seen for QWidget as example here:
qss_disabled.PNG (104×233 px, 2 KB)

To change the color of disabled text this stylesheet is most likely the place to modify although I couldn't figure out right away which classes are affected. Maybe someone with deepler knowledge can help out. I'll take a close look on Community Day

The text color is indeed driven by the QWidget lines shown above.
Changing it could look like this:

ChangedColor.PNG (361×461 px, 11 KB)

Note that the color chosen is merely an example. Someone with a bit more understanding of design should decide for the final hex value to be used.

👍 We should ask @feldmanc for the final color.

Concluding my findings:
Colors are defined in ...\mitk\Plugins\org.blueberry.ui.qt\resources\darkstyle.qss

  • (l. 337) Change the text color for disabled widgets as shown above
QWidget:disabled
{
  color: #newValue;
  background-color: #323231;
}
  • (l.710) To change the color (background and text) of disabled push buttons which currently are black and thus hard to read
QPushButton:disabled
{
  background-color: #newValue;
  color: #newValue;
}
  • (l. 375) Change the color of GroupBox borders to make them visible again (as mentioned T23852)
QGroupBox
{
  border:1px solid #newValue;
  border-radius: 0px;
  padding-top: 24px;
  font-weight: bold;
}
kislinsk claimed this task.