Page MenuHomePhabricator

Replace old DICOMSeriesReader with the new one
Closed, ResolvedPublic

Description

With T16744 the new refactored DICOM Reader was merged. However the new reader is not used right now in MITK except for Diffusion.
The former reader should be replaced by the new one using the new reader/writer concept. Other DICOM readers like the RT dose and RT struct reader should be adapted accordingly.

Event Timeline

Is this bug still untouched? If this is the case, I would look into it. Is it fine if I base the batch on release 2015.05.2?

User floca has pushed new remote branch:

bug-18289-Replace-old-DICOMSeriesReader

A first service using the auto selection feature of DICOMReader module is integrated.

One open question: Should the workbench be modified to also load this new reader service? If that's the case, someone could give me a hand with the Autoload. It does not seem to be enough to just add the dependency to the application plugin. It only worked for me with the hack to establish a hard coded linkage with the workbench application by using a symbol of the module. Then the module activator was loaded. But thats not very nice. thanks.

User floca has pushed new remote branch:

bug-18289-Replace-old-DICOMSeriesReader-2

User floca has pushed new remote branch:

bug-18289-integration-branch

Everything is ready to merge into master (see current integration branch).

But I need a core change flag, because the name of the old reader service (in the core) is changed from "MITK DICOM Reader" to "Classic MITK DICOM Reader".

Thanks.

[0a9ed0]: Merge branch 'bug-18289-integration-branch'

Merged commits:

2016-01-28 09:43:54 Ralf Floca [898eee]
Merge branch 'bug-18289-Replace-old-DICOMSeriesReader-2' into bug-18289-integration-branch


2015-11-12 15:44:46 Ralf Floca [596baa]
fixed linux gcc error

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-11-11 16:12:02 Ralf Floca [6bbb6d]
added ClassicDICOMSeriesReader as explicit service

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-11-10 23:25:06 Ralf Floca [e17151]
fixed type

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-11-10 23:24:53 Ralf Floca [4a0ed2]
activated auto load

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-11-06 00:55:40 Ralf Floca [12386c]

  • first draft for DICOMReader module integration as IO service

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>