Page MenuHomePhabricator

AcquisitionTime is ignored when loading DICOM 3D+t data
Closed, ResolvedPublic

Description

Currently the time geometry does not reflect the acquisition time of loaded DICOM 3D+t data sets. Instead the time points are always (wrongly) x ms (x equals the time step index; 0, 1, ..., n).

When loading 3D+t data the acquisition time / date should be regarded to construct a TimeGeometry that reflects this timing information.

Event Timeline

User floca has pushed new remote branch:

bug-17819-acquisitiontime-is-ignored-when-loading-dicom-3DplusT-data

Ralf, what's the status? :) Remember that you initially opened a pull request on GitHub. Tell me when the work is done so I can close the pull request.

Hi Stefan,

the bug is fixed and a pushed it myself to mitk.git (see comment #2). Last things that are missing are:

  • Review and OK (because it touches the core)
  • Merging into the master

reopend again to fix a small gcc compilation error

User floca has pushed new remote branch:

bug-17819-acquisitiontime-is-ignored-when-loading-DICOM-3DplusT-data

Hot to proceed any further. Can somebody review it and tell me if I can merge it? Thanks.

There is a small fix needed for gcc.
changed back the status to push the fix

oops, sorry mixed it up fix was already pushed. reverted state

Hi Ralf, I will have a look at this.
I the meantime can you please change the ArbitraryTimeGeometryTest to use cpp unit?

User floca has pushed new remote branch:

bug-17819-integration_branch

[704759]: Merge branch 'bug-17819-integration_branch'

Merged commits:

2015-12-17 21:04:09 Ralf Floca [ac01d7]
activate boost per default

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-12-17 21:03:47 Ralf Floca [9e38d2]
changed mitk data to new test data revision

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-12-16 22:30:39 Ralf Floca [d430e9]
Merge branch 'master' into bug-17819-integration_branch


2015-12-11 23:49:36 Ralf Floca [21bdee]
added sanity check and fall back for cases where no sensible time bounds can be created (e.g. 3d+t-Heart test data; until a proper handling for that data is implemented)

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-12-11 10:16:47 Ralf Floca [9f1c49]
Merge branch 'bug-17819-acquisitiontime-is-ignored-when-loading-DICOM-3DplusT-data' into bug-17819-integration_branch


2015-11-10 15:31:13 Ralf Floca [71656f]
migrated test to cppunti

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-11-10 14:15:02 Ralf Floca [5ce3c0]
fixed code documentation

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-09-18 21:55:18 Ralf Floca [ff9449]

  • fixed gcc compile error

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-05-19 17:32:20 Ralf Floca [fb6d25]
Merge branch 'master' into bug-17819-acquisitiontime-is-ignored-when-loading-dicom-3d+t-data

Conflicts:
Modules/Core/src/DataManagement/mitkProportionalTimeGeometry.cpp
Modules/Core/test/files.cmake

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-03-18 09:58:28 Ralf Floca [e8e911]
migrated changes in series reader helper to new version

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2015-03-18 09:57:31 Ralf Floca [23c923]
Changed function for more const correctness.


2015-03-16 18:07:39 Ralf Floca [11e5fc]
added missing package dependencies


2015-03-16 18:07:16 Ralf Floca [6097e0]
migrate merged code to API changes of the new release


2015-03-13 18:33:36 Ralf Floca [05f7ba]
Merge remote-tracking branch 'github_floca/bug-17819-acquisitiontime-is-ignored-when-loading-DICOM-3D+t-data' into bug-17819-acquisitiontime-is-ignored-when-loading-dicom-3d+t-data

Conflicts:
Modules/Core/files.cmake
Modules/Core/include/mitkProportionalTimeGeometry.h
Modules/Core/include/mitkTimeGeometry.h
Modules/Core/src/DataManagement/mitkProportionalTimeGeometry.cpp
Modules/Core/test/files.cmake
Modules/DICOMReader/CMakeLists.txt

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2014-12-30 00:29:57 Ralf Floca [d51aab]

  • started to remove dependencies to the implementation detail "ProportionalTimeGeometry" where not necessary. Rest will be done in a new bug (after merging with new mitk release branch 2014.10)

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2014-12-30 00:26:07 Ralf Floca [552fcd]

  • removed POCO dependency from bug patch

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>


2014-06-12 10:21:08 Ralf Floca [80fd56]

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>