Page MenuHomePhabricator
Create Task
Maniphest T2191

Make mitk::LevelWindow consistent
Closed, ResolvedPublic
Actions

Description

I stumbled upon mitk::LevelWindow while working on scene serialization.

mitk::LevelWindow seems to mix concepts of level/window and min/max. At least these are mixed within the member variable naming.

  • Go through the code and decide on one concept.
  • Either store current and default values as level/window or as min/max pair. (I vote for level/window, since this is more generally known, I guess)
  • name the Get...() methods consistent
  • document the used concepts in the class documentation. A small diagram would help much.

Event Timeline

maleike added projects: MITK, Bugzilla.Jul 7 2009, 11:10 AM
engelm added a subscriber: engelm.Jul 8 2009, 2:18 PM

Let's try to clean up after the party has started.....

engelm added a comment.Jul 15 2009, 3:49 PM

Adapt the interface and rename members to equalize the LevelWindow names.

We did not changed anything inside the SetAuto-Method instead of renaming, because it seems to complex to change the concept. It won't become better...

wegner added a subscriber: wegner.Nov 10 2009, 3:46 PM

associated bug: when loading two images, the levelwindow slider changes the setting of the first image. To change levelwindow of the second image, one has to change via context menue. But when deleting the first image changes of the levelwindow doesn't take effect on the image, that is left in datatree. Should be changed to use at least the first image in datastorage. Otherwise it looks like it doesn't work...

• hartmanp added a subscriber: • hartmanp.Feb 3 2010, 2:54 PM

due to excessive problems with the wiki template thing, we added this textfile as a change request

ChangeREquest.txt443 BDownload

nolden added a subscriber: nolden.Feb 3 2010, 3:50 PM

Please copy text to wiki.

• hartmanp added a comment.Feb 3 2010, 4:01 PM

[SVN revision 21209]
FIX (#2191): Made LevelWindow consitent by removing unnecessary member variables

• hartmanp added a comment.Feb 10 2010, 2:17 PM

reverted recent changes due to failning unit test

• hartmanp added a comment.Feb 10 2010, 5:08 PM

made a preliminarsy fix of the huge mess in levelwindow.... had to adapt the test too.... many problems, no light at the end of the tunnel...

• hartmanp added a comment.Feb 10 2010, 5:09 PM

prelim changes

Levelwindowwww.patch12 KBDownload

• schmidts added a subscriber: • schmidts.Feb 17 2010, 4:38 PM

Commiting patch

Additionally we removed any reference to the obsolete default rangemin/max attributes in the whole source tree

• schmidts added a comment.Feb 17 2010, 4:41 PM

[SVN revision 21373]
FIX (#2191): consistent naming in levelwindow / removal of default range min/max

• wald added a subscriber: • wald.Mar 24 2010, 4:42 PM

This one is finished. we will close this bug.

MITK · MIC · IMSY · DKFZ