Page MenuHomePhabricator | MITK

Implement specific UID strategy for mitk::Image
Closed, WontfixPublic

Description

mitk::Image should use its own UID strategy and not the default own.
Reasoning: UID should be as close to dicom as possible.

Idea:

  • From now all mitk::Image should have an filled DICOM.0008.0018 (SOP Instance UID) property for all its z-position and timesteps. (If it does not exists through the loading process it will be generated (this will be done by T23746))
  • The content of DICOM.0008.0018 will be hashed to generate the ID
  • If, for any reason (evil!!), DICOM.0008.0018 does not exist, one would fall back to default uid generation

Event Timeline

floca created this task.Nov 17 2017, 11:03 AM
floca updated the task description. (Show Details)Nov 17 2017, 11:36 AM

After the final discussion round, this task is for me, a candidate for deletion. I see the problem, pointed out by @nolden, that we provoke an anti pattern if we stared to define UID strategies below BaseData. As far as I see it, after having T23766 and proper helper to configure data dicom conform (see T23748 and T23774) this not needed anymore. @metzger wants to evaluate it for her use cases. If she has no arguments against it, I would spite this task and sub task

kislinsk claimed this task.
kislinsk closed this task as Wontfix.