Page MenuHomePhabricator
Create Task
Maniphest T26903

DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType
Closed, ResolvedPublic
Actions

Description

As far as I can see, the changes in this commit rMITKa3157e41952094c309ae12b67fc8ea672a2abfc3 have broken the write features of DICOM seg.

Reason ist that the fix for bug T18572: The AppliesTo function of MimeTypes is called when writing does not work any more. The introduced code now tries to make file operations and read from a file which cannot work in write operations as the file does not exist.

@nolden How did you managed to write segmentation. Currently it should not be possible with the normal IO functionality? Or did you used an older version?
@neher Why do you have introduced these lines what do you try to achive? We have to finde a better solution.
@gaoh Thats the cause of your problems in {T26820} I will patch it away in that branch for you to work on. But we have to clarify that before merging T26820 into master,

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKd211c3a7fab6 Fixed T26903 in order to allow storing of DICOM seg again.
Restricted Differential RevisionrMITK07dd0a9ed38e Fixed T26903 in order to allow storing of DICOM seg again.

Related Objects

Event Timeline

floca triaged this task as Unbreak Now! priority.Dec 6 2019, 6:07 PM
floca created this task.
floca mentioned this in rMITK060c74e0e136: Patched problem due to T26903 in order to allow storing of DICOM seg again..Dec 6 2019, 6:17 PM
floca added a comment.Dec 6 2019, 6:18 PM

rMITK060c74e0e13601d6ccd7653122ce65e2e7fae181 is a proposed fix for the problem.
@neher Do you see any problems?

floca updated the task description. (Show Details)Dec 20 2019, 9:18 PM
neher added a comment.Jan 7 2020, 8:50 AM

Looks good. Don't see a problem.

kislinsk edited projects, added MITK (2018-04-4); removed MITK.Jan 9 2020, 2:52 PM
floca added a revision: Restricted Differential Revision.Feb 10 2020, 10:22 PM
floca claimed this task.Feb 10 2020, 10:22 PM
floca added a comment.Feb 10 2020, 10:26 PM

Pushed new branch T26903-DICOM_Seg_writing_broken_due_to_DICOMSEGIOMimeType.

floca closed this task as Resolved by committing rMITK07dd0a9ed38e: Fixed T26903 in order to allow storing of DICOM seg again..Feb 10 2020, 10:26 PM
floca added a commit: rMITK07dd0a9ed38e: Fixed T26903 in order to allow storing of DICOM seg again..
floca reopened this task as Open.Feb 10 2020, 10:28 PM

Wrong "auto close". Must be landed first.

floca removed a project: Request for Discussion.Feb 10 2020, 10:29 PM
kislinsk edited projects, added MITK; removed MITK (2018-04-4).Feb 11 2020, 4:42 PM
floca closed this task as Resolved by committing rMITKd211c3a7fab6: Fixed T26903 in order to allow storing of DICOM seg again..Feb 11 2020, 5:30 PM
floca added a commit: rMITKd211c3a7fab6: Fixed T26903 in order to allow storing of DICOM seg again..
floca mentioned this in rMITK23b07c9a6b5f: First draft of the flow bench.Mar 2 2020, 10:59 AM
MITK · MIC · IMSY · DKFZ