Page MenuHomePhabricator

gaoh (Hanno Gao)
User

Projects

User Details

User Since
Sep 3 2018, 11:01 AM (136 w, 19 h)

Recent Activity

Thu, Apr 8

gaoh added a member for Kaapana (internal): r738v.
Thu, Apr 8, 12:24 PM
gaoh added a member for MIC: r738v.
Thu, Apr 8, 12:23 PM

Tue, Apr 6

gaoh committed rKAAPANAb5003f1da588: removed bug: enable GPU if true, not false (authored by gaoh).
removed bug: enable GPU if true, not false
Tue, Apr 6, 12:55 PM

Mon, Mar 29

gaoh committed rKAAPANAcede5976d2eb: Merge branch 'feature/T28344-delete-series-from-platform' into develop (authored by gaoh).
Merge branch 'feature/T28344-delete-series-from-platform' into develop
Mon, Mar 29, 1:05 PM

Wed, Mar 24

gaoh committed rKAAPANAd2da41e97b2e: clean up CTP Docker: remove unneeded Launcher property and added file… (authored by gaoh).
clean up CTP Docker: remove unneeded Launcher property and added file…
Wed, Mar 24, 9:23 AM

Mon, Mar 22

gaoh committed rKAAPANAabe8a3b2dd8b: restructur delete: Gui allow to select entire study. (authored by gaoh).
restructur delete: Gui allow to select entire study.
Mon, Mar 22, 4:01 PM
gaoh placed T27968: CTP gets stuck on large import up for grabs.

after tests of the system, the problem might be at the airflow part, this has to be tested

Mon, Mar 22, 2:53 PM · Kaapana (internal)

Tue, Mar 16

gaoh updated the task description for T28380: [MultLabel Segmentation, MITK FlowBench] Segmentation not recognized as segmentation in Release v2021.02.
Tue, Mar 16, 10:52 AM · MITK
gaoh created T28380: [MultLabel Segmentation, MITK FlowBench] Segmentation not recognized as segmentation in Release v2021.02.
Tue, Mar 16, 10:51 AM · MITK

Mon, Mar 15

gaoh committed rKAAPANAd5a6fb17ad66: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Mon, Mar 15, 11:49 AM
gaoh committed rKAAPANA278ab17bf094: bring LocalCtpQuarantineCheckOperator back with additional options: (authored by gaoh).
bring LocalCtpQuarantineCheckOperator back with additional options:
Mon, Mar 15, 11:49 AM
gaoh committed rKAAPANA8996b59c2785: removed bug in mitk-flow naming version (authored by gaoh).
removed bug in mitk-flow naming version
Mon, Mar 15, 11:49 AM
gaoh added a comment to T28374: Workbench crashes after DICOM retrieval .

T28207 describes how to test it without the wDB. When searching for DICOM query retrieve there are already different tasks open with all similar problems

Mon, Mar 15, 9:39 AM · Next Milestone, DICOM, MITK

Mar 11 2021

gaoh committed rKAAPANA02ce8ab01d67: removed naming issue in container version (authored by gaoh).
removed naming issue in container version
Mar 11 2021, 3:04 PM

Mar 10 2021

gaoh committed rKAAPANA63059049e3ea: changes in CTP (authored by gaoh).
changes in CTP
Mar 10 2021, 5:49 PM

Mar 4 2021

gaoh moved T27968: CTP gets stuck on large import from Discussion to In Progress on the Kaapana (internal) board.
Mar 4 2021, 9:35 AM · Kaapana (internal)
gaoh added a member for Kaapana (internal): d587s.
Mar 4 2021, 9:11 AM

Mar 1 2021

gaoh committed rKAAPANAe9a52401d4c3: T27968 added -XX:+ExitOnOutOfMemoryError -XX:+CrashOnOutOfMemoryError results… (authored by gaoh).
T27968 added -XX:+ExitOnOutOfMemoryError -XX:+CrashOnOutOfMemoryError results…
Mar 1 2021, 11:42 AM
gaoh committed rKAAPANAbfeeabbf1d0a: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Mar 1 2021, 11:42 AM
gaoh committed rKAAPANA4a10c21da12f: T28286 check if data exist for each step, before rejecting/deleting (authored by gaoh).
T28286 check if data exist for each step, before rejecting/deleting
Mar 1 2021, 11:19 AM

Feb 24 2021

gaoh added a comment to T27968: CTP gets stuck on large import.

I cannot reproduce the error. When sending the data to an instance the data gets imported. When debugging CTP locally there also seems to be no problem. For me also it looks like the problem is not directly in the CTP but in the java library (dcm4che). Did the files got triggered/send to airflow? Did they get stuck in a quarantine folder of the CTP, and if so in which?

Feb 24 2021, 2:09 PM · Kaapana (internal)
gaoh added a comment to T27968: CTP gets stuck on large import.

This is one of my model DICOMs (not 100% sure if this will reproduce it).
If not I can try to make bigger parts.

Download-link from my instance

Just a remark: The download link does not work for me. I get forbidden access. This is also the case, even if I am logged into the platform. But since there is only one folder in minio I also found it without the link:)

Feb 24 2021, 12:26 PM · Kaapana (internal)
gaoh added a comment to T27968: CTP gets stuck on large import.

Can you send me a dataset to reproduce it? I could try to debug CTP, but it looks like it is not even a problem in CTP but in org.dcm4chri

Feb 24 2021, 9:47 AM · Kaapana (internal)

Feb 23 2021

gaoh committed rKAAPANA0ef5ef04f2f7: T28286 EntityNotFoundException occurs sometimes, when using 113001%5EDCM? to… (authored by gaoh).
T28286 EntityNotFoundException occurs sometimes, when using 113001%5EDCM? to…
Feb 23 2021, 5:31 PM
gaoh placed T28207: MITK DicomBrowser q/r Retrieve part crash up for grabs.
Feb 23 2021, 2:33 PM · MITK (v2021.10)
gaoh added a comment to T28207: MITK DicomBrowser q/r Retrieve part crash.

Get an Openstack instance (e.g. Ubuntu 20.04 DKFZ image,...)

Feb 23 2021, 11:16 AM · MITK (v2021.10)

Feb 22 2021

gaoh added a comment to T27968: CTP gets stuck on large import.

Can you reproduce the error? If so, we can do something like: https://stackoverflow.com/questions/12096403/java-shutting-down-on-out-of-memory-error

Feb 22 2021, 12:27 PM · Kaapana (internal)

Feb 19 2021

gaoh closed Restricted Maniphest Task, a subtask of T28302: MITK CI jobs for Kaapana, as Resolved.
Feb 19 2021, 11:53 AM · CI, MITK
gaoh committed rKAAPANAcf5fd7647738: change MITK-flow and MITK-workbench (old name was volume) to use directly the… (authored by gaoh).
change MITK-flow and MITK-workbench (old name was volume) to use directly the…
Feb 19 2021, 11:48 AM

Feb 18 2021

gaoh added a comment to T28302: MITK CI jobs for Kaapana.

@gaoh

I noticed that the only plugins enabled in the "MitkVolume" configuration are the segmentation plugins. Do you explicitly want to have this "slim" version or is the official WorkbenchRelease configuration more sufficient?

Feb 18 2021, 12:58 PM · CI, MITK

Feb 17 2021

gaoh committed rKAAPANA81bf872b276c: Update of mitk: rename mitk_voluem to mitk_workbench. Change version of… (authored by gaoh).
Update of mitk: rename mitk_voluem to mitk_workbench. Change version of…
Feb 17 2021, 6:20 PM
gaoh committed rKAAPANA902d0b8a6823: T28306 Upper case laters could result in errors (authored by gaoh).
T28306 Upper case laters could result in errors
Feb 17 2021, 1:14 PM
gaoh added a comment to T28302: MITK CI jobs for Kaapana.

And MITK volume (aka the normal workbench) uses the Release build with segmentation=ON

Maybe we should then just label it MITK Workbenches to avoid confusion and reduce (redundant) artefacts.

Feb 17 2021, 11:01 AM · CI, MITK
gaoh added a comment to T28311: MitkFlowBench Naming Issue.

In case of kaapana, the name is currently irrelevant: directly in the next operator, the dcm files are send to the PACs anyway and then the file is deleted.
What would make sense, regading the naming in the PACs and when downloading files, would be to give it the name of the Instance UID.

Feb 17 2021, 9:13 AM · MITK

Feb 16 2021

gaoh added a comment to T28311: MitkFlowBench Naming Issue.

so maybe a Regex is needed, or just a default file name..

Feb 16 2021, 11:00 AM · MITK
gaoh created T28311: MitkFlowBench Naming Issue.
Feb 16 2021, 10:58 AM · MITK
gaoh committed rKAAPANAf52b8ae3adb9: update dags for mitk_volume to the curren dev version (authored by gaoh).
update dags for mitk_volume to the curren dev version
Feb 16 2021, 10:07 AM
gaoh committed rKAAPANA6148c98651e1: adapted KaapanaApplication and the mitk_flow dag to the current dev version (authored by gaoh).
adapted KaapanaApplication and the mitk_flow dag to the current dev version
Feb 16 2021, 9:21 AM

Feb 12 2021

gaoh added a comment to T28302: MITK CI jobs for Kaapana.

Ah so the idea is not to build it, but to directly use a CI binary.
So MITK flow uses:

# Generate Ninja build script for MITK to build a minimum configuration with apps in Release mode into MITK-superbuild directory
RUN cmake -G Ninja -S MITK -B MITK-superbuild
RUN cmake -S MITK -B MITK-superbuild -D CMAKE_BUILD_TYPE:STRING=Release -D BUILD_TESTING:BOOL=OFF -D MITK_BUILD_CONFIGURATION:STRING=FlowBenchSegmentationRelease -D MITK_CUSTOM_REVISION_DESC:STRING=MitkFlow
RUN cmake --build MITK-superbuild
RUN cmake --build MITK-superbuild/MITK-build --target package 
RUN mkdir /opt/final_package
RUN cp /opt/MITK-superbuild/MITK-build/MITK-MitkFlow-linux-x86_64.tar.gz /opt/final_package/MITK-MitkFlow-linux-x86_64.tar.gz

And MITK volume (aka the normal workbench) uses the Release build with segmentation=ON

Feb 12 2021, 10:01 AM · CI, MITK
gaoh added a comment to T28302: MITK CI jobs for Kaapana.

For MITK-flow and MITK-volume I will switch to the new release (release/T28000-v2021.02). It was only on a develop branch, because there were some bug fixes, not yet in a master branch.
But now with the new release...

Feb 12 2021, 9:36 AM · CI, MITK

Feb 5 2021

gaoh committed rKAAPANAddace5d238af: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Feb 5 2021, 11:53 AM
gaoh committed rKAAPANAaea245a7358c: Merge branch 'feature/T28096-Update-MITK-solutions-in-Kaapana' into develop (authored by gaoh).
Merge branch 'feature/T28096-Update-MITK-solutions-in-Kaapana' into develop
Feb 5 2021, 11:53 AM

Feb 1 2021

gaoh added a member for MIC: k688h.
Feb 1 2021, 11:37 AM
gaoh added a member for Kaapana (internal): k688h.
Feb 1 2021, 11:36 AM
gaoh added a comment to T28239: Multilabel Segmentation - 3D Segmentation Confused about required outcome.

To be honest, I just did not understand the checklist correctly. If you know the outcome and read the checklists, they are fine. But for me, it was like a new test starting with loading and testing 3D Data again. So I misunderstood the line Bei den folgenden Aktionen stets mehrere Label, auch auf unterschiedlichen Layern testen. as beeing a new test, because it had of kind of title character. And that is why I thought, I would start with a 3d Image again...

Feb 1 2021, 8:40 AM · MITK-ProjectTemplate, MITK (v2021.02)

Jan 29 2021

gaoh added a comment to T28240: [MultiLabel Segmentierung] – Optionen.

The other options "Show as volume rendering" and "Enable auto-selection mode" are not working as described. Or I didn't get the description..

Jan 29 2021, 1:10 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh updated the task description for T28239: Multilabel Segmentation - 3D Segmentation Confused about required outcome.
Jan 29 2021, 1:07 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh added a comment to T28240: [MultiLabel Segmentierung] – Optionen.

Ah it seems I was mistaking, at least the transparent overlay works, the color mismatch remains.

Jan 29 2021, 12:50 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh added a comment to T28240: [MultiLabel Segmentierung] – Optionen.

Ah, when changing the Preference of Segmenation, the mask is changed... How can I create a "Multilabel Mask"?

Jan 29 2021, 12:46 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh triaged T28240: [MultiLabel Segmentierung] – Optionen as Normal priority.
Jan 29 2021, 12:42 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh closed T28239: Multilabel Segmentation - 3D Segmentation Confused about required outcome, a subtask of T28000: MITK v2021.02, as Resolved.
Jan 29 2021, 12:25 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh closed T28239: Multilabel Segmentation - 3D Segmentation Confused about required outcome as Resolved.

Yes, it is exactly as you described: static -> all timesteps, dynamic -> toolbox to apply to all timesteps or not.

Jan 29 2021, 12:25 PM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh triaged T28239: Multilabel Segmentation - 3D Segmentation Confused about required outcome as Normal priority.
Jan 29 2021, 10:58 AM · MITK-ProjectTemplate, MITK (v2021.02)

Jan 28 2021

gaoh moved T28196: [Docs] Update Dev-Guide for 0.1.1-dev from In Progress to Discussion on the Kaapana (internal) board.
Jan 28 2021, 9:31 AM · Kaapana (internal)

Jan 27 2021

gaoh triaged T28211: [Image Rendering] Color change/ Opacity strange behaviour (only in Windows installers) as Normal priority.
Jan 27 2021, 12:34 PM · MITK (v2021.02)
gaoh added a subtask for T28000: MITK v2021.02: T28127: Reopen segmentation in MITK.
Jan 27 2021, 11:11 AM · MITK-ProjectTemplate, MITK (v2021.02)
gaoh added a parent task for T28127: Reopen segmentation in MITK: T28000: MITK v2021.02.
Jan 27 2021, 11:11 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
gaoh claimed T28207: MITK DicomBrowser q/r Retrieve part crash.
Jan 27 2021, 10:58 AM · MITK (v2021.10)
gaoh renamed T28207: MITK DicomBrowser q/r Retrieve part crash from MITK DicomBrowser Query Retrieve to MITK DicomBrowser q/r Retrieve part crash.
Jan 27 2021, 10:55 AM · MITK (v2021.10)
gaoh triaged T28207: MITK DicomBrowser q/r Retrieve part crash as Normal priority.
Jan 27 2021, 10:55 AM · MITK (v2021.10)

Jan 20 2021

gaoh reopened T28127: Reopen segmentation in MITK as "Open".

@floca I might have found a dataset, where even the new number is not enough:
edit:
E130-Personal:\Gao\mitk-testdata\

Jan 20 2021, 9:44 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)
gaoh moved T28127: Reopen segmentation in MITK from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 20 2021, 10:32 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Jan 15 2021

gaoh added a comment to T28159: Officially support MITK using system Qt.

yes exactly, the problem with the scripted version, ist still, that it is necessary to provide credentials. That was fine, as long we were the only ones creating the containers.
The version of @nolden downloading the packages in ubuntu allows others to just build the container, without having to provide credentials at all.

Jan 15 2021, 12:35 PM · CI, Kaapana (internal), Request for Discussion, MITK

Jan 14 2021

gaoh added a member for Kaapana (internal): e249r.
Jan 14 2021, 9:39 AM

Jan 13 2021

gaoh added a comment to T28127: Reopen segmentation in MITK.

Oh I forgot to mention: the segmentation is saved as dicom-seg.

Jan 13 2021, 10:09 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
gaoh raised the priority of T28127: Reopen segmentation in MITK from High to Unbreak Now!.
Jan 13 2021, 10:06 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Jan 7 2021

gaoh committed rKAAPANAa17c190080be: CTP has additonal options: (authored by gaoh).
CTP has additonal options:
Jan 7 2021, 11:11 AM

Dec 21 2020

gaoh triaged T28127: Reopen segmentation in MITK as High priority.
Dec 21 2020, 9:57 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Dec 17 2020

gaoh committed rKAAPANA7f87a107aac8: added change of Kaapana Operators to the extention dir: (authored by gaoh).
added change of Kaapana Operators to the extention dir:
Dec 17 2020, 11:48 AM

Dec 16 2020

gaoh committed rKAAPANA491bdaa1f831: removed wrong files (authored by gaoh).
removed wrong files
Dec 16 2020, 1:45 PM
gaoh committed rKAAPANA731c8a79f8b8: corrected naming issues. (authored by gaoh).
corrected naming issues.
Dec 16 2020, 12:50 PM

Dec 15 2020

gaoh committed rKAAPANA2a5c06d333a8: renaming and adding missing files (authored by gaoh).
renaming and adding missing files
Dec 15 2020, 3:29 PM
gaoh committed rKAAPANA1cee38d6aed2: - Update MITK-volume (to current dev) (authored by gaoh).
- Update MITK-volume (to current dev)
Dec 15 2020, 10:42 AM

Dec 10 2020

gaoh removed a project from T27968: CTP gets stuck on large import: Request for Discussion.
Dec 10 2020, 10:37 AM · Kaapana (internal)
gaoh moved T27968: CTP gets stuck on large import from Discussion to Backlog on the Kaapana (internal) board.

We need a dataset to reporduce the problem, to setup a testsetup.

Dec 10 2020, 10:37 AM · Kaapana (internal)

Dec 1 2020

gaoh removed a project from T24398: Dicom plugin: Retrieve does not work: Missing Info.
Dec 1 2020, 11:03 AM · MITK (v2021.10)
gaoh added a comment to T24398: Dicom plugin: Retrieve does not work.

So I tested it with Orthanc (without CGET only):
With 2018.04.2 retrieve works. With the current develop branch MITK crashes with the same exception:

Dec 1 2020, 11:02 AM · MITK (v2021.10)
gaoh renamed T24398: Dicom plugin: Retrieve does not work from Dicom plugin: wdb Retrieve does not work to Dicom plugin: Retrieve does not work.
Dec 1 2020, 10:59 AM · MITK (v2021.10)

Nov 30 2020

gaoh added a comment to T27968: CTP gets stuck on large import.

Have you checked, if the dataset (or the slices) are already in the PACs. In my case (I got the error, when sending data from airflow to the PACs), the files creating the 409 were already in DCM4CHE.

Nov 30 2020, 11:33 AM · Kaapana (internal)
gaoh added a comment to T24398: Dicom plugin: Retrieve does not work.

Oh sorry, I thought it was clear, because the title is wDB related:
I used the wDB. I did not test it with a different PACs system, but I can try and report back...

Nov 30 2020, 9:17 AM · MITK (v2021.10)

Nov 26 2020

gaoh added a comment to T27968: CTP gets stuck on large import.

In T27573 we discussed the problem of data transfer from CTP to DCM4CHE.
So basically it is a kind of similar problem: A datatransfer between CTP and DCM4CHE fails.
The problem is then, CTP just keeps the data in the queue (here) or inserts in the quarantine folder (T27573).
Anyway, we do not get notified, that there is a problem.

Nov 26 2020, 12:09 PM · Kaapana (internal)

Nov 25 2020

gaoh placed T24398: Dicom plugin: Retrieve does not work up for grabs.

So for the current develop:
With or without CGET activated. When trying to Retrieve a dataset after Query, I get an Exception:

Nov 25 2020, 3:36 PM · MITK (v2021.10)
gaoh closed Restricted Maniphest Task, a subtask of T27196: Rewrite packaging of MITK, as Invalid.
Nov 25 2020, 10:57 AM · MITK (v2021.10), Cleared

Nov 24 2020

gaoh claimed T24398: Dicom plugin: Retrieve does not work.
Nov 24 2020, 5:21 PM · MITK (v2021.10)

Nov 17 2020

gaoh added a comment to T27968: CTP gets stuck on large import.

The CTP thread responsible for sending the data to the PACs crashed:

Nov 17 2020, 3:57 PM · Kaapana (internal)

Oct 9 2020

gaoh committed rKAAPANA98d91ae5f20c: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Oct 9 2020, 1:53 PM
gaoh committed rKAAPANA608d128d34c5: wrong file name fixed (authored by gaoh).
wrong file name fixed
Oct 9 2020, 1:53 PM
gaoh committed rKAAPANA1bacda9ea1c7: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Oct 9 2020, 1:01 PM
gaoh committed rKAAPANA579379ffff0f: set correct owner in mitk-flow (authored by gaoh).
set correct owner in mitk-flow
Oct 9 2020, 1:01 PM
gaoh committed rKAAPANA65f7b65348f9: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Oct 9 2020, 12:25 PM
gaoh committed rKAAPANA839e15db3a68: Updated workflow T27735. (authored by gaoh).
Updated workflow T27735.
Oct 9 2020, 12:25 PM

Oct 6 2020

gaoh committed rKAAPANA725936e62977: updated flow mitk to run with kaapana dependencies (authored by gaoh).
updated flow mitk to run with kaapana dependencies
Oct 6 2020, 3:12 PM

Oct 1 2020

gaoh committed rKAAPANAb9ad1c948a5e: small simple scripts to send files to the platform (authored by gaoh).
small simple scripts to send files to the platform
Oct 1 2020, 2:10 PM

Sep 29 2020

gaoh committed rKAAPANA15468499f7db: Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into… (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/kaapana into…
Sep 29 2020, 3:13 PM
gaoh committed rKAAPANAca2e361fa85f: changed LocalGetInputDataOperator: a conf with no "inputs" results in skipping… (authored by gaoh).
changed LocalGetInputDataOperator: a conf with no "inputs" results in skipping…
Sep 29 2020, 3:13 PM

Sep 14 2020

gaoh added a member for SIDT: m139l.
Sep 14 2020, 4:40 PM
gaoh closed T27110: [MITKDoc] Revise Command Line Tool/ Automatisation Plugin Documentation as Resolved.
Sep 14 2020, 3:32 PM · Cleared, MITK (v2021.02)
gaoh committed rMITKc4b6bb115cd1: T27110 Revice Command Line Tool. (authored by gaoh).
T27110 Revice Command Line Tool.
Sep 14 2020, 3:28 PM
gaoh committed rMITK032e29703e98: T27110 Revice Command Line Tool: (authored by gaoh).
T27110 Revice Command Line Tool:
Sep 14 2020, 3:28 PM
gaoh committed rMITK0fdef86d49b2: update plugin name cmdlinemodules (authored by gaoh).
update plugin name cmdlinemodules
Sep 14 2020, 3:28 PM