Refactor ModelFit and Pharmacokinetics plugins to use new selection concept
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	floca
	Jan 29 2020, 9:13 PM

Description

Refactor to use the QmitkSingleNodeSelectionWidget.

In addition: Check all predicates that the are as narrow as possible. e.g. the t1map is only supported in 3D, but the predicate also allows other dimensions.

Revisions and Commits

rMITK MITK
	Restricted Differential Revision	rMITK24158ffb55c1 Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox.
	Restricted Differential Revision	rMITKe8c6a0a2ad5a Case sensitive spelling of QmitkSingelNodeSelectionWidget.
	Restricted Differential Revision	rMITK4c2473dc50f8 Remove unrequired include file.
	Restricted Differential Revision	rMITK8d63af91b336 Update GUI controls, when AIF mask and image selection has changed.
	Restricted Differential Revision	rMITK1b93ec66c172 Enable auto select for AIF mask.
	Restricted Differential Revision	rMITK1b6ec1748f4f Rename OnSelectionChanged to OnNodeSelectionChanged.
	Restricted Differential Revision	rMITK28cfe9a3e4fd Replace AIF mask and image combo boxes with single node selection widgets.
	Restricted Differential Revision	rMITK850fbac79fb5 Change size policies.
	Restricted Differential Revision	rMITKafa09efbeea1 Refactor AIF mask and AIF image selection using new selection concept.
	Restricted Differential Revision	rMITKf8f8c8e47519 Change mask selection to be optional.
	Restricted Differential Revision	rMITK1e641f1b87ae Activate auto select for time series selection.
	Restricted Differential Revision	rMITK73f49980871d Merge branch 'feature/T27043-RefactorModelFitAndPharmacokineticsPluginToUseNewS…
	Restricted Differential Revision	rMITKcaf612b04010 Replace DataStorageComboBoxes with SingleNodeSelectionWidgets for timeseries…
	Restricted Differential Revision	rMITKeab41537a7bf Narrow predicates for time series, mask and PDW image selection.
	Restricted Differential Revision	rMITK234bec8db139 Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox.

Related Objects
Search...

Status	Assigned	Task
		Restricted Maniphest Task
Resolved	None	T26741 Finishing new node selection concept
Resolved	floca	T23721 Project "Astonishing Angelfish"
Resolved	kalali	T23751 Introduction of new selection concept
Resolved	kalali	T24775 Refactor plugins to use the new node selection widgets
Resolved	kompan	T27043 Refactor ModelFit and Pharmacokinetics plugins to use new selection concept

Event Timeline

floca triaged this task as Normal priority.Jan 29 2020, 9:13 PM

floca created this task.

floca mentioned this in T27006: [Perfusion] - Problems selecting T1 map.Jan 29 2020, 9:21 PM

This becomes important also for release as the selection seems to be broke currently in the fitting views!

floca moved this task from Backlog to Perfusion on the MITK (v2021.02) board.May 5 2020, 10:56 AM

floca added a project: Cleared.May 8 2020, 10:47 AM

kompan claimed this task.Jun 9 2020, 9:09 AM

@kompan I have some fixes for the model fit inspector view already in my stash that where done while working on other stuff. So if you do the task, best focus on the generation plugins. Thanks.

@floca OK, then I will work on the Pharmacokinetics Plugins.

kompan added a revision: Restricted Differential Revision.Jul 14 2020, 11:11 AM

@floca There is still an issue in the UI: When using the mitkSingleNodeSelectionWidget for the mask selection instead of the QmiktDataStorageComboBox, the mask selection field in the UI becomes larger than the time series selection field (see D348). It only gets reduced in size when further options, i.e. a model are selected. At least on first attempt, I couldn't get both to have the same size. Maybe you have an idea how to fix this and make it look pretty again?

In T27043#206242, @kompan wrote:

@floca There is still an issue in the UI: When using the mitkSingleNodeSelectionWidget for the mask selection instead of the QmiktDataStorageComboBox, the mask selection field in the UI becomes larger than the time series selection field (see D348). It only gets reduced in size when further options, i.e. a model are selected. At least on first attempt, I couldn't get both to have the same size. Maybe you have an idea how to fix this and make it look pretty again?

I have added comments to the review. Please be aware that the official review can only start if all CI clients are green. Currently Linux and MacOS are red.

kompan closed this task as Resolved by committing rMITK24158ffb55c1: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox..Jul 29 2020, 10:36 AM

kompan added a commit: rMITK234bec8db139: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox..

kompan added a commit: rMITKeab41537a7bf: Narrow predicates for time series, mask and PDW image selection..

kompan added a commit: rMITKcaf612b04010: Replace DataStorageComboBoxes with SingleNodeSelectionWidgets for timeseries….

kompan added a commit: rMITK73f49980871d: Merge branch 'feature/T27043-RefactorModelFitAndPharmacokineticsPluginToUseNewS….

kompan added a commit: rMITK1e641f1b87ae: Activate auto select for time series selection..

kompan added a commit: rMITKf8f8c8e47519: Change mask selection to be optional..

kompan added a commit: rMITKafa09efbeea1: Refactor AIF mask and AIF image selection using new selection concept..

kompan added a commit: rMITK850fbac79fb5: Change size policies..

kompan added a commit: rMITK28cfe9a3e4fd: Replace AIF mask and image combo boxes with single node selection widgets..

kompan added a commit: rMITK1b6ec1748f4f: Rename OnSelectionChanged to OnNodeSelectionChanged..

kompan added a commit: rMITK1b93ec66c172: Enable auto select for AIF mask..