Page MenuHomePhabricator

Refactor ModelFit and Pharmacokinetics plugins to use new selection concept
Closed, ResolvedPublic

Description

Refactor to use the QmitkSingleNodeSelectionWidget.

In addition: Check all predicates that the are as narrow as possible. e.g. the t1map is only supported in 3D, but the predicate also allows other dimensions.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

floca triaged this task as Normal priority.Jan 29 2020, 9:13 PM
floca created this task.
floca raised the priority of this task from Normal to High.Apr 22 2020, 9:55 PM
floca edited projects, added MITK (2020); removed MITK.

This becomes important also for release as the selection seems to be broke currently in the fitting views!

floca moved this task from Backlog to Perfusion on the MITK (2020) board.May 5 2020, 10:56 AM
kompan claimed this task.Jun 9 2020, 9:09 AM
floca added a comment.Jun 9 2020, 9:54 AM

@kompan I have some fixes for the model fit inspector view already in my stash that where done while working on other stuff. So if you do the task, best focus on the generation plugins. Thanks.

@floca OK, then I will work on the Pharmacokinetics Plugins.

kompan added a revision: Restricted Differential Revision.Jul 14 2020, 11:11 AM

@floca There is still an issue in the UI: When using the mitkSingleNodeSelectionWidget for the mask selection instead of the QmiktDataStorageComboBox, the mask selection field in the UI becomes larger than the time series selection field (see D348). It only gets reduced in size when further options, i.e. a model are selected. At least on first attempt, I couldn't get both to have the same size. Maybe you have an idea how to fix this and make it look pretty again?

floca added a comment.Jul 14 2020, 8:46 PM

@floca There is still an issue in the UI: When using the mitkSingleNodeSelectionWidget for the mask selection instead of the QmiktDataStorageComboBox, the mask selection field in the UI becomes larger than the time series selection field (see D348). It only gets reduced in size when further options, i.e. a model are selected. At least on first attempt, I couldn't get both to have the same size. Maybe you have an idea how to fix this and make it look pretty again?

I have added comments to the review. Please be aware that the official review can only start if all CI clients are green. Currently Linux and MacOS are red.