Page MenuHomePhabricator
Create Task
Maniphest T28223

[ImageStatistics] Deleting a datanode after statistics leads to no histogram update for the next node
Closed, ResolvedPublic
Actions

Description

Reproduce:

  1. Load any datanode (US4DCyl)
  2. Select in statistics
  3. Delete it
  4. Load another node (Pic3D)
  5. Select in statistics

-> Histogram still shows the deleted node but not the new one, update can be triggered by checking "Show subchart"

Also interesting: If you have a ROI selected for the second node than "Show subchart" will show you the histograms: US4DCyl[0], US4DCyl[0] with Circle1, Pic3D with Circle1 (although you never asked for the US4DCyl and the node does not exist in the storage anymore)

Revisions and Commits

Restricted Differential Revision
rMITK MITK
rMITKe13e328138dd Fixed T28222 Show histogram according to selected time point

Related Objects

Event Timeline

• thomass triaged this task as High priority.Jan 27 2021, 3:00 PM
• thomass created this task.
• thomass updated the task description. (Show Details)
• thomass added a parent task: T28000: MITK v2021.02.Jan 27 2021, 3:06 PM
• thomass added a comment.Jan 27 2021, 3:14 PM

probably related to T28206

kislinsk mentioned this in T28206: [Image Statistics] Renaming segmentation or planar figure based ROI nodes breaks histogram.Jan 27 2021, 3:16 PM
kalali moved this task from Backlog to MaaS on the MITK (v2021.02) board.Jan 27 2021, 5:57 PM
floca claimed this task.Jan 28 2021, 8:41 PM
floca mentioned this in T28222: [ImageStatistics] Histogram is only shown for timestep 0.Jan 28 2021, 9:59 PM
floca mentioned this in T28237: Refactor QmitkChart.Jan 28 2021, 10:14 PM
floca added a revision: Restricted Differential Revision.Jan 30 2021, 4:18 PM
floca removed floca as the assignee of this task.Jan 31 2021, 11:52 AM
floca lowered the priority of this task from High to Normal.
floca edited projects, added MITK, Next Milestone; removed MITK (v2021.02).
floca added a subscriber: floca.

For v2021.01 the problem is irrelevant now (legend is deactivated). But as soon as we want to support multiple statistics in the histogram widget and the widget has been reworked. This should also be covered.

Reason for the missing update, is that neither the statistics view nor the histgram widget are listening tu changes of the selected image or ROI nodes. Therefore they are not aware if the name property changes.
The DataStorageModel of the statistic widget does. This is why there everything is updated correctly.

floca removed a parent task: T28000: MITK v2021.02.Jan 31 2021, 11:53 AM
kislinsk closed this task as Resolved by committing rMITKe13e328138dd: Fixed T28222 Show histogram according to selected time point.Feb 10 2021, 5:50 PM
kislinsk claimed this task.
kislinsk added a commit: rMITKe13e328138dd: Fixed T28222 Show histogram according to selected time point.
MITK · MIC · IMSY · DKFZ