Page MenuHomePhabricator
Create Task
Maniphest T29087

[Segmentation] Some AutoTools confirm objects to the first Label instead of selected and/or completely override existing segmentations
Closed, ResolvedPublic
Actions

Description

  1. Start Segmentation View
  2. Click "Create new segmentation". Then a label name "New Label 1" appears in the list widget. Tools are active.
  3. Add a new label "New Label 2". Select it.
  4. Now click on Otsu and generate a Preview segmentation.
  5. Click on an object from the Preview and Press Confirm

The objects are confirmed to "New Label 1" instead of "New Label 2"

Related Objects
Search...

Event Timeline

a178n created this task.Mar 30 2022, 1:41 PM
kislinsk renamed this task from [Segmentation] AutoMLSegmentationPreview based Tools confirms objects to the first Label instead of selected to [Segmentation] Some AutoTools confirm objects to the first Label instead of selected and/or completely override existing segmentations.Apr 1 2022, 9:30 AM
kislinsk triaged this task as High priority.
kislinsk edited projects, added MITK (v2022.04); removed MITK.
kislinsk added a subtask: T29096: [3D Segmentation] Threshold Tool - Does not handle multiple labels..
kislinsk added a subtask: T29097: [3D Segmentation] UL Threshold Tool - Does not handle multiple labels..
kislinsk added a subtask: T29099: [3D Segmentation] Otsu Tool - Does not handle multiple labels..Apr 1 2022, 9:33 AM
kalali added a comment.Apr 3 2022, 9:11 PM

@kislinsk I'm not sure if this is the same issue as the child issues. I guess here the problem is, that the Otsu Tool writes to the first label, although the second one is selected.
The linked issues in the subtasks in contrast all mention that a tool overwrites a label - as far as I understood they write the output to the correct label, but the previous one is just erased (which is a known problem and was already mentioned in T28991: [Segmentation] 3D tools overwrite / remove previous mask if reconfirmed.

I might be wrong, we should clarify what exactly is the difference in the tasks.

floca claimed this task.Apr 4 2022, 12:14 PM
floca added a comment.Apr 4 2022, 8:01 PM

Pushed new branch to rMITK MITK: bugfix/T29087-Fix_autosegtool_label_awarness.

kalali added a comment.Apr 9 2022, 10:45 AM

@floca I'm not sure if this was your intention but it seems as if D622 also solves this issue - at least I'm not able to reproduce this, given the description, with your changes.

floca added a comment.Apr 11 2022, 1:56 PM
In T29087#236321, @kalali wrote:

@floca I'm not sure if this was your intention but it seems as if D622 also solves this issue - at least I'm not able to reproduce this, given the description, with your changes.

Yes it was. ;)

floca moved this task from Backlog to Cycle on the MITK (v2022.04) board.Apr 13 2022, 10:45 AM
floca closed subtask T29096: [3D Segmentation] Threshold Tool - Does not handle multiple labels. as Resolved.Apr 13 2022, 4:22 PM
floca closed subtask T29097: [3D Segmentation] UL Threshold Tool - Does not handle multiple labels. as Resolved.
floca closed subtask T29099: [3D Segmentation] Otsu Tool - Does not handle multiple labels. as Resolved.
floca closed this task as Resolved.Apr 13 2022, 4:24 PM
MITK · MIC · IMSY · DKFZ