Page MenuHomePhabricator

Remove deprecated SetInputWorldGeometry3D / GetInputWorldGeometry3D of SliceNavigationController
Closed, ResolvedPublic

Description

It seems as if the two functions SetInputWorldGeometry3D and GetInputWorldGeometry3D are not used anywhere in the source code. For me it looks like all relevant code uses the two functions SetInputWorldTimeGeometry and GetInputWorldTimeGeometry instead.

Inside of the SliceNavigationController I also couldn't find any useful usage of the variable m_InputWorldGeometry3D. Everything seems to be covered by the m_InputWorldTimeGeometry variable.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

I found a line of code where the function is actually used:
Inside QmitkImageNavigatorView::SetStepSize:

if (m_IRenderWindowPart)
{
  mitk::BaseGeometry::ConstPointer geometry = m_IRenderWindowPart->GetActiveQmitkRenderWindow()->GetSliceNavigationController()->GetInputWorldGeometry3D();

  if (geometry.IsNotNull())
  {

However, it seems as this function (and QmitkImageNavigatorView::SetStepSizes) are not used at all inside the code-base.

kalali triaged this task as Normal priority.
kalali renamed this task from SetInputWorldGeometry3D / GetInputWorldGeometry3D of SliceNavigationController deprecated? to Remove deprecated SetInputWorldGeometry3D / GetInputWorldGeometry3D of SliceNavigationController.Aug 24 2022, 6:50 PM
kalali updated the task description. (Show Details)
kalali removed a project: Request for Discussion.
kalali added a revision: Restricted Differential Revision.Aug 25 2022, 3:54 PM