Page MenuHomePhabricator
Create Task
Maniphest T29306

[Segmentation] Provide Close tool (behavior of old Fill tool)
Closed, ResolvedPublic
Actions

Description

The name if the fill tool is missleading. To many people (including me and others of the team) thought it is like gimp/photoshop fill. Which is not. It is more a interactive closing operation (with a very large step size).

The proposal is to rename the tool and use another icon to reflect that better. e.g. Closing tool.

Todos:

  • Clarify if the tool should be renamed
  • Clarify if we want to introduce are real fill tool (would mean a new task)
  • Act accordingly

Remark: The close operation is also possible based on the FillRegionBaseTool. Reimplement tool this way. This also allows to depricate and remove the SetRegionTool class.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKe5f00365d075 T29078-Fix_erase_tool
Restricted Differential RevisionrMITK484f6d6cb126 Preperation of new Close tool icons with placeholder.
Restricted Differential RevisionrMITK815d672a3d46 Fixed typos
Restricted Differential RevisionrMITK7014afcb419e Added documentation of close tool
Restricted Differential RevisionrMITK89566de2f706 BREAKING: Removed obsolete class SetRegionTool.
Restricted Differential RevisionrMITK092abf8914f9 prevent crashes if the active label is not in the active label set
Restricted Differential RevisionrMITK307bd227e0aa Added close tool
Restricted Differential RevisionrMITK271839f8fd19 Reworked signature of GenerateFillImage to move the lock check logic
Restricted Differential RevisionrMITK43d1853aad0f fixed compile error
Restricted Differential RevisionrMITK30bb7f9eca23 Addapted documentation to new fill tool behavior.
Restricted Differential RevisionrMITKd7cef5bfe428 Introduced new base tool for region filling
Restricted Differential RevisionrMITKdffc8d43c586 BREAKING: Switched FillRegion and EraseRegion to new FillRegionBase tool.
Restricted Differential RevisionrMITK1c5f71f86d9a Refactored IsPositionEventInsideImageRegion to be available via

Related Objects
Search...

Event Timeline

floca triaged this task as Normal priority.Sep 21 2022, 12:49 PM
floca created this task.
floca renamed this task from [Segmentation] Rename Fill tool to [Segmentation] Provide Close tool (behavior of old Fill tool).Sep 30 2022, 3:48 PM
floca claimed this task.
floca updated the task description. (Show Details)
floca moved this task from Backlog to Segmentation on the MITK (v2022.10) board.
floca moved this task from Segmentation to Cycle on the MITK (v2022.10) board.Oct 3 2022, 9:33 AM
floca added a revision: Restricted Differential Revision.Oct 4 2022, 4:15 PM
floca closed this task as Resolved by committing rMITK307bd227e0aa: Added close tool.Oct 4 2022, 4:38 PM
floca added a commit: rMITK1c5f71f86d9a: Refactored IsPositionEventInsideImageRegion to be available via.
floca added a commit: rMITKdffc8d43c586: BREAKING: Switched FillRegion and EraseRegion to new FillRegionBase tool..
floca added a commit: rMITKd7cef5bfe428: Introduced new base tool for region filling.
floca added a commit: rMITK30bb7f9eca23: Addapted documentation to new fill tool behavior..
floca added a commit: rMITK43d1853aad0f: fixed compile error.
floca added a commit: rMITK271839f8fd19: Reworked signature of GenerateFillImage to move the lock check logic.
floca added a commit: rMITK307bd227e0aa: Added close tool.
floca added a commit: rMITK092abf8914f9: prevent crashes if the active label is not in the active label set.
floca added a commit: rMITK89566de2f706: BREAKING: Removed obsolete class SetRegionTool..
floca added a commit: rMITK7014afcb419e: Added documentation of close tool.
floca added a commit: rMITK484f6d6cb126: Preperation of new Close tool icons with placeholder..
floca added a commit: rMITK815d672a3d46: Fixed typos.
floca added a commit: rMITKe5f00365d075: T29078-Fix_erase_tool.
floca closed subtask T29307: [Segmentation] Add a fill tool like e.g. GIMP or Photoshop has as Resolved.Oct 4 2022, 4:40 PM
kislinsk mentioned this in T29327: 2022 Week 40 (Very Early October).Oct 6 2022, 5:46 AM
MITK · MIC · IMSY · DKFZ