T29078-Fix_erase_tool
Summary:
rebased
Refactored IsPositionEventInsideImageRegion to be available via SegTool2D for all 2D tools.
+ removed obsolete code
+ deprecation of functions
Introduced new base tool for region filling
BREAKING: Switched FillRegion and EraseRegion to new FillRegionBase tool. FillRegion does no a real fill operation. The old FillRegionTool will get a new name (T29306)
Addapted documentation to new fill tool behavior.
fixed compile error
Reworked signature of GenerateFillImage to move the lock check logic into the fixed part of the FillRegionBaseTool implementation.
+ Introduced a protected member that contains the clicked on label value.
+ fixed fill logic to allways handle the active label as unlocked
(like the other tools do)
Added close tool
+ fixed T29306
BREAKING: Removed obsolete class SetRegionTool.
Reason: The class is not needed anymore. All tools derived from
this class are now based on the simplier (and more robust)
FillRegionBaseTool (which fixes several bugs).
Migration: Check out the FillRegionBaseTool and how FillRegionTool,
EraseRegionTool and CloseRegionTool are implemented.
prevent crashes if the active label is not in the active label set (can happen with the current label widgets)
Added documentation of close tool
+ Improved documentation
Preperation of new Close tool icons with placeholder.
(correct icons will be added in a dedicated commit)
Fixed typos
Test Plan: code review
Reviewers: O1 MITK Reviewer Group I, kislinsk
Reviewed By: O1 MITK Reviewer Group I, kislinsk
Maniphest Tasks: T29306, T29132, T29078, T28763, T28145
Differential Revision: https://phabricator.mitk.org/D723
