Page MenuHomePhabricator
Create Task
Maniphest T29362

[mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly
Closed, ResolvedPublic
Actions

Description

As mentioned in T29203: [Multi widget] Make classes work with the new render window names render window specific names are used in some classes. {D665} removed most of the cases where a string was used.
Inside the QmitkSlicesInterpolator there is still a use of a render window string, inside QmitkSlicesInterpolator::RunPlaneSuggestion(): it is used to retrieve a render window for a plane suggestions.
Relevant functions:

  • QmitkSlicesInterpolator::OnSurfaceInterpolationFinished
  • QmitkSlicesInterpolator::StopUpdateInterpolationTimer
  • QmitkSlicesInterpolator::PrepareInputsFor3DInterpolation

Plane suggestion has been disabled in T28261: [Segmentation] Disable dysfunctional "Suggest Plane" feature of 3-d interpolation and the whole QmitkSlicesInterpolator is currently being refactored.
If we know how the future of the slices interpolator and plane suggestions looks, we need to take care of this part of code to make it work without specific render window name strings.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKcb3252d138eb Make interpolation work with arbitrary windows
Restricted Differential RevisionrMITKdb669006e1b4 remove unused parameter
Restricted Differential RevisionrMITKf54d96a9d628 use corner annotation text and update code style
Restricted Differential RevisionrMITK3633565343ee make interpolation work with arbitrary windows instead of hardcoded std windows

Related Objects
Search...

Event Timeline

kalali triaged this task as Normal priority.Oct 13 2022, 3:58 PM
kalali created this task.
kalali mentioned this in T29203: [Multi widget] Make classes work with the new render window names.Oct 14 2022, 10:48 AM
kalali mentioned this in T26376: Segmentation plugin does not work correctly with the new mxn multi widget.Oct 17 2022, 2:42 PM
kalali mentioned this in T25595: [Multi widget] Make classes work with the new render window access.Oct 17 2022, 4:43 PM
kalali edited projects, added MITK (v2023.04), Request for Discussion; removed Next Milestone, MITK.Nov 30 2022, 9:31 AM
kalali moved this task from Backlog to In candidates on the MITK (v2023.04) board.
floca moved this task from In candidates to mxn MultiWidget on the MITK (v2023.04) board.Nov 30 2022, 12:00 PM
kalali renamed this task from [Multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly to [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.Mar 24 2023, 9:03 AM
kalali removed a parent task: T28578: [mxn multi widget] Optimization of the mxn multi widget.
kalali edited subscribers, added: floca; removed: • s349i.
kalali updated the task description. (Show Details)Mar 24 2023, 9:06 AM

Updated task description since the class has been refactored. However, the issue still exists, but now it is - as far as I can see - only abut getting the visibility etc. which can easily be refactored.

s434n claimed this task.Apr 4 2023, 3:33 PM
kalali moved this task from mxn MultiWidget to Cycle on the MITK (v2023.04) board.Apr 5 2023, 9:50 AM
s434n added a revision: Restricted Differential Revision.Apr 14 2023, 11:51 AM
s434n added a commit: rMITK3633565343ee: make interpolation work with arbitrary windows instead of hardcoded std windows.Apr 17 2023, 1:02 PM
s434n added a commit: rMITKdb669006e1b4: remove unused parameter.
s434n added a commit: rMITKf54d96a9d628: use corner annotation text and update code style.
s434n added a commit: rMITKcb3252d138eb: Make interpolation work with arbitrary windows.
s434n closed this task as Resolved.Apr 17 2023, 1:02 PM
s434n mentioned this in T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.Apr 17 2023, 6:00 PM
kislinsk mentioned this in T29565: 2023 Week 18 (Very Early May).May 4 2023, 3:02 PM
MITK · MIC · IMSY · DKFZ