Page MenuHomePhabricator

Core dependency to scene serialization
Closed, ResolvedPublic

Description

As of commit 19926, the bundle gui.qt.common became a depdendency to SceneSerialization.

This is not allowed.

gui.qt.common is part of CORE and SceneSerialization is currently not even open source.

Who reviewed this core modification request?

this is no urgent 3M bug, but severe.

Event Timeline

SceneSerialization is open source, the related bug where the core modification process is documented is T2864

Still an unwanted dependency, I agree.

This is 1.0 relevant... I will try to fix it.

Talked with Hannes, solution sketch added to wiki

first adaption of the SceneIO SceneReader mechanism

second adaption of the SceneIO SceneReader mechanism

No progress yet. Still fighting with updates and patches...

I suggest a rename of the SceneReaderInterface to SceneFactoryInterface since the SceneIO class is also capeable of writing whole scenes.

(In reply to comment #8)

I suggest a rename of the SceneReaderInterface to SceneFactoryInterface since
the SceneIO class is also capeable of writing whole scenes.

I vote for SceneIOInterface , since it is not a factory itself.

CC Jochen.
This comes a little late, but Jochen and I (and Marco?) already thought about where to put which serializer classes. Your solution looks ok but maybe we can talk shortly this afternoon?

The patch include all changes and solves the dependency to core issue. Unfortunatly Drag'n'Drop for *.mitk scene files can not be restored. This is cause of the QmitkStdMultiWidgetEditor which uses the core dependend QmitkDnDFrameWidget. Copying the StdMultiWidget as well seems not to be a clean solution.
Other dependencies to DnDFrameWidget exist in DataManagerView and ImageNavigatorView which have no core dependency...

A possible solution for the StdMultiWidgetEditor problem is to set a QmitkDnDExtFrameWidget around the StdMultiWidget in the ExtApp or to set the ExtDnDFrameWidget from extern source.

[SVN revision 21277]
FIX (#3041): removed core dependency from sceneserialization; for further information see T3041 and the changerequest

The core dependency issue is resolved. The missing support for drag and drop in the ExtApp is moved to T3377