Page MenuHomePhabricator

kast (Johannes Kast)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (209 w, 5 d)

Recent Activity

Dec 7 2018

kast created T25727: Improve Rendering performance of planar figures.
Dec 7 2018, 12:08 PM · MITK

Aug 2 2016

kast added projects to T19368: Add possibility to configure annotations of PlanarFigure-Rendering: MITK, Bugzilla.
Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
kast added projects to T18550: Refactore mitkCoreServices: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
kast added a comment to T17598: Improvement of PlanarFigureSegmentation module for contours with strongly different sizes.

There is no longer a use case for this kind of segmentations. If this issue reoccures please contact Sebastian Schäfer or Markus Engel.

Aug 2 2016, 10:11 AM · MITK, Bugzilla
kast added projects to T15484: Doubled Logging output in combination with the Micro Services auto load feature: MITK, Bugzilla.
Aug 2 2016, 10:04 AM · Bugzilla, MITK
kast added projects to T11800: QmitkOverlayController: Container widgets are visible after call of AddOverlay(): MITK, Bugzilla.
Aug 2 2016, 9:53 AM · Bugzilla, MITK
kast added a comment to T11106: Reformatting of Tilted Gantry series in DICOMSeriesReader.

[620cdc]: Merge branch 'bug-11106-gantry-tilt-cleaned-up'

Merged commits:

2012-08-27 14:17:58 Johannes Kast [b88875]
changed mitk data revision for new tilted test data

Aug 2 2016, 9:52 AM · Bugzilla, MITK
kast added a comment to T11106: Reformatting of Tilted Gantry series in DICOMSeriesReader.

Daniel and I finished the work on this feature and added additional tests to the DICOMLoading Tests.

Aug 2 2016, 9:52 AM · Bugzilla, MITK
kast added projects to T11106: Reformatting of Tilted Gantry series in DICOMSeriesReader: MITK, Bugzilla.
Aug 2 2016, 9:51 AM · Bugzilla, MITK
kast added a comment to T10248: Ensure proper rendering of "Inverted Black to White" lookup table.

This change was only pushed to the branch releases/snapshot-201109-2 until a more general solution for this problem is provided.

Aug 2 2016, 9:50 AM · Bugzilla, MITK
kast added projects to T10248: Ensure proper rendering of "Inverted Black to White" lookup table: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · Bugzilla, MITK
kast added projects to T10245: Is transparent background still reasonable?: MITK, Bugzilla.
Aug 2 2016, 9:50 AM · Bugzilla, MITK
kast added a comment to T10138: Provide different lookup tables (LUT) for use in MITK rendering.

Meanwhile MITK has a more advanced LUT implementation. Its safe to close this ticket.

Aug 2 2016, 9:49 AM · Bugzilla, MITK
kast added a comment to T10138: Provide different lookup tables (LUT) for use in MITK rendering.

The unit test of mitkLookupTable was extended to use all (and future) lookup tables in the proposed provider class. This is also part of the patch. The test was not started and compiled yet.

Aug 2 2016, 9:49 AM · Bugzilla, MITK
kast added a comment to F751: LUT.patch.

Implementation of LUT Provider including Test

Aug 2 2016, 9:49 AM
kast added a comment to T10138: Provide different lookup tables (LUT) for use in MITK rendering.

Implementation of LUT Provider including Test

Aug 2 2016, 9:49 AM · Bugzilla, MITK
kast added projects to T10138: Provide different lookup tables (LUT) for use in MITK rendering: MITK, Bugzilla.
Aug 2 2016, 9:49 AM · Bugzilla, MITK
kast added a comment to T7339: Provide DICOM tags as MITK properties of mitk::Image.

Sorry, too late for the last comment...

Aug 2 2016, 9:44 AM · Bugzilla, MITK
kast added a comment to T7339: Provide DICOM tags as MITK properties of mitk::Image.

Bei der Übergabe der map aus dem "scanner" objekt (->GetMappings()) wurde die Map zwar kopiert aber die Inhalte der Map Schlüssel (char Pointer) wurden gelöscht. In einer Debug Umgebung unter Windows (Inhalte hinter Pointern werden bei Aufruf des destruktors überschrieben) kommt es dann zum Crash beim Zugriff.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
kast added a comment to T7339: Provide DICOM tags as MITK properties of mitk::Image.

Push mit Hash: d403326d36fa9f0292ee5bf2ef905b503292285f

Aug 2 2016, 9:44 AM · Bugzilla, MITK
kast added a comment to T7339: Provide DICOM tags as MITK properties of mitk::Image.

[d40332]: Merge branch 'bug-7339-fix-wrong-dicom-property-retrieve'

Aug 2 2016, 9:44 AM · Bugzilla, MITK
kast added a comment to T7339: Provide DICOM tags as MITK properties of mitk::Image.

Bitte um Review der Änderungen.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
kast added projects to T6526: Logging: FormatFull has a newline after the time stamp: MITK, Bugzilla.
Aug 2 2016, 9:42 AM · Bugzilla, MITK
kast added a comment to T6526: Logging: FormatFull has a newline after the time stamp.

Commit in T5164 . REV: 28902

Aug 2 2016, 9:42 AM · Bugzilla, MITK
kast added a comment to T6526: Logging: FormatFull has a newline after the time stamp.

This is fixed. Commit follows ...

Aug 2 2016, 9:42 AM · Bugzilla, MITK
kast added a comment to T5874: Enhance mitk::FileWriter and mitk::FileReader to allow for writing/reading from memory buffers.

[SVN revision 27193]
FIX (#5874): added additional check for memory size

Aug 2 2016, 9:41 AM · Bugzilla, MITK
kast added a comment to T5682: Insert ColorProperty for the volume annotation of binary images.

[SVN revision 26649]
ENH (#5682): added color property for the volume annotation; added string property for the unit of the volume annotation;

Aug 2 2016, 9:41 AM · Bugzilla, MITK
kast added a comment to T5682: Insert ColorProperty for the volume annotation of binary images.

[SVN revision 26653]
COMP (#5682): removed unused variable;

Aug 2 2016, 9:41 AM · Bugzilla, MITK
kast added a comment to T5682: Insert ColorProperty for the volume annotation of binary images.

Kann geschlossen werden...

Aug 2 2016, 9:41 AM · Bugzilla, MITK
kast added a comment to T5682: Insert ColorProperty for the volume annotation of binary images.

The unit should be also customizable. Siemens uses in his Syngo application cm3 instead of ml.

Aug 2 2016, 9:41 AM · Bugzilla, MITK
kast added projects to T5682: Insert ColorProperty for the volume annotation of binary images: MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
kast added a comment to T5606: Enhance Unittest for PlanarPolygon to test self-intersection checks.

We should definitly write a unit test for this. This is still relevant.

Aug 2 2016, 9:40 AM · Bugzilla, MITK
kast added a comment to T4591: NavigationDataPlayer depends on line endings for reading xml navigation data.

Hi, I do not know how much work this is but at the moment it is not possible for me to free some time for IGT... Sorry Michi -> assign goes back

Aug 2 2016, 9:38 AM · Bugzilla, MITK
kast added a comment to F503: pic2vtk_Linker_Error_Fix_VTK5.6.0.patch.

Fixes linker error in mitkCore caused by a changed interface in VTK IO

Aug 2 2016, 9:36 AM
kast added a comment to T3493: Make MITK compatible with VTK 5.6.

The release version of VTK 5.6.0 has a changed interface in vtkImageReader::SetDataMask().

Aug 2 2016, 9:36 AM · Bugzilla, MITK
kast added projects to T3399: Set automatically the compiler flags in CMake for 64bit Windows: MITK, Bugzilla.
Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3380: Use Level-of-Detail for surface rendering.

Last comment (SVN) has a wrong Bug ID: The comment is related to T3308

Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3341: Extend RenderingManager with Property list.

[SVN revision 21370]
ENH (#3341): added PropertyList to RenderingManager

Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3341: Extend RenderingManager with Property list.

Implementation is finished. I created the unit test for the rendering manager see T1985

Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3341: Extend RenderingManager with Property list.

[SVN revision 21371]
ADD (#3341): added test for RenderingManager for testing the PropertyList see also T1985

Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3336: mitkSceneIOTest fails randomly.

@Sascha
On which machines does the test fail. For us on Windows 7 64bit everything went fine so far.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3291: rename DataTreeNode.

Data is everything ;-)

Aug 2 2016, 9:35 AM · Bugzilla, MITK
kast added a comment to T3187: Reconsider design of QmitkRenderWindowMenu.

As this is the new job of Markus Engel (refactoring MultiWidget/render windows) this is in my opinion not 1.0 relevant.

Aug 2 2016, 9:33 AM · Bugzilla, MITK
kast added a comment to T3187: Reconsider design of QmitkRenderWindowMenu.

Meanwhile the design of the of this widget has changed several times this is no longer an issue.

Aug 2 2016, 9:33 AM · Bugzilla, MITK
kast added a comment to T3041: Core dependency to scene serialization.

The core dependency issue is resolved. The missing support for drag and drop in the ExtApp is moved to T3377

Aug 2 2016, 9:32 AM · Bugzilla, MITK
kast added a comment to T3041: Core dependency to scene serialization.

No progress yet. Still fighting with updates and patches...

Aug 2 2016, 9:32 AM · Bugzilla, MITK
kast added a comment to T3041: Core dependency to scene serialization.

I suggest a rename of the SceneReaderInterface to SceneFactoryInterface since the SceneIO class is also capeable of writing whole scenes.

Aug 2 2016, 9:32 AM · Bugzilla, MITK
kast added a comment to T3041: Core dependency to scene serialization.

This is 1.0 relevant... I will try to fix it.

Aug 2 2016, 9:32 AM · Bugzilla, MITK
kast added a comment to T3003: Severe memory leak in Segmentation: Shape Model part.

[SVN revision 20318]
CHG (#3003): added a method for cleaning up the segmentation filter

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2987: Segmentation with shape model still crashes after finishing.

As this bug affects only shape model segmentation tools this is not 1.0 relevant.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2987: Segmentation with shape model still crashes after finishing.

We can close this one. Tobi do you agree?

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2987: Segmentation with shape model still crashes after finishing.

Talked to Tobi he agreed to close this one

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2987: Segmentation with shape model still crashes after finishing.

In release mode it is not crashing on my 64bit windows. "Abort Segmentation" is crashing.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2979: Organize shape models distribution.

I suggest to use this models for the installer:

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2973: Enable slice interactor while shape model placement.

It seems that the slice interactor is shut down with the start of the painting tools. Is there a way to suppress this?

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added projects to T2950: Loading a scene file with drag and drop: MITK, Bugzilla.
Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2950: Loading a scene file with drag and drop.

[SVN revision 20116]
CHG (#2950): enabled drag and drop support for *.mitk scene files

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2930: Shape Model disappeares when selecting it in data manager.

I think this behavior is caused on the selection service.
Deselected reference node -> ToolManager gets notified -> there is no reference image anymore for the tool -> tool is deactivated -> ...

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2925: Loading a scene/project file does not reinit the views.

I will try to fix the DnD loading today.

Aug 2 2016, 9:31 AM · Bugzilla, MITK
kast added a comment to T2864: Enable Save/Load from scene files in the main menu.

[SVN revision 19926]
ADD (#2864): added menu entry File->Save Project... as a FileSaveProjectAction. The scene can now be stored with this mechanism; added .mitk file extension to the object factories; enabled load mechanism for .mitk files over the menu

Aug 2 2016, 9:30 AM · Bugzilla, MITK
kast added projects to T2864: Enable Save/Load from scene files in the main menu: MITK, Bugzilla.
Aug 2 2016, 9:30 AM · Bugzilla, MITK
kast added a comment to T2699: New icons for segmentation tools.

[SVN revision 20283]
CHG (#2699): included the new icons

Aug 2 2016, 9:29 AM · Bugzilla, MITK
kast added a comment to T2699: New icons for segmentation tools.

The icons in the segmentation folder are to small. Perhaps we try larger ones. Marco can you just exchange the pictures with the right names and identifiers in the images?

Aug 2 2016, 9:29 AM · Bugzilla, MITK
kast added a comment to T2662: Skin feature for MITK.

Three different simple themes

Aug 2 2016, 9:28 AM · Bugzilla, MITK
kast added a comment to T2662: Skin feature for MITK.

What you need are the files as mentioned in commend #2 from Sascha. I played around with the Qt paletts (dark, shadow, light, etc. see Qt Doku) but for a really nice skin you have to use own colours for the different widgets.

Aug 2 2016, 9:28 AM · Bugzilla, MITK
kast added a comment to F339: MITK theme.zip.

Three different simple themes

Aug 2 2016, 9:28 AM
kast added projects to T2640: The Surface Material Editor only edits the first entry of the combo box: MITK, Bugzilla.
Aug 2 2016, 9:28 AM · Auto-closed, Bugzilla, MITK
kast added a comment to T2476: Implement preprocessor for preparing segmented images for volume rendering.

Around line 222 in mitk::VolumeVisualizationImageProcessor (rev. 18958) a OrImageFilter is used just to create a copy of the input image. This should be changed to a nicer way of copying an image.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
kast added a comment to T2414: Refactore the mitkKeyEvent class.

The refactoring is done. See the change request file for the made changes.

Aug 2 2016, 9:27 AM · Bugzilla, MITK
kast added a comment to F295: ChangeRequest.txt.

ChangeRequest

Aug 2 2016, 9:27 AM
kast added projects to T2414: Refactore the mitkKeyEvent class: MITK, Bugzilla.
Aug 2 2016, 9:27 AM · Bugzilla, MITK
kast added a comment to T2414: Refactore the mitkKeyEvent class.

Change Request

Aug 2 2016, 9:27 AM · Bugzilla, MITK
kast added a comment to F297: ChangeRequest.txt.

Change Request

Aug 2 2016, 9:27 AM
kast added a comment to T2363: It is not possible to use mouse wheel events in interactors.

Now we can use mouse wheel interactions. A first manual test of the wheel movement information inside of a bundle was positive.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
kast added a comment to T2363: It is not possible to use mouse wheel events in interactors.

In mitkEventTypeDef.h you find "typedef DisplayPositionEvent WheelEvent;".
This works because by now everyone uses the WheelEvent for clicks and the resulting position. Now we want additional information about the mouse wheel movement. So we should implement a new class mitkWheelEvent derived from DisplayPositionEvent which has an additional parameter for the mouse wheel movement (delta).
Also the QmitkEventAdapter class has to be modified to throw proper mouse wheel events.

Aug 2 2016, 9:26 AM · Bugzilla, MITK
kast added a comment to T2363: It is not possible to use mouse wheel events in interactors.

ChangeRequest

Aug 2 2016, 9:26 AM · Bugzilla, MITK
kast added a comment to T2363: It is not possible to use mouse wheel events in interactors.

The bug needs to be reopend due to neccessary changes in QmitkEventAdapter

Aug 2 2016, 9:26 AM · Bugzilla, MITK
kast added a comment to F278: ChangeRequest.txt.

ChangeRequest

Aug 2 2016, 9:26 AM
kast added a comment to T2200: Port IGT-Example to OpenCherry.

A first version was commited. There are still some Qt related signal/slot issues...

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2200: Port IGT-Example to OpenCherry.

The signal slot problems are solved. The methods inside the old ui.h file moved to the QmitkIGTExampleView class.
Due to Qt4 porting the old state (PropertyList) of the bundle is not stored anymore.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

I am closing this as the test coverage is good enough.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

The SceneIO test now has a coverage with 69%. For further improvements make checks for empty and already filled datastorage and also save render specific properties.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

@Daniel is there a bug for the scene serialization not storing BaseDatas ?

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

Is there any reason why the PropertySerializationTest is not in the configuration? It works fine for me on Windows 7 64.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

This was not a bug. In building up the data storage was a c&p error...

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

I will write a test the next days...

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2185: Implement test cases for scene serialization.

The reading part of the SceneIO test revealed that some data is not stored:

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2133: Adapt the unit test for the NavigationDataLandmarkTransformFilter.

A test was added for the error calculation. Two pointsets are created with two cubicals. Those are registered and the error calculations of the filter are compared to the known error values.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added projects to T2133: Adapt the unit test for the NavigationDataLandmarkTransformFilter: MITK, Bugzilla.
Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to F233: StatusBar.patch.

First progress from the bug squashing party for BUG 2132

Aug 2 2016, 9:25 AM
kast added a comment to T2132: StatusBar should show pixel values when clicking into render window.

First progress from the bug squashing party for T2132

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2110: rename and improve RandomTrackingDevice.

Also loading a PointSet and interpolate between those points would be nice.

Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2098: NavigationDataLandmarkTransformFilter should calculate the FRE.

Was implemented. Following additional functions are now available for gathering registration errors:

ScalarType GetFRE() const;
ScalarType GetFREStdDev() const;
ScalarType GetRMSError() const;
ScalarType GetMinError() const;
ScalarType GetMaxError() const;
ScalarType GetAbsMaxError() const;
Aug 2 2016, 9:25 AM · Bugzilla, MITK
kast added a comment to T2065: Reimplement the XML IO functionality for mitkLevelWindowPreset.

The bundle was ported but there is still work to do:

Aug 2 2016, 9:24 AM · Bugzilla, MITK
kast added a comment to T2065: Reimplement the XML IO functionality for mitkLevelWindowPreset.

This is already fixed. Bug closed...

Aug 2 2016, 9:24 AM · Bugzilla, MITK
kast added projects to T2065: Reimplement the XML IO functionality for mitkLevelWindowPreset: MITK, Bugzilla.
Aug 2 2016, 9:24 AM · Bugzilla, MITK
kast added a comment to T2065: Reimplement the XML IO functionality for mitkLevelWindowPreset.

This is 1.0 relevant. I will check if there is a new implementation. If not I will use the preference store to resolve this issue.

Aug 2 2016, 9:24 AM · Bugzilla, MITK
kast added a comment to T2065: Reimplement the XML IO functionality for mitkLevelWindowPreset.

Is now a party bug

Aug 2 2016, 9:24 AM · Bugzilla, MITK
kast added a comment to T1796: Unit Test for NavigationData to PointSet filter.

A test was submitted...

Aug 2 2016, 9:22 AM · Bugzilla, MITK
kast added a comment to T1795: NavigationData to PointSet filter for MITK-IGT.

All features are implemented

Aug 2 2016, 9:22 AM · Bugzilla, MITK