Page MenuHomePhabricator

Reconsider design of QmitkRenderWindowMenu
Closed, WontfixPublic


The design of the render window menus (classes QmitkRenderWindowMenu, QmitkRenderWindow and QmitkStdMultiWidget) seems misconstructed in some parts.

One side effect of this design was an application crash (T3186).

The main problem is this:

  • the "crosshair" is a property / a thing of the multiwidget
  • the render window layout is an issue of the multiwidget
  • however, both things are handled not by the multiwidget but by an event cascade between QmitkRenderWindowMenu, QmitkRenderWindow and QmitkStdMultiWidget

The attached scribble illustrates the problem.

I suggest to go through this again and refactor the existing code so that it becomes more understandable and maintainable.

scan.png (1×1 px, 27 KB)

Event Timeline

Assigning this to default assignee because mbi-bug-manager is not a person and cannot evaluate/reassign this bug. Would you please assign it to the correct product/component and estimate whether it is relevant for the 1.0 release? Thank you.

As this is the new job of Markus Engel (refactoring MultiWidget/render windows) this is in my opinion not 1.0 relevant.

I can only agree with Hannes.
The whole rendering-mechanism will be redesigned soon anyway.

Not sure this will be finishesd until 1.0 Release.
Really relevant?

Resetting all bugs without active assignee flag to "CONFIRMED". Change status to IN_PROGRESS if you are working on it.

Meanwhile the design of the of this widget has changed several times this is no longer an issue.

kislinsk added a project: Bulk Edit.
kislinsk removed a project: Bulk Edit.