Page MenuHomePhabricator

Test the new VTK Rendering
Closed, ResolvedPublic

Assigned To
None
Authored By
kilgus
Aug 25 2011, 3:31 PM
Referenced Files
F723: wrong_position.png
Aug 31 2011, 2:54 PM
F722: Pic3D_Small.pic.gz
Aug 25 2011, 3:36 PM
F721: rgbaTestImg.png
Aug 25 2011, 3:36 PM
F720: ramp.tif
Aug 25 2011, 3:35 PM

Description

Checkout the integration branch and test the new 2D VTK rendering.

Very important:
-try if you own rendering stuff (e.g. QBalls and other rendering extensions) are still working.
-this bug is only about 2D rendering!!! So don't worry about the 3D render window and compare the 2D render windows to an older version of MITK (e.g. 3M3).

Attached you can find some nice test images.

Event Timeline

Also very important: Check if your own special images which you use every day are rendered correctly in 2D!!!

Some things you can pay attention to:
-is the crosshair always exactly in the middle of a pixel if only one images is loaded?
-are all pixels drawn or are some cut off at the borders?
-are there any black pixels where should be colored ones?
-is the opacity/color/level window property working on the image?
-can you set a user defined lookuptable to set the level window of the image?
-can you zoom/pan? does the image disappear during zooming/panning?
-can you see inserted points?
-can you see segmentations/contours?

GOGO test test test!!! :)

The integration branch name is:

(remotes/origin)/bug-9176-RenderingIntegrationTest

I came across 3 bugs so far:

dwi Image channel selection does not work, no matter how the slider is moved only the last channel is rendered.

The level window is slightly off (just open the same picture with an old and a new rendering mechanism, move them over each other and compare by eyeball ).

After minimizing and maximizing the 2D renderwindows are pure white.

I noticed a problem with the measurement tool working with the rgbaTestImg.png. You can't see your line/circle/... which you drew or rather it looks like it is in the background. The data (e.g. length) will be calculated anyway.

Zooming seems considerably slower on the test png image using the new method.

When panning on the test png image the image and crosshair move separately and after panning the crosshair does not necessarily end up in the correct position. Panning is slower as well.

An example of the crosshair not ending up in the correct position in relation to the image.

wrong_position.png (525×608 px, 2 KB)

TODO for Diffusion Image compatibility

change in mitkImageVTKMapper2D "GenerateData()" to "GenerateDataForRenderer()"

-Zooming seems considerably slower on the test png image using the new method. => Fixed

-After minimizing and maximizing the 2D renderwindows are pure white.

> Duplicate of #9048

-I noticed a problem with the measurement tool working with the rgbaTestImg.png.
You can't see your line/circle/... which you drew or rather it looks like it is
in the background. The data (e.g. length) will be calculated anyway.

> New bug: #9234

The level window is slightly off (just open the same picture with an old and a
new rendering mechanism, move them over each other and compare by eyeball ).

> New bug: #9236

When panning on the test png image the image and crosshair move separately and
after panning the crosshair does not necessarily end up in the correct
position. Panning is slower as well.

> New bug: #9237

[101d7a]: Merge branch 'bug-9176-RenderingIntegrationTest'

Conflicts:
Core/Cod

Merged commits:

2011-09-09 15:55:21 Thomas Kilgus [880403]
Merge branch 'bug-7027-2DRendering' into bug-9176-RenderingIntegrationTest

Conflicts:
Core/Code/Rendering/mitkImageVtkMapper2D.cpp
Core/Code/Rendering/vtkMitkApplyLevelWindowToRGBFilter.cpp
Modules/Bundles/org.mitk.gui.qt.basicimageprocessing/src/internal/QmitkBasicImageProcessingView.cpp


2011-09-09 13:51:16 Thomas Kilgus [85d85e]
Revert of some tmp changes in basicimageprocessingview. Very stable 2D rendinger version.


2011-09-09 13:11:47 Thomas Kilgus [009bab]
Outcommented a bool flag inside the proprenderer, because it is not working with QBalls yet.


2011-09-09 11:46:33 Thomas Kilgus [835a20]
Fixed a bug with the RGB lut.


2011-09-09 10:52:06 Thomas Kilgus [2ab97c]
Implemented a method to calculate the depth of an object for rendering.


2011-09-08 16:55:52 Thomas Kilgus [165482]
Fixed initialization inside the local storage.


2011-09-08 16:41:10 Thomas Kilgus [706748]
Refactoring session with Markus F. of ImageVtkMapper, VtkPropRenderer and removed quick fix of T9048.


2011-09-08 10:33:57 Thomas Kilgus [23979d]
Added work arround for T9048.


2011-09-08 09:54:39 Thomas Kilgus [5a8f7d]
Added comment for the depth in the crosshair mapper.


2011-09-08 09:50:01 Thomas Kilgus [2625e5]
Added comments in the RenderingManager for PrepareRender() call.


2011-09-08 09:40:59 Thomas Kilgus [5862d5]
Refactored my parts of the prop renderer. Added/improved documentation. Minor docu changes in the imageVtkMapper.


2011-09-07 18:43:59 Thomas Kilgus [f076ca]
Refactoring and minor docu changes.


2011-09-07 16:57:52 Thomas Kilgus [569c93]
Merge remote-tracking branch 'origin/bug-7027-2DRendering' into bug-7027-2DRendering


2011-09-07 16:48:03 Thomas Kilgus [310602]
Quick and dirty Fangerau Fix.

Conflicts:

Core/Code/Rendering/mitkGeometry2DDataMapper2D.cpp
Core/Code/Rendering/mitkVtkPropRenderer.cpp


2011-09-07 15:25:05 Eric Heim [867dcf]
Merge branch 'bug-9236-Levelwindow' into bug-7027-2DRendering


2011-09-07 15:21:14 Eric Heim [c88460]
Changed the the default value of the lookuptable from RampScurve to linear and the setting in initialisation.


2011-08-31 16:58:15 Eric Heim [f7a868]
replaced GenerateData() with GenerateDataForRenderer()


2011-08-31 16:16:25 Thomas Kilgus [6bb9b5]
Removed -1 in RGB filter. Rendering is now not performed when the display geometry is changed.


2011-08-31 15:46:21 Thomas Kilgus [3036bb]
Removed output.


2011-08-31 15:01:15 Thomas Kilgus [17e5b8]
Properties are only applied if they are changed.


2011-08-31 14:06:48 Thomas Kilgus [8c8bfc]
Replaced M_PI with itk::math::pi.


2011-08-30 17:13:17 Caspar Goch [705369]
Removed sleep to enable compile


2011-08-30 16:24:15 Thomas Kilgus [cffcdc]
Quick fix for M_PI in windows.


2011-08-25 15:25:34 Thomas Kilgus [dc8e85]
Fixed some files which did not merge correctly.


2011-08-25 10:57:36 Thomas Kilgus [8d8901]
Merge branch 'bug-7027-2DRendering' into RenderingIntegrationBranch250811

Conflicts:
Core/Code/Rendering/mitkGeometry2DDataVtkMapper3D.cpp
Core/Code/Rendering/mitkGeometry2DDataVtkMapper3D.h
Core/Code/Rendering/mitkImageMapperGL2D.cpp
Core/Code/Rendering/mitkImageMapperGL2D.h
Core/Code/Rendering/mitkVtkPropRenderer.cpp
Core/Code/Rendering/vtkMitkRenderProp.cpp
Modules/Bundles/org.mitk.gui.qt.datamanager/src/QmitkDataManagerView.cpp
Modules/DiffusionImaging/Rendering/mitkOdfVtkMapper2D.txx
Modules/MitkExt/Algorithms/mitkExtractDirectedPlaneImageFilter.cpp


2011-08-25 09:38:24 Thomas Kilgus [8bd31c]
Merge branch 'bug-3257-RGBAlevelWindow' into bug-7027-2DRendering


2011-08-25 09:36:19 Thomas Kilgus [8496d5]
Added documentation. Some minor changes.


2011-08-24 17:27:43 Thomas Kilgus [58cc02]
Implemented the opaque level window. Removed the VTK filters which converted the image back and forth to HSI and RBG. This is done inside our filter now with code from iil.


2011-08-11 10:57:34 Thomas Kilgus [0acefd]
Finished threaded execute.


2011-08-11 09:17:53 Thomas Kilgus [4d1827]
Added danials filter files.


2011-08-11 09:17:09 Thomas Kilgus [43a081]
Used danials filter to apply a level window on RGBA images. Implemented missing header. TODO: opacity level window and threadedExecute. Not compiling, because we started to implemented threadedExcecute.


2011-08-04 15:52:54 Thomas Kilgus [9ec305]
Fixed a crash in the outlining process.


2011-08-04 14:28:15 Thomas Kilgus [e7e825]
Removed 0.5 offset from QBalls again, because it seems to be unnecessary.


2011-08-04 14:12:51 Thomas Kilgus [df9258]
Removed unnecessary camera reset from rropRender; Finished camera positioning in propRenderer; AdjustCameraToScene is now called before rendering in Reninit; Added conversion between center based (MITK) and corner based (VTK) coordinates; Removed old camera method from the imageVtkMapper2D


2011-08-01 16:32:01 Thomas Kilgus [1ac3f6]
Merge branch 'bug-8467-RenderingDocu' into bug-7027-2DRendering

Conflicts:
Core/Code/Rendering/mitkImageVtkMapper2D.cpp


2011-08-01 16:29:32 Thomas Kilgus [0f7487]
Added missing .png


2011-08-01 16:04:55 Thomas Kilgus [68b0ae]
Merge branch 'bug-8630-RepairDTIiamges' into bug-7027-2DRendering


2011-08-01 15:59:27 Thomas Kilgus [0d1537]
Merge branch 'bug-8892-QBallsRendering' into bug-7027-2DRendering


2011-08-01 15:57:19 Thomas Kilgus [da85bd]
Moved the camera modifications to the prop renderer. The transformation to camera and image is outcommented, because it is not working yet in the prop renderer.


2011-07-27 15:37:28 Thomas Kilgus [add746]
Added a property to shift the image in depth direction in order to render something into the voxels.


2011-07-27 14:32:49 Thomas Kilgus [10b029]
Added camera function dummy in prop renderer.


2011-07-27 10:17:04 Thomas Kilgus [ed3d5d]
Outcommented DoRefresh parts and AdaptCameraPosition.


2011-07-13 16:48:46 Ignaz Reicht [dc9684]
corrected typos and language style ;-)


2011-07-11 13:44:27 Thomas Kilgus [c1c811]
Removed tabs.


2011-07-11 13:43:54 Thomas Kilgus [0a0650]
Removed tabs.


2011-07-11 11:39:28 Thomas Kilgus [343f11]
Removed tabs


2011-07-11 11:15:48 Thomas Kilgus [1eeffb]
Removed tabs


2011-07-07 18:07:21 Thomas Kilgus [6ae999]
Added documentation and .png files.


2011-07-07 16:29:07 Thomas Kilgus [210050]
Cleaned up code. Removed unnecessary stuff. Added comments and docu.


2011-07-07 14:45:32 Thomas Kilgus [75dd35]
Fixed the bug by returning a vtkPropAssembly in the CompositeMappers method GetVtkProp().


2011-07-06 14:27:15 Thomas Kilgus [d2d5dd]
Cleaned up code.


2011-07-06 14:10:02 Thomas Kilgus [7d152c]
Removed debugging output. Found high clipping range which works good.


2011-06-30 17:09:04 Thomas Kilgus [942cc7]
Replaced the vtkTransformationFilter by SetUserTransform. CameraDebugging ongoing.


2011-06-28 16:26:02 Thomas Kilgus [fc7313]
Currently a fixed clipping range seems to work.


2011-06-28 12:38:05 Thomas Kilgus [d19087]
Removed some output for the integration branch and set the background to black.


2011-06-27 17:26:12 Thomas Kilgus [857dea]
Refactored some lines. Removed RenderInfo completely (even from the 3D part).


2011-06-27 17:25:28 Thomas Kilgus [b8f40b]
Removed the unnecessary enabled/disbale methods from the composite mapper.


2011-06-27 17:23:44 Thomas Kilgus [a839cb]
Fixed a bug that the 3D view was set for all renderwindows (even for 2D) in the CameraController.


2011-06-22 10:02:51 Thomas Kilgus [b51686]
Outcommented code in mitkCameraController, whole body example buggy.


2011-06-21 11:32:03 Thomas Kilgus [d67945]
Refactored the contouring code and fixed a bug when image spacing was not taken into account.


2011-06-21 10:50:32 Thomas Kilgus [274066]
Outline Binary working.


2011-06-20 17:50:08 Thomas Kilgus [cc4d45]
First version of CreateOutlinePolyData.


2011-06-17 13:05:37 Thomas Kilgus [1c5f67]
Contiuned last commit with UnitSpacingFilter and ThickSliceFilter.


2011-06-17 10:42:09 Thomas Kilgus [4bb318]
Started combining localStorage and RenderInfo: UpdateTime, Reslicer.


2011-06-15 10:59:40 Thomas Kilgus [210997]
Some minor refactoring, first version of binary outline.


2011-06-10 13:03:17 Thomas Kilgus [a117c7]
Fixed the swivel mode


2011-06-09 14:55:40 Thomas Kilgus [c274b2]
Fixed an issue where the user-defined lut would not use the level window.


2011-06-08 09:28:48 Thomas Kilgus [e7ce61]
Quick fix for updating properties: this->Update()


2011-06-06 16:42:14 Thomas Kilgus [843bf1]
Refactored more code, removed unused variables, added docu etc.. Outcommented code for debugging purposes.


2011-06-06 11:42:52 Thomas Kilgus [a47bbf]
Refactored the rest of GenerateData() as good as possible


2011-06-03 15:30:40 Thomas Kilgus [e46a0b]
Refactored GenerateData() until line 330. Added some TODOs.


2011-06-03 14:22:21 Thomas Kilgus [e1f754]
Refactored includes


2011-06-03 14:06:02 Thomas Kilgus [36424e]
Refactored header file


2011-06-03 13:18:43 Thomas Kilgus [5a4931]
Fixed the translucent crosshair issue with a workarround. The crosshair is now rendered in the z=1 plane.


2011-06-03 10:38:44 Thomas Kilgus [d49e23]
Removed some output.


2011-06-01 12:45:01 Thomas Kilgus [ea4d14]
Removed some output


2011-05-30 17:16:35 Thomas Kilgus [1b0b5c]
Fixed a bug with the outline flag. Removed vtkContourFilter because its not working yet.


2011-05-30 17:16:14 Thomas Kilgus [2b26e7]
Fixed a bug with the outline flag. Removed vtkContourFilter because its not working yet.


2011-05-30 15:51:15 Thomas Kilgus [9eb923]
First version of binary outline.


2011-05-26 15:14:50 Thomas Kilgus [c253e1]
Final version of all properties and binary image handling except binary outline.


2011-05-25 13:26:08 Thomas Kilgus [e4a2e5]
First version of binary image handling and other properties.


2011-05-19 18:18:07 Thomas Kilgus [f1e79d]
Quick fix for the black crosshair etc., first version of ApplyProperties.


2011-05-18 10:10:54 Thomas Kilgus [9d0915]
Removed uneccessary 1/factor


2011-05-16 10:56:24 Thomas Kilgus [39ce11]
Revert of +1.0 at the bounds.


2011-05-16 10:50:07 Thomas Kilgus [5a5bae]
Refactoring: added docu, removed outcommented code.


2011-05-13 16:40:59 Thomas Kilgus [69ed4c]
Removed some old outputs


2011-05-13 15:59:06 Thomas Kilgus [39931e]
Fixed the small pixel-offset by setting origin to (0/0/0)


2011-05-13 14:54:51 Thomas Kilgus [a41cd1]
Most stable version so far. The following things work: Zooming, Panning, Scaling, Clipping, LevelWindow, Opacity, Color.


2011-05-11 13:29:15 Thomas Kilgus [4f76d1]
Zooming with camera->zoom


2011-05-09 18:02:24 Thomas Kilgus [748d3c]
Panning seems now to be correct. Plus, vtkCamera->ApplyTransform seems to be very usefull


2011-05-06 16:46:00 Thomas Kilgus [86fb95]
It can haz panning.


2011-05-05 18:16:53 Thomas Kilgus [81f286]
It can haz zoom now.


2011-05-04 11:02:58 Thomas Kilgus [134e18]
Corrected Transversal camera position


2011-05-02 16:46:27 Thomas Kilgus [3aa97e]
Fixed the RenderTranslucentGeo bug


2011-05-02 13:26:16 Thomas Kilgus [99ef43]
Refactoring: Removed some outcommented code and added comments for documentation.


2011-05-02 11:43:26 Thomas Kilgus [95347e]
Camera position is now set according to the transformed plane. However, the up vector is not set correctly. Removed all remaining iil and pic stuff.


2011-04-28 17:46:44 Thomas Kilgus [d771cc]
Refactoring: New methods AdjustCamera and AdjustToDisplaySize


2011-04-26 16:46:57 Thomas Kilgus [bbba6d]
Set the camera position according to display geometry


2011-04-22 15:10:58 Thomas Kilgus [b4d658]
Refactoring: removed further dead code. Color Property is working now. Started implementing ApplyProperties.


2011-04-22 13:55:37 Thomas Kilgus [5375a4]
Refactoring: removed dead type defs


2011-04-22 13:40:15 Thomas Kilgus [a33096]
Refactoring: removed a lot of unneccessary imports and reorganized the remaining imports


2011-04-22 13:24:00 Thomas Kilgus [137adf]
Refactoring: renamed ImageMapperGL2D to ImageVtkMapper2D and removed the old, unused ImageVtkMapper2D


2011-04-22 13:04:28 Thomas Kilgus [a9f2fd]
Refactoring: removed almost all outcommented code parts


2011-04-21 13:25:24 Thomas Kilgus [d7c74b]
all 3 renderwindows show each view: transveral, coronal and sagittal


2011-04-20 11:02:51 Thomas Kilgus [d447cc]
removed some output


2011-04-18 18:36:33 Thomas Kilgus [48dfe8]
opacity is working now with the old work arround. removed user transform


2011-04-08 17:31:01 Thomas Kilgus [793413]
Lookup table works, CameraReset Bounds, level Window ok


2011-04-07 17:13:18 Thomas Kilgus [a9e6db]
Colored Pic 3D is working now. Lut is not working ...


2011-04-06 13:49:00 Thomas Kilgus [854ded]
trying to use a vtkTexture


2011-04-05 09:42:44 Thomas Kilgus [08a8f4]
reactivated imageMapperGL2D


2011-04-05 09:39:02 Thomas Kilgus [38e0c2]
mitkImageVtkMapper2D is running in all renderWindows


2011-04-01 14:38:03 Thomas Kilgus [6e4564]
ViewX viewY viewZ


2011-03-31 16:59:57 Thomas Kilgus [7ed8ee]
Slicing works by means of the vtkCamera after pressing TestButton in BasicImgProc


2011-03-31 13:30:03 Thomas Kilgus [fa03e6]
Added button for testing purposes into BasicImageProcessing


2011-03-28 11:05:20 Thomas Kilgus [ac96eb]
fixed GetVtkProp and first tries to set interaction style in StdMultiWidget


2011-03-28 10:36:56 Thomas Kilgus [95b4bf]
some cleanup


2011-03-28 10:15:56 Thomas Kilgus [c0acf5]
Property is using opacity now


2011-03-28 10:06:44 Thomas Kilgus [e1c4d3]
Property is using LevelWindow now


2011-03-28 09:58:48 Thomas Kilgus [4507a4]
The vtkImage class is working with workarround for RenderTranslucent


2011-03-25 12:48:17 Thomas Kilgus [9af1b6]
added 0,0 to GetVtkImageData


2011-03-25 11:29:21 Thomas Kilgus [c8fbab]
Introduced classes by Gobbi


2011-03-05 18:55:46 Thomas Kilgus [242587]
local rendering changes. BUGGED


2011-03-03 13:47:35 Thomas Kilgus [4ba723]
Used 2D mappers and the ExtApp for display


2011-03-01 10:57:53 Thomas Kilgus [1d66b7]
3D Interactor aktiviert


2011-02-25 17:11:58 Thomas Kilgus [c8040b]
Step8 is able to render a slice of the input image in 2D by using VTK methods


2011-02-25 11:16:51 Thomas Kilgus [6aad61]
Displays a real image now which casted to unsigned char


2011-02-22 14:51:11 Thomas Kilgus [5de646]
Rendering mit VtkImageActor geht als 3D ansicht (mini klein)


2011-02-22 10:31:47 Thomas Kilgus [d9fa73]
Added contructor/destructor + first members


2011-02-21 16:03:26 Thomas Kilgus [d51410]
Created mitkImageVtkMapper2D class