Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2016

mersmann added projects to T8924: Removed mitkImageTest_4DImageData: MITK, Bugzilla.
Aug 2 2016, 9:47 AM · Bugzilla, MITK
mersmann added a comment to T8571: [Dashboard] NavigationToolReaderAndWriterTest cannot write scene files.

Reporter and assignee please comment whether this bug still occurs. Otherwise just close the bug!

Aug 2 2016, 9:46 AM · Bugzilla, MITK
mersmann added a comment to T8434: port basicImageProcessing and ColourImageProcessing bundle to ctk.

[12946c]: Merge branch 'bug-8434-portBundlesToCTK'

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added projects to T8434: port basicImageProcessing and ColourImageProcessing bundle to ctk: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to T8434: port basicImageProcessing and ColourImageProcessing bundle to ctk.

[862ccc]: Merge branch 'bug-8434-portBundlesToCTK'

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added projects to T8308: ImageStatisticsCalculator crashes on ignoring zero value voxels: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to F686: CIS+FPN+FPPN+Obj_RD500_MF-20_IT-500_500I_DistSeries_Mean.pic.

Test Image

Aug 2 2016, 9:45 AM
mersmann added a comment to T8308: ImageStatisticsCalculator crashes on ignoring zero value voxels.

Test Image

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to T8308: ImageStatisticsCalculator crashes on ignoring zero value voxels.

I checked the fix and it works now perfectly fine!
I'll close this bug.

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added projects to T8209: Develop dynamic extension checking for file writing: MITK, Bugzilla.
Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to T8209: Develop dynamic extension checking for file writing.

I guess this bug will be solved with Keno's start up project. I add Keno in CC so he can decide for dependencys or duplicate status.

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to T8162: new all-images predicate.

What is the current solution for this bug. Added RFD tag for next MITK meeting!
Actually there is a subclass of NodePredicateBase named mitk::TNodePredicateDataType< T > that is described to behave as you requested it:
Detailed Description
template<class T>
class mitk::TNodePredicateDataType< T >

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to T8147: Loading and writing of .mhd files leads to a different transform matrix.

We doublechecked the issue. We used the brain.mhd file provided in the test data repository in MITK (..\BINARY\MITK-build\CMakeExternals\Source\MITK-Data) with the following header imformation:

Aug 2 2016, 9:45 AM · Bugzilla, MITK
mersmann added a comment to T8108: DICOM tests fail on MacOS dart clients.

Re-assign to Andreas, removed titel tag [dashboard] for it is no longer a dashboard issue!

Aug 2 2016, 9:45 AM · MITK (2013-03), Bugzilla
mersmann added a comment to T8108: DICOM tests fail on MacOS dart clients.

reassign this bug to Thiago, for he already found a solution for this issue!

Aug 2 2016, 9:45 AM · MITK (2013-03), Bugzilla
mersmann added projects to T8030: Uninitialized member in mitkImageToOpenCvImageFilter class: MITK, Bugzilla.
Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T8030: Uninitialized member in mitkImageToOpenCvImageFilter class.

Changes done! Nice filter anyway!!

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T8030: Uninitialized member in mitkImageToOpenCvImageFilter class.

[a381cd]: Merge branch 'bug-8030-OpenCvImageFilter'

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added projects to T8000: GIPL image file format unsuitable for multiple component images: MITK, Bugzilla.
Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added projects to T7999: Missing FileReader for Stimulate Files (.spr): MITK, Bugzilla.
Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

[a017f7]: Merge branch 'bug-7897-SaveRGBImagesAsNRRD'

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

[686d1e]: Merge branch 'bug-7897-SaveRGBImagesAsNRRD'

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

Unit test is enhanced to test .nrrd file writing. During test execution another bug got obvious: The member variable m_FileName is changed iside the class when writung .pic files. The extension is appended to m_FileName. Once the extension changes, the .pic extension is still appended to the file name what leads to file names like fileName.pic.newExtension. This issue is fixed as well by not using the member variable to set the file name to the PicFileWriter.
The test uses an 3 component rgb image of filetype .jpg to test the class. The image is added to the mitk-data repository.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

Needs core modification flag!

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

I'll have a look at this!

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

Towards your question:

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7897: MITK crashes if you save an RGB image in .nrrd file format.

Manual test and unit test work well. Issue is fixed!

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7789: Check dartclient errors with ToFTests.

works now on continous client

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7789: Check dartclient errors with ToFTests.

[9f36b2]: Merge branch 'bug-7789-FailingTestsOnDashBoard'

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added projects to T7789: Check dartclient errors with ToFTests: MITK, Bugzilla.
Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7640: There are two variables for open cv in MITK.

The convention for cmake variable names have chaged. All MITK_USE_xxx variables should be written with with just a capital letter at the begin. I'll change that for OpenCV in the mitk-mbi repository.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7640: There are two variables for open cv in MITK.

Wron error diagnosis, the variable MITK_USE_OPENCV is already removed from all modules. In case the variable still occurs in the CMake GUI select it and press the Remove Entry button. After configuring the variable should be vanished.

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added a comment to T7523: Remove Kinect config from MITK repository.

[8b10f0]: Merge branch 'bug-7523-RemoveKinectConfig'

Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added projects to T7523: Remove Kinect config from MITK repository: MITK, Bugzilla.
Aug 2 2016, 9:44 AM · Bugzilla, MITK
mersmann added projects to T7264: mitk-ToF: Crash on Connect Camera: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added projects to T7261: mitk-ToF: Update of Integration Time sometimes leads to strange results: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added projects to T7239: Memory Leak in QmitkToFRecorderWidet: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T7239: Memory Leak in QmitkToFRecorderWidet.

[d023b5]: Merge branch 'bug-7239-QmitkToFRecorderWidgetMemoryLeak'

Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T7239: Memory Leak in QmitkToFRecorderWidet.

Works now, dash board is still green.

Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T7219: Identify C methods in mitk-ToF.
  • mitkToFCameraMITKPlayerController.cpp (fopen, fseek, fclose, fread)
  • mitkToFImageCsvWriter.cpp (fprintf, fopen/fopen_s, fclose)
  • mitkToFImageCsvWriterTest.cpp(fscanf)
  • mitkToFImageWriter.cpp (fopen/fopen_s, fwrite, fclose, fseek)
Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added projects to T7219: Identify C methods in mitk-ToF: MITK, Bugzilla.
Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T7212: [Dashboard] mitkImageTest fails due wrong StandardFileLocations search.

Changed mitkImageTest to use argv to pass the test data to the test.
Need core modification flag!

Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T7212: [Dashboard] mitkImageTest fails due wrong StandardFileLocations search.

Changed mitkImageTest to use argv to pass the test data to the test.
Need core modification flag!

Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T7212: [Dashboard] mitkImageTest fails due wrong StandardFileLocations search.

[0a0c69]: Merge branch 'bug-7212-ImageTestStandardFileLocationRemoval'

Aug 2 2016, 9:43 AM · Bugzilla, MITK
mersmann added a comment to T6455: Memory leak in mitkOpenCVToMitkImageFilter.

[SVN revision 28606]
FIX (#6455): Delete CVImage after use.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6455: Memory leak in mitkOpenCVToMitkImageFilter.

Delete cvImage after use is finished.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6455: Memory leak in mitkOpenCVToMitkImageFilter.

Delete cvImage after use is finished.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added projects to T6455: Memory leak in mitkOpenCVToMitkImageFilter: MITK, Bugzilla.
Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6406: blueberry tests do not run on MAC OS.

Reporter and assignee please comment whether this bug still occurs. Otherwise just close the bug!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6406: blueberry tests do not run on MAC OS.

Reporter and assignee please comment whether this bug still occurs. Otherwise
just close the bug!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6406: blueberry tests do not run on MAC OS.

removed the [dashboard] tag for this is no longer a dasboard issue!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

No comments or reported problems since two week. I close this back as fixed!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Reset CoreModificationFlag, for mitk::SlicedData class also need a copy constructor. The ChangeRequest was adapted to include the changes in mitk::SlicedData.
Branch of bug-8646 was merged to the bug branch and the modifications were tested again.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

[7f0de0]: Merge branch 'bug-6338-BaseDataCloneM'

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

[662c0b]: Merge branch 'bug-6338-BaseDataCloneM'

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Marco an d I decided that inside this bug implementing the clone methods for a selection of base data subclasses is sufficient. Implementing the other is pretty easy and can be done on demand (by the one who needs it!).

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Enhanced mitkUnstructuredGridTest by clone method tests, added clone method to mitkImage and added some clone method tests to mitkImageTest

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Core modification flag needed, change request was written. All other base data subclasses can get a clone method on demand.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Last week surface test of clone method was finished, next class and test will be unstructured grid

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

As the result from the discussion, I implement a macro in mitkCommon.h providing a clone method for base data cloning. This clone macro can be set into the base data subclasses if cloning is reasonable.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

ITK do not use any deep copy methods. As Michael suggested a virtual method in BaseData would be nice, nevertheless using a pure virtual method is not nice. Several subclasses derived from BaseData are objects where copying the data is not sensible (e.g. mitkGradientBackground, mitkManufacturerLogo...). For those classes implementing a copy method would be unneccessary and misleading for the user.
One suggestion is to implement a virtual method with a warning when it is called but not implemented. Another suggestion is to subclass data objects where copying is sensible (surface, pointset, image...) and implement a pure virtual copy method there.

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Removed RFD tag for discussion is finished!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6338: mitk::Surface needs clone method.

Tested clone method for mitk::Image and added them to mitk::PointSet and mitk::Contour. Furthermore some test cases were added to the unit tests!

Aug 2 2016, 9:42 AM · Bugzilla, MITK
mersmann added a comment to T6296: [Dashboard] mitkImageToOpenCVImageFilterTest failed.

This is my dartclient I take care of it!

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6296: [Dashboard] mitkImageToOpenCVImageFilterTest failed.

Wrong path to OpenCV set in batch file!

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added projects to T6252: Context menu in tool bar: MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6231: Command window missing.

THis bug seems to be deprecated for the command window is available again!

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added projects to T6231: Command window missing: MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

[0c8b16]: Merge branch 'bug-6228-UseToFDevices'

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

Resetting product to MITK

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

No, some are still in use and should remain in the repository!

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

[9e6758]: Merge branch 'bug-6228-UseToFDevices'

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

Necessary classes are moved to open source part, all other dependencies can be kept. Set bug to resolved

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

[2f4039]: Merge branch 'bug-6228-UseToFDevices'

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6228: Use new ToF infrastructure for ToF classes.

Those classes are for or under development, therefore they are not deprecated, but won't be moved to open source part!

Aug 2 2016, 9:41 AM · Bugzilla, MITK
mersmann added a comment to T6062: Orientation incorrectly read by ItkImageFileReader for 3D images with only one slice.

This issue was fixed in T11115. Hence, I close this bug.

Aug 2 2016, 9:41 AM · MITK (2013-03), Bugzilla
mersmann added projects to T5047: Build and test OpenCV 2.1: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
mersmann added a comment to T5047: Build and test OpenCV 2.1.

I moved the x32 Version to toolkits repository. Ingmar the x64 one. Dartclients are doing fine. The bug is resolved

Aug 2 2016, 9:39 AM · Bugzilla, MITK
mersmann added projects to T4767: Build ITK 3.20: MITK, Bugzilla.
Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4767: Build ITK 3.20.

Moved ITK 3.20 to T:Toolkits.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4667: Method to perform index to world transform.

[SVN revision 25359]
ENH (#4667): added classes for index to world transform for surface and pointset objects. Moved PointSetToPointSetFilter to mitk/core/code/Algorithms

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to F557: Bug4667.patch.

Patch

Aug 2 2016, 9:38 AM
mersmann added projects to T4667: Method to perform index to world transform: MITK, Bugzilla.
Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4667: Method to perform index to world transform.

Filter classes implemented and tested in bundle ToFRegistration. Change request written.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4667: Method to perform index to world transform.

Patch

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4667: Method to perform index to world transform.

Function should not be implemented in the data classes but within a seperate filter. Create Filter mitk::PointSetIndexToWorldTransformFilter and mitk::SurfaceIndexToWorldTransformFilter

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4347: EuclideanDistanceTo fails for the PlanarCross figure in the PlanarFigureIOTest.

Is this bug resolved? No failed tests on my system!

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added a comment to T4181: Dynamic file extension retriever for ITK supported formats.

Hello Sven,
thank you for the patch,it looks really good. The actual way of setting up a hard coded list of possible file extensions is pretty bad, nevertheless we currently need it that way, for we decided not to support all possible file formats from itkImageIO. Using the proposed factory would overwrite the not supported formats and add them again to the extension list. Furthermore the used mitk::FileWriter extensions should also be handled dynamically.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
mersmann added projects to T4162: itkImageSeriesWriter deprecated since ITK 3.16: MITK, Bugzilla.
Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4162: itkImageSeriesWriter deprecated since ITK 3.16.

[SVN revision 23796]
CHG (#4162): the numeric file name function in itkImageSeriesWriter has been replaced by the function in the class itkNumericSeriesFileNames

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4162: itkImageSeriesWriter deprecated since ITK 3.16.

changes made according to change request. Please verify change request

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4146: Status bar should be visibility dependent.

now with Change Request! :-)

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4146: Status bar should be visibility dependent.

I'll implement it as proposed

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added projects to T4146: Status bar should be visibility dependent: MITK, Bugzilla.
Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4146: Status bar should be visibility dependent.

[SVN revision 23977]
ENH (#4146): enhanced method ExecuteAction() by check for node visibility to get StatusBar pixel information from currently visible node.

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4013: Allow Visual Studio Express compilation.

I tried to compile MITK with Visual Studio Express 2010. An Error (D8030 internal compiler errror) occurred. This error is an VSE specific error for projects build with /MT (multi threaded) flag set as MITK is. A fix for this MSVC Bug is provided only for commercial version of Visual Studio 2010 and not for the Express version.
We are sorry but this bug will not be fixed, for Visual Studio Express is not officially supported!

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T4013: Allow Visual Studio Express compilation.

Actually nobody at mbi uses Visual Studio Express Version, as a first step to reproduce this bug, I download acopy of VS Express 2010 and create a dart client with this IDE.

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T3999: Make SimplexMesh Segmentation available again.

This project is too bulky for bug squashing. If it is needed make a start up project out of it!

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to T3999: Make SimplexMesh Segmentation available again.

I'll port that to QT4

Aug 2 2016, 9:37 AM · Bugzilla, MITK
mersmann added a comment to F526: ErrorPosition+CallStack.jpg.

BreakPosition+CallStack

Aug 2 2016, 9:37 AM