Github pull request: https://github.com/MITK/MITK/pull/20
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 2 2016
Aug 2 2016
nocnokneo added a comment to T15892: SlicedGeometry3D does not reorient slices about correct center.
nocnokneo added a comment to T15778: SerialCommunication feature request: Read() until EOL, Send() and block until transmitted.
Branch with implementation for POSIX only (I don't have a WIN32 development environment):
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
Hi Sebastian,
nocnokneo added a comment to T15778: SerialCommunication feature request: Read() until EOL, Send() and block until transmitted.
New remote branch pushed: bug-15778-SerialCommunication-ReadToEOLAndBlockOnSend
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
Hi Alfred,
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
That's right - in ObliqueAxial and ObliqueSagittal slice view modes (which, BTW, the updated pull request calls InlineAxial and InlineSagittal to be more consistent with industry conventions) the slicing plane will not be correct. But the fix should not be a big deal, I'll drop the change to SlicedGeometry3D that I have in my MITK fork and get this filter working the right way before updating the github pull request.
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
I actually have several improvements and bug fixes for this filter since I last submit the pull request. I'll get the pull request updated with those changes tomorrow morning. Would it mess up anyone if I rebased, squashed, and force-pushed to the Github pull request branch?
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
Oh yes... this currently does need a core modification - but it shouldn't. Right now this filter depends on the change that was proposed in T15892 but was (correctly) deemed invalid by Bastian.
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
I've made a few more fixes locally, but also some feature enhancements. I'll need to get approval before I can contribute the feature enhancements. If there's no rush, it might make sense to hold off integrating this.
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
Hi Alfred,
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
Just FYI, I updated again the pull request again with another fix (NPE).
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
Github pull request: https://github.com/MITK/MITK/pull/19
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
New remote branch pushed: bug-15777-add-NavigationDataSliceVisualization
nocnokneo added a comment to T15775: QmitkSliceWidget::SetData ignores DataNode parameter and clobbers the names of DataNodes in the DataStorage.
Github pull request: http://github.com/MITK/MITK/pull/16
nocnokneo added a comment to T15777: New feature: Control the position and orientation of rendered slices with NavigationData.
FYI, I've updated the pull request with some fixes/improvements.
Great, thanks. Let me know if you'd like me to rebase my pull request on the current MITK master.
nocnokneo added projects to T15768: Uninitiated member in vtkMitkLevelWindowFilter class: MITK, Bugzilla.
nocnokneo added projects to T15769: Image::PrintSelf() incorrectly prints BitsPerElement: MITK, Bugzilla.
Github pull request: https://github.com/MITK/MITK/pull/18
Github pull request: https://github.com/MITK/MITK/pull/14
nocnokneo added projects to T15759: Make visualization of edges on Geometry2D data configurable: MITK, Bugzilla.
No problem, I figured it was something like that. I can see from the number of GitHub pull requests that it's not frequently used process.
Github pull request: https://github.com/MITK/MITK/pull/13
nocnokneo added projects to T15746: Normalize the orientation Quaternion in VirtualTrackingDevice: MITK, Bugzilla.
nocnokneo added a comment to T15745: TransferItkTransformToVtkMatrix leaves homogeneous row uninitialized.
Github pull request: https://github.com/MITK/MITK/pull/12
New remote branch pushed: bug-15715-Tooltip-computation-is-buggy
I updated the pull request with some other bugs I found in InternalTrackingTool - I figured they all sort of fall under the description of "Tooltip computation is buggy"
New remote branch pushed: bug-15715-FixTooltipComputation
Github pull request: http://github.com/MITK/MITK/pull/17
Some more details on this bug:
A readers/writer lock would be ideal for best performance, but ITK doesn't seem to provide one (at least not yet...). See this ongoing thread:
Could you support cmake -DLIB_SUFFIX=64 ...? I know it seems a bit klugey, but this is the established convention in the CMake community for dealing with systems like my 64-bit box (a RHEL6 derivative) where libraries installed to /usr/lib64. Thanks!