Page MenuHomePhabricator

morency (Félix C. Morency)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (414 w, 4 d)

Recent Activity

Aug 2 2016

morency added a comment to T19040: Coronal picking OS X.

+1. Major issue for us.

Aug 2 2016, 10:20 AM · MITK (2015-03), Bugzilla
morency added projects to T18377: Paintbrush cursor refresh issue: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · Bugzilla, MITK
morency added a comment to T17434: 3D interpolation produces strange results depending on image spacing.

This is a major issue for us. The segmentation module is unusable with 2014.10.
-F

Aug 2 2016, 10:11 AM · Bugzilla, MITK
morency added projects to T16117: Add print(er) support: MITK, Bugzilla.
Aug 2 2016, 10:07 AM · Bugzilla, MITK
morency added a comment to T15468: Flexible StdMultiWidget corner annotation.

I was thinking on fixing this issue by implementing a system similar to the one used for changing the DepartmentLogo (ie. by using IBerryPreferences). Any thoughts on that?

Aug 2 2016, 10:04 AM · MITK (2016-11), Bugzilla
morency added projects to T15468: Flexible StdMultiWidget corner annotation: MITK, Bugzilla.
Aug 2 2016, 10:04 AM · MITK (2016-11), Bugzilla
morency added a comment to T15389: Application crash when enabling Python.

The core dump can be retrieved from

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
morency added a comment to T15389: Application crash when enabling Python.

I just tested it with b6576a5dcafc90bf6d181e3f54bf09df02517e02 + patch and it still crashes here. The core dump looks the same.

Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
morency added projects to T15389: Application crash when enabling Python: MITK, Bugzilla.
Aug 2 2016, 10:04 AM · MITK (2013-09), Bugzilla
morency added a comment to T15355: Negative spacing set to 1.0.

Patch to address the negative spacing

Aug 2 2016, 10:04 AM · Bugzilla, MITK
morency added a comment to F1004: b53e24e1e23971f64493160d874525e9e27df387.patch.

Patch to address the negative spacing

Aug 2 2016, 10:04 AM
morency added projects to T15341: PythonQt compilation error when enabling Python: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F1003: 0001-Fix-PythonQt-related-compilation-error.patch.

Patch that fixes the compilation error

Aug 2 2016, 10:03 AM
morency added projects to T15280: Invalid OutsideValue for BoundingObjectCutter when using AutoOutsideValue: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Auto-closed, Bugzilla, MITK
morency added a comment to T15280: Invalid OutsideValue for BoundingObjectCutter when using AutoOutsideValue.

I forgot to mention that we can't assign the computed outside value directly to m_OutsideValue because m_OutsideValue is stored as a mitk::ScalarType and TOutputPixel can be double which would result in an invalid value.

Aug 2 2016, 10:03 AM · Auto-closed, Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

Thanks for pointing that out.

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

Thanks for working on that!

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

FYI, I can confirm that our code works when using GrabItkImageMemory instead of ImportItkImage. Again, thanks for working on that.

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

This is where the fun begins.

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

The unit test files.cmake

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

Overlay ground truth #1

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F996: files.cmake.

The unit test files.cmake

Aug 2 2016, 10:03 AM
morency added a comment to F995: DirectOverlayTest.cpp.

The unit test

Aug 2 2016, 10:03 AM
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

The test image

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

Overlay ground truth #2

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F994: 9x9x9_Overlay2.nrrd.

Overlay ground truth #2

Aug 2 2016, 10:03 AM
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

@Jan: The test you wrote passes, but the problem is still present. Here's the code causing problem on our side:

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F993: 9x9x9_Overlay1.nrrd.

Overlay ground truth #1

Aug 2 2016, 10:03 AM
morency added a comment to T15093: Broken ImportItkImage following ITK4 migration.

The unit test

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F992: 9x9x9.nrrd.

The test image

Aug 2 2016, 10:03 AM
morency added projects to T15093: Broken ImportItkImage following ITK4 migration: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F987: 2012_12_orig.png.

2012.12 original

Aug 2 2016, 10:03 AM
morency added projects to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03: MITK, Bugzilla.
Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F989: 2013_03_orig.png.

2013.03 original

Aug 2 2016, 10:03 AM
morency added a comment to F991: toy_999.nrrd.

Original test image

Aug 2 2016, 10:03 AM
morency added a comment to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03.

2012.12 moved

2012_12_move.png (873×948 px, 13 KB)

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03.

2013.03 original

2013_03_orig.png (880×880 px, 14 KB)

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03.

2013.03 move

2013_03_move.png (874×1 px, 14 KB)

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F990: 2013_03_move.png.

2013.03 move

Aug 2 2016, 10:03 AM
morency added a comment to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03.

Original test image

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03.

The bug seems resolved in 2013.06

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to F988: 2012_12_move.png.

2012.12 moved

Aug 2 2016, 10:03 AM
morency added a comment to T15057: mitkBoundingObjectCutter behavior changed from 2012.12 to 2013.03.

Nevermind my previous comment, it's still there. The issue seems to come from the lines

Aug 2 2016, 10:03 AM · Bugzilla, MITK
morency added a comment to T14924: Add support for header offset in RawImageFileReader.

[1]: http://www.itk.org/Doxygen320/html/classitk_1_1RawImageIO.html

Aug 2 2016, 10:02 AM · Auto-closed, Bugzilla, MITK
morency added projects to T14924: Add support for header offset in RawImageFileReader: MITK, Bugzilla.
Aug 2 2016, 10:02 AM · Auto-closed, Bugzilla, MITK
morency added a comment to T14711: Volume visualization inoperable..

I can confirm this bug under Linux and Windows with latest master (9f0c858a54cd48f7cc050762e66e005328865be7).

Aug 2 2016, 10:01 AM · MITK (2013-03), Bugzilla
morency added a comment to T14652: Level window is nearly unusable if the image range is very small.

This is a big problem for us. +1

Aug 2 2016, 10:01 AM · MITK (2016-11), Bugzilla
morency added projects to T14392: FitGeometry never set back ChangeImageGeometryConsideringOriginOffset: MITK, Bugzilla.
Aug 2 2016, 10:00 AM · Bugzilla, MITK
morency added a comment to F947: toy_999.nrrd.

Toy 9x9x9 image

Aug 2 2016, 10:00 AM
morency added a comment to T14024: 3D regiongrowing is not working for binary images.

I noticed that the region growing provided by the Step6 MITK tutorial seems to have a different behaviour.

Aug 2 2016, 10:00 AM · Bugzilla, MITK
morency added projects to T13999: Incorrect RegionGrowing behavior on 4D data: MITK, Bugzilla.
Aug 2 2016, 10:00 AM · Bugzilla, MITK
morency added a comment to T13999: Incorrect RegionGrowing behavior on 4D data.

I pushed my branch on Github [1] if you want to see/test the 4D region growing. All the tests pass so far.

Aug 2 2016, 10:00 AM · Bugzilla, MITK
morency added a comment to T13999: Incorrect RegionGrowing behavior on 4D data.

I managed to make the region growing work in 4D with minor code modification.

Aug 2 2016, 10:00 AM · Bugzilla, MITK
morency added a comment to T13953: Crash on 4D data cropping.

@Joseph: The crash still occurs with the current master. I attached a screenshot showing the location of the bounding box. I will email you a link to the dataset used for testing.

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to T13953: Crash on 4D data cropping.

I can confirm that the bug is fixed with the current bug branch

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to T13953: Crash on 4D data cropping.

Crop selection

cropSelection_20130109_01.png (1×1 px, 193 KB)

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to T13953: Crash on 4D data cropping.

@Joseph, Do you need an official pull request on Github or if you can manage to merge the workaround from the link to my branch?

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to F936: cropSelection_20130109_01.png.

Crop selection

Aug 2 2016, 9:59 AM
morency added projects to T13949: Bounding object not displayed with 4D data: MITK, Bugzilla.
Aug 2 2016, 9:59 AM · Bugzilla, MITK
morency added a comment to T13953: Crash on 4D data cropping.

I made a WIP branch on my Github [1]. I'm not sure that the fix is good since the data hold by the ImageDataItemPointer needs to be cleared at some point and I'm not sure it is if we change the data type to a standard pointer. This needs to be investigated but I'm running after time at the moment. Any suggestions are welcome.

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to T13953: Crash on 4D data cropping.

Here's some more info...

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to T13953: Crash on 4D data cropping.

The problem comes from the line

Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added projects to T13953: Crash on 4D data cropping: MITK, Bugzilla.
Aug 2 2016, 9:59 AM · MITK (2013-03), Bugzilla
morency added a comment to T13949: Bounding object not displayed with 4D data.

Patch released, see

Aug 2 2016, 9:59 AM · Bugzilla, MITK
morency added a comment to F918: 0001-Fix-crash-from-DataManager-potential-invalid-pointer.patch.

Fix the issue

Aug 2 2016, 9:58 AM
morency added a comment to T13538: Crash from datamanager if non-rendering editor is diplayed.

Please comment on the fix

Aug 2 2016, 9:58 AM · MITK (2012-12), Bugzilla
morency added projects to T13538: Crash from datamanager if non-rendering editor is diplayed: MITK, Bugzilla.
Aug 2 2016, 9:58 AM · MITK (2012-12), Bugzilla
morency added a comment to T13499: Possible crash caused by unremoved observer in mitkLevelWindowManager.

Patch has been submitted on Github.

Aug 2 2016, 9:58 AM · MITK (2013-03), Bugzilla
morency added a comment to T13499: Possible crash caused by unremoved observer in mitkLevelWindowManager.

Is it possible for me to contribute directly to the new branch (if needed)? Branches don't seem synced on the Github repository.

Aug 2 2016, 9:58 AM · MITK (2013-03), Bugzilla
morency added projects to T13499: Possible crash caused by unremoved observer in mitkLevelWindowManager: MITK, Bugzilla.
Aug 2 2016, 9:58 AM · MITK (2013-03), Bugzilla
morency added a comment to T13431: mitk::DataNodeFactory with DICOM files behaviour.

One problem I see with Andreas' solution is the lack of consistency for the file opening action. For example, I like the fact that I can drag'n'drop files from my file explorer to the MITK data manager and MITK automatically creates expected nodes. I'm curious to know how you could achieve this behavior with the DICOM editor?

Aug 2 2016, 9:58 AM · Bugzilla, MITK
morency added projects to T13251: Tutorial Step 09 build error: MITK, Bugzilla.
Aug 2 2016, 9:58 AM · Bugzilla, MITK
morency added a comment to T13180: QmitkProgressBar is messing around with qt event loop.

FYI, our application becomes unusable (linux) and/or crashes (windows) and we think it is because of this bug. As Sascha pointed out, the same operation can be started again.

Aug 2 2016, 9:57 AM · MITK (2013-12), Bugzilla
morency added a comment to T11676: Provide a filter for combining set of 3D Volumes to a 4D Image.

I came across a post [1] about the use of the itk::CastImageFilter to make a 4D dataset from multiple 3D dataset. Would it be possible to use this?

Aug 2 2016, 9:53 AM · Bugzilla, MITK
morency added a comment to T11570: ExtractDirectedPlaneImageFilterNew might have a 0.5 offset.

I can confirm this issue. It still happens on 2012.12 and 2013.03.

Aug 2 2016, 9:52 AM · Bugzilla, MITK
morency added a comment to T11406: mitkBoundingObject geometry is weird.

At the line

Aug 2 2016, 9:52 AM · Bugzilla, MITK