Page MenuHomePhabricator
Create Task
Maniphest T18025

Filtering nodes in data manager using QSortFilterProxyModel
Closed, ResolvedPublic
Actions

Description

It would make sense to filter the nodes shown in data manager by actually filtering the model using QSortFilterProxyModel instead of modifying the model itself. This would also add more flexibility in filtering as well as fix some problems in layer assignment for nodes that are filtered out.

Related Objects
Search...

Event Timeline

khlebnikov added projects: MITK, Bugzilla.Aug 17 2014, 5:05 PM
muellerm added a subscriber: muellerm.Aug 28 2014, 11:13 AM

currently reviewing changes

• git-user added a subscriber: • git-user.Aug 28 2014, 11:27 AM

User muellerm has pushed new remote branch:

bug-18025-Filtering-nodes-in-data-manager-using-QSortFilterProxyModel-revised
• git-user added a comment.Aug 28 2014, 2:25 PM

User muellerm has pushed new remote branch:

bug-18025-Filtering-nodes-in-data-manager-using-QSortFilterProxyModel-on-master
muellerm added a comment.Aug 28 2014, 2:50 PM

[a3b0d7]: Merge branch 'bug-18025-Filtering-nodes-in-data-manager-using-QSortFil

Merged commits:

2014-08-28 14:45:21 Michael Mueller [2fd74f]
incorporated QmitkDataStorageFilterProxyModelD

2014-08-28 14:35:34 Michael Mueller [dd37c7]
added filter model but inactive in datamanager view

2014-08-28 14:28:22 Michael Mueller [ac0434]
removed usage of Predicates in TreeModel (i.e. uses all nodes in DS)

2014-08-28 14:21:41 Michael Mueller [c9776a]
added FilterProxyModel
Fixed selection index

zelzer added a subscriber: zelzer.Aug 28 2014, 9:47 PM

[7f6d8a]: Merge branch 'bug-18025-Filtering-nodes-in-data-manager-using-QSortFil

Merged commits:

2014-08-28 21:42:35 Sascha Zelzer [7b37f1]
COMP: Removed C++11 keyword

• git-user added a comment.Sep 23 2014, 4:17 PM

User hering has pushed new remote branch:

bug-18025-Fix-Invalidation-FilterModel
• goch added a subscriber: • goch.Sep 25 2014, 6:45 PM

[98076e]: Merge branch 'bug-18025-Fix-Invalidation-FilterModel'

Merged commits:

2014-09-23 16:12:04 Jan Hering [f5963d]
Invalidate FilterModel correctly

  • change as proposed by R. Khlebnikov
metzger added a subscriber: metzger.Oct 7 2014, 2:04 PM

What is the status of this bug?

muellerm added a comment.Oct 9 2014, 5:53 PM

still open ... rotislav posted another issue on Sep, 02.
i will have a look at it and post the changes here

khlebnikov added a subscriber: khlebnikov.Oct 9 2014, 6:15 PM

Hi, the bug with deleting/reordering nodes was fixed and integrated into master - see https://github.com/MITK/MITK/blob/master/Plugins/org.mitk.gui.qt.datamanager/src/QmitkDataManagerView.cpp - lines 901-906.

muellerm added a comment.Oct 9 2014, 6:16 PM

yeah i saw it just at that moment, sorry, i am not always up to date

• hering mentioned this in T18092: Crash on deleting planar figures from DataManager.Sep 23 2014, 4:21 PM
• goch mentioned this in T18104: Crash on moving data nodes.Sep 24 2014, 2:02 PM
kislinsk merged a task: T17795: Crash when reordering nodes in DataManager.Aug 1 2016, 10:47 PM
kislinsk merged a task: T18104: Crash on moving data nodes.
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ