Page MenuHomePhabricator | MITK

Dicom editor can not load dicom segmentation objects
Open, HighPublic

Description

When parsing dicom folders which contain dicom segmentation objects they will be correctly listed. However if double clicked MITK will crash.

This seems to be happening in

void DicomEventHandler::OnSignalAddSeriesToDataManager(const ctkEvent& ctkEvent)

where a couple of special cases are handled and then a default reader selection is used instead of using mime types.

Event Timeline

goch created this task.Sep 4 2017, 4:45 PM
goch added a subscriber: hentsch.
floca added a subscriber: floca.Sep 4 2017, 9:10 PM

What about this task? Could we add these changes to the master branch?

Probably, the dicom folder read implementation was a bit cobbled together and could probably use some more thought.

floca added a comment.Nov 23 2017, 4:05 PM

I would have (minor) concerns with directly merging it. The comments raised for the last commit.

goch removed goch as the assignee of this task.Apr 18 2018, 1:09 PM
nolden edited projects, added MITK (2018-04); removed MITK.Aug 6 2018, 4:14 PM
nolden assigned this task to metzger.
nolden added subscribers: kislinsk, nolden.

I would have (minor) concerns with directly merging it. The comments raised for the last commit.

I agree with Ralf's concerns. If I oversee this correctly we could merge this without changing the node naming convention. @kislinsk : would be great to have this in the release. It's actually a crash.

metzger reassigned this task from metzger to kislinsk.Aug 23 2018, 4:18 PM

It's not clear to me if this mergable as-is or not?

It's not clear to me if this mergable as-is or not?

In my opion not. But I can help to patch it that way.

floca added a comment.Fri, Sep 21, 2:39 PM

As far as I can see (had to dig through the commits) All changes of this branch, have already been cherry picked to the master at some point. (Don't know if they are also already in the current beta brunch).

My complaints have been fixed in context of T25441: Name DataNodes with DICOM data appropriately by using dicom tags, that I will now merge into the master.
Thus I would propose to close this task. Availablilty in the beta must still be checked, if wanted.