Page MenuHomePhabricator
Create Task
Maniphest T2655

3M3 Version of Measurement tools
Closed, ResolvedPublic
Actions

Related Objects
Search...

StatusAssignedTask
 ResolvedNoneT2494 META: Create usable end-user application / demo (3M3)
 ResolvedNoneT2655 3M3 Version of Measurement tools
 ResolvedNoneT2964 PlanarRectangle sometimes slightly misaligned
 ResolvedNoneT3234 Measurement focus problem
 ResolvedNoneT3225 Redesign QmitkFunctionality/Basic GUI Module concept
 InvalidNoneT3085 VTK warning issued when calculating statistics for zero-size PlanarFigure
 ResolvedNoneT3033 Measurement: Paths are displayed with polygon icon in DataManager
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedNoneT3032 When selecting multiple PlanarFigures, not all are visualized as selected (red)
 ResolvedNoneT3059 Use different default color for PlanarFigure lines and markers?
 DuplicateNoneT2762 Calculation of image statistics
 ResolvedNoneT2986 "Closed" state of PlanarPolygon is not correctly restored when loading
 ResolvedNoneT3155 Non-closed PlanarPolygons wrongly return "Circumference" instead of "Length" as feature name
 ResolvedNoneT2797 Implement PlanarRectangle
 ResolvedNoneT2963 Interaction with PlanarFigures should always (but only) work in QmitkMeasurement
 ResolvedNoneT3039 Measurement: The area of polygon figure is negative
 ResolvedNoneT2997 Figure List should be updated when nodes change
 ResolvedNoneT3031 Issue notification when PlanarFigure changes
 ResolvedNoneT3034 Path Measurement
 ResolvedNoneT2796 Imlement PlanarFourPointAngle
 ResolvedNoneT2791 Allow PlanarFigur representations to consist of multiple PolyLine
 ResolvedNoneT3011 Polygons do not throw initialized event
 ResolvedNoneT2916 Enable dragging of control points
 ResolvedNoneT3062 Ensure consistent 2D geometry usage in QmitkMeasurement
 ResolvedNoneT2795 Make sure that PlanarFigures can be re-discovered in a scene
 DuplicateNoneT3036 Jump out of figure buttons
 ResolvedNoneT2943 Measurement view: can not activate tools other than line
 ResolvedNoneT2760 Serialization of Planar Figures
 ResolvedNoneT2794 Improve performance of PlanarFigure handling
 ResolvedNoneT2881 PlanarCircles are distorted in anisotropic images
 ResolvedNoneT2993 if you click on a tool, message: "None selected..." is display
 WontfixkislinskT2792 Extend PlanarFigure interactor to allow point adding/removal
 ResolvedNoneT2684 Measurement documentation
 ResolvedNoneT3043 When the center point of a circle is moved the boundaryPoint should be moved as well
 ResolvedNoneT2857 Correct initialization of PlanarFigures
 ResolvedNoneT2759 Create TableView with Measurement info
 ResolvedNoneT3086 When adding new PlanarFigure, QmitkMeasurement jumps to slice of currently selected PlanarFigure
 ResolvedNoneT2793 Extend PlanarFigure interface to allow retrieval of feature measurements
 ResolvedNoneT2972 Calculation of 4 Point Angle is wrong
 ResolvedNoneT3012 PlanarFigure TextBrowser is not updated when control points are moved
 ResolvedNoneT2985 PlanarFigureInteractor should issue event when figure placement is completed
 ResolvedNoneT2947 PrintSelf() of PlanarFigure subclasses repeats information

Event Timeline

muellerm added projects: MITK, Bugzilla.Oct 13 2009, 4:21 PM
muellerm added a subscriber: muellerm.Oct 13 2009, 4:31 PM

[SVN revision 19466]
ENH (#2655): Added first changed version of the 3M3 Measurement tools

• goch added a subscriber: • goch.Oct 14 2009, 5:33 PM

Requirements:

  • Ellipsoids (circles as special case)
  • Rectangles (squares as special case)
  • Lines
  • 3-point angles
  • 4-point angles
  • Polygons
  • ...

Design to be discussed...

seitelm added a subscriber: seitelm.Oct 16 2009, 1:40 PM

Requirements specified on wiki specification page

http://mitk.org/wiki/ChangeRequests/2655

muellerm added a comment.Oct 16 2009, 1:41 PM

very nice!

seitelm added a comment.Oct 21 2009, 2:21 PM

[SVN revision 19602]
ENH (#2655): Basic implementation of planar figures data and rendering classes

• mersmann added a subscriber: • mersmann.Oct 22 2009, 8:13 AM

[SVN revision 19615]
ENH (#2655): Add classes for planar figure measurement

seitelm added a comment.Oct 22 2009, 8:41 PM

[SVN revision 19645]
ENH (#2655): Implemented interactive placement and editing for PlanarFigure objects

seitelm added a comment.Oct 22 2009, 8:44 PM

Requesting core modification to commit changes in StateMachine.xml

seitelm added a comment.Oct 22 2009, 8:47 PM

[SVN revision 19646]
COMP (#2655): Corrected invalid method declaration syntax

seitelm added a comment.Oct 22 2009, 8:52 PM

[SVN revision 19647]
COMP (#2655): Added PlanarFigureInteractor (for 2D measurements via PlanarFigure objects)

seitelm added a comment.Oct 23 2009, 11:40 AM

[SVN revision 19673]
ENH (#2655): Now supporting closed and open polygons

seitelm added a comment.Oct 23 2009, 11:40 AM

[SVN revision 19674]
FIX (#2655): Removed slight misbehavior in PlanarFigureInteractor

seitelm added a comment.Oct 23 2009, 11:41 AM

[SVN revision 19675]
ENH (#2655): Improved behavior of PlanarFigureInteractor

seitelm added a comment.Oct 23 2009, 11:42 AM

[SVN revision 19676]
ENH (#2655): Now PlanarFigure objects are attached to the selected (image) node, and thus are visible on top of it (new layer management)

muellerm added a comment.Oct 23 2009, 11:47 PM

[SVN revision 19699]
ENH (#2655): Added additional Icons, added TableView for showing Measurement results (not implemented yet)

muellerm added a comment.Nov 6 2009, 2:34 PM

[SVN revision 19920]
FIX (#2655): - Added TableModel for showing PlanarFigures and related values

  • Added: Automatic naming scheme for new PlanarFigures
  • Added: Copy Paste support for excel
  • Removed Window toolbar, readded to view
• rietdorf added a subscriber: • rietdorf.Nov 9 2009, 3:08 PM

I need this tool for my work. Please make sure that it is still possible to measure a simple distance! That was the reason to build this program. A simple, not overloaded tool to measure a distance and an angle. And not only in transversal plane. I need to measure transversal, coronal and sagital. I don't know why someone has to "draw" 4-Point-Angles, Arrows and Text-Tools. In my mind it is to much. But now I can't go on with my work because I simply need to measure a distance in the saggital view that I can't see.
And because I don't want to read pages of manuals only to measure a distance, please: would it be possible to rename this module to "Extended drawing and measurement on transversal plane with many geometric objects, arrows and text-tools" and give back the old "measurement" tool to me?
One really useful extension for this simple tool would be a ruler at the sides. But the rest could be kept still simle and easy to use.

• goch added a comment.Nov 9 2009, 3:46 PM

A current work around for this problem is to rotate the transversal plane in the desired orientation before loading the measurement functionality via the crosshair rotation mode.
It is definitely planned to extend the new measurement funtionality to support measuring in different planes.

muellerm added a comment.Nov 10 2009, 9:22 AM

[SVN revision 19981]
FIX (#2655): - A PlanarFigures selected property gets toggled when selected in Planar Figure table

  • Selected Planar Figures are painted in red
seitelm added a comment.Nov 11 2009, 12:12 PM

[SVN revision 20027]
ENH (#2655): Added const version of GetPolyline()

seitelm added a comment.Nov 11 2009, 5:17 PM

[SVN revision 20042]
ENH (#2655): Use drag and drop to move control points of PlanarFigures (instead of two consecutive clicks)

muellerm added a comment.Nov 11 2009, 5:24 PM

[SVN revision 20046]
ENH (#2655): "selected" property of selected Figures are set appropriately

muellerm added a comment.Nov 11 2009, 5:29 PM

[SVN revision 20047]
ENH (#2655): Added Measurement perspective

muellerm added a comment.Nov 11 2009, 5:31 PM

[SVN revision 20048]
ENH (#2655): Added measurement icon

muellerm added a comment.Nov 12 2009, 4:27 PM

[SVN revision 20089]
FIX (#2655): Restored old measurement functionality as "org.mitk.gui.qt.simplemeasurement"

neuhaus added a subscriber: neuhaus.Nov 13 2009, 4:47 PM

[SVN revision 20131]
FIX (#2655): set state of DrawFourPointAngle action correctly

muellerm added a comment.Nov 13 2009, 6:37 PM

[SVN revision 20148]
FIX (#2655): Implemented Rectangle (still some coordinate misalignment). Added correct display of Feature quantities. Some minor bug fixes changes in PlanarFigure and PlanarAngle

muellerm added a comment.Nov 13 2009, 6:39 PM

[SVN revision 20149]
FIX (#2655): Implemented Rectangle (still some coordinate misalignment). Added correct display of Feature quantities. Some minor bug fixes changes in PlanarFigure and PlanarAngle

muellerm added a comment.Nov 14 2009, 12:36 AM

[SVN revision 20161]
FIX (#2655): Fixed formatting of feature strings, added feature display in render window

muellerm added a comment.Nov 16 2009, 11:09 AM

[SVN revision 20173]
FIX (#2655): Fixed presentation of unit signs (correct ASCII codes for "^2" and degrees). Fixed some warnings of unused variables

muellerm added a comment.Nov 16 2009, 1:40 PM

[SVN revision 20179]
FIX (#2655): Some changes on FourPointAngle for presenting the angle in degrees

muellerm added a comment.Nov 16 2009, 1:46 PM

[SVN revision 20181]
FIX (#2655): Rearranged measurement GUI. Removed Table, added TextBrowser insted. Selections are made through the DataManager.

seitelm added a comment.Nov 16 2009, 6:35 PM

[SVN revision 20200]
ENH (#2655): Issuing itk::InitializeEvent when PlanarFigure object placement is completed

muellerm added a comment.Nov 18 2009, 1:35 PM

[SVN revision 20277]
FIX (#2655): Erased "unselected" bug. Added Initialized listener to get informed when planarfigures are properly initialized

seitelm added a comment.Nov 18 2009, 7:21 PM

[SVN revision 20325]
FIX (#2655): For drawing circles: changed tooltip from "Ellipse" to "Circle"

seitelm added a comment.Nov 18 2009, 8:40 PM

[SVN revision 20332]
ENH (#2655): Included ImageStatistics in Measurement perspective; moved everything a bit around so that all have their share of GUI space

seitelm added a comment.Nov 18 2009, 8:42 PM

[SVN revision 20333]
ENH (#2655): Shortened text message for image selection to make GUI more compact

muellerm added a comment.Nov 19 2009, 4:07 PM

[SVN revision 20365]
FIX (#2655): In mitkPlanarFigureInteractor: When throwing an itk::EndEvent, an itk::ModifiedEvent is also thrown on the node
In mitkPlanarCircle: When moving the center point the boundary point is moved as well
In mitkDataStorageSelection: Added AutoAddNodes flag. If set to false new Nodes in the DS will not be saved in the selection. New nodes can only manually be added
Measurement:

  • Added new Icons and fixed use of PlanarPath icon (a property called "ClosedPlanarFigure" is set to false in order to distinguish it from a normal polygon)
  • Updating text view should work
  • Removing nodes und erasing RenderWindow text should work
muellerm added a comment.Nov 19 2009, 4:18 PM

[SVN revision 20366]
COMP (#2655): Assigment operator now returns a value (gcc does not seem to be interested in returning values, VC really demands it)

muellerm added a comment.Nov 19 2009, 4:46 PM

[SVN revision 20372]
FIX (#2655): Using new Icon for measurement perspective

muellerm added a comment.Nov 19 2009, 6:42 PM

[SVN revision 20382]
FIX (#2655): Fixed updating problems

muellerm added a comment.Nov 19 2009, 9:28 PM

[SVN revision 20389]
FIX (#2655): Added Measurement icon for documentation, fixed updating of textbrowser, reactivated splash (was accidentally removed, how could this happen...?)

muellerm added a comment.Nov 20 2009, 10:31 AM

[SVN revision 20398]
FIX (#2655): Before drawing figures it is assured that the planes are hidden

seitelm added a comment.Nov 20 2009, 11:33 AM

[SVN revision 20406]
FIX (#2655): For drawing circles: changed tooltip from "Ellipse" to "Circle"

muellerm added a comment.Nov 20 2009, 1:20 PM

[SVN revision 20417]
FIX (#2655): Fixed Measurement Icon for perspective

muellerm added a comment.Nov 20 2009, 1:31 PM

[SVN revision 20420]
FIX (#2655): Info text field gets not populated until figure is initialized

muellerm added a comment.Nov 25 2009, 9:41 AM

[SVN revision 20510]
FIX (#2655): Using activated/deactivated in view, added documentation, added absolute calculation of area in rectanvgle

muellerm added a comment.Nov 25 2009, 3:34 PM

[SVN revision 20537]
FIX (#2655): Diameter has right unit now

muellerm added a comment.Nov 25 2009, 8:12 PM

[SVN revision 20570]
FIX (#2655): Removed reinit of image in Measurement View

muellerm added a comment.Nov 27 2009, 2:47 PM

Removing 3M3 keyword. all relevant bugs closed.

neuhaus added a comment.Nov 27 2009, 3:15 PM

[SVN revision 20632]
FIX (#2655): fix view layout

neuhaus added a comment.Nov 27 2009, 6:22 PM

[SVN revision 20639]
FIX (#2655): Fixed wrong image statistics calculation due to wrong pixel center.

seitelm added a comment.Dec 10 2009, 11:02 AM

[SVN revision 20802]
FIX (#2655): Re-integrate pixel-center fix in image statistics calculation from branch to trunk

seitelm added a comment.Dec 10 2009, 11:06 AM

(In reply to comment #53)

[SVN revision 20802]
FIX (#2655): Re-integrate pixel-center fix in image statistics calculation from
branch to trunk

With the fixes applied in r20639 and r20802 the statistics seems to be calculated correctly now. Tested on non-isotropic images in axial and sagittal planes.

The question when a pixel will be regarded as "inside" of a planar figure for statistics ROI calculation is probably a matter of definition. With the above fixes, the VTK algorithm currently used seems to handle this in a reasonable way. When the planar figure ROI includes a large enough portion (50%?) of a pixel, it is included, otherwise not. Of course this also means that if the ROI is too small, no pixel will be included at all.

muellerm added a comment.Jan 13 2010, 3:59 PM

meta bug -> no relevance for 1.0 (maybe its dependencies)

zelzer added a subscriber: zelzer.Mar 1 2010, 11:06 PM

[SVN revision 21528]
FIX (#2655): properly unregistering AddNodeEvent delegate in view destructor

seitelm added a comment.Mar 13 2010, 11:27 AM

[SVN revision 21739]
FIX (#2655): Latin1-encoded versions of degree and squared symbols are not compatible with VTK rendering; reverting to "^2" and "deg"

muellerm added a comment.Dec 8 2010, 2:14 PM

closing meta bug for measurement tools

nolden added a subscriber: nolden.Jul 27 2011, 11:41 AM

Merging "applicazion modules" component with "ExtApp plugins"

seitelm mentioned this in T2916: Enable dragging of control points.Nov 11 2009, 5:18 PM
seitelm mentioned this in T3034: Path Measurement.Nov 25 2009, 10:56 AM
kislinsk closed subtask T2792: Extend PlanarFigure interactor to allow point adding/removal as Wontfix.Jun 20 2018, 6:28 AM
kislinsk changed the status of subtask T3085: VTK warning issued when calculating statistics for zero-size PlanarFigure from Invalid to Spite.Jun 27 2018, 1:33 PM
kislinsk changed the status of subtask T3085: VTK warning issued when calculating statistics for zero-size PlanarFigure from Spite to Invalid.Jun 27 2018, 1:37 PM
kislinsk reopened subtask Restricted Maniphest Task as Open.Jun 27 2018, 3:03 PM
kislinsk reopened subtask Restricted Maniphest Task as Open.Jun 27 2018, 3:07 PM
kislinsk closed subtask Restricted Maniphest Task as Resolved.Jun 27 2018, 3:29 PM
kislinsk closed subtask Restricted Maniphest Task as Resolved.Jun 27 2018, 3:32 PM
MITK · MIC · IMSY · DKFZ