Page MenuHomePhabricator

[Segmentation] Multilabel label name dialog on label creation is a UX problem
Closed, ResolvedPublic

Description

Discussion point: I think the prompting of the label name dialog when creating a label is in most cases annoying. May be it is better to start with a default name (may be even allow to set it in the preferences) instead of always prompting a dialog.
As one can change the name of labels in the label manager nothing is lost and if the use doesn't like the default name change it willingly.

Event Timeline

floca triaged this task as Normal priority.Jul 31 2020, 1:10 PM
floca created this task.

+1 and I'm also not sure why a Layer needs to have a name. I can't see it anywhere and if the name is used somewhere, the same discussion as for the labels might be needed for layers.

Layers don't have names. The plugin is only asking for label names which are important of course. For a new segmentation there are two dialogs: for the segmentation name, and for the fist label name + color. I think it evolved from the UI pattern of the old segmentation plugin and I agree that the label dialog should be omitted. A "New label <i>" could be added to the label widget instead and we should probably improve this widget so a double click on the name opens an in-place editor for the name string instead of requiring the user to right click -> Rename... -> Dialog. Color editor already works this way.

You're right, I was mistakenly reading the dialog that shows up when you create a new layer for a layer name dialog.

kalali renamed this task from [Segmentation] Multilable label name dialoge on label creation is a UX problem to [Segmentation] Multilabel label name dialoge on label creation is a UX problem.Jan 4 2021, 12:21 PM
floca moved this task from Backlog to Segmentation on the MITK (v2021.10) board.
floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.

In the same line of reasoning (see discussion above). We could also remove the label name dialoge, when you add a new layer, couldn't we. In the current tests there was a remark, that when adding a new layer, you first are queried if you realy want to make a new layer and then you are asked for the label name...

kalali renamed this task from [Segmentation] Multilabel label name dialoge on label creation is a UX problem to [Segmentation] Multilabel label name dialog on label creation is a UX problem.Jan 26 2022, 12:29 PM
kalali removed a project: Request for Discussion.

I worked on this while working on T28142:

  1. I removed the dialog, which asks for a segmentation name when creating a new segmentation
    1. uses default segmentation node name: "<reference-node-name>-labels"
    2. when creating a new segmentation node, NO initial label is created, only an initial layer
  2. I removed the dialog, which asks for a label name and color when creating a new label
    1. uses default label name: "New label <i>"
    2. uses default label color: using multi label lookup table
  3. I removed the dialog, which asks for a label name and color when creating a new layer
    1. when adding a new layer, no initial label is created

You can see how it feels and looks when the differential for the mentioned task is uploaded. However, I am not sure about point 1B and if we should rather create a first initial label when creating a new segmentation (node).

You can see how it feels and looks when the differential for the mentioned task is uploaded. However, I am not sure about point 1B and if we should rather create a first initial label when creating a new segmentation (node).

with this point I am also unsure. From first impulse I guess I would find it annoying, if I always have to explicitly generate the first label. So I would always add at least one new label.

In the future, I think, it makes more sense to add a preference where people can specify a custom lpset file that is always used on new segmentation creation. Then they can decide if the want labels and which one.

The test of the decisions is fine from my POV.

You can see how it feels and looks when the differential for the mentioned task is uploaded. However, I am not sure about point 1B and if we should rather create a first initial label when creating a new segmentation (node).

with this point I am also unsure. From first impulse I guess I would find it annoying, if I always have to explicitly generate the first label. So I would always add at least one new label.

In the future, I think, it makes more sense to add a preference where people can specify a custom lpset file that is always used on new segmentation creation. Then they can decide if the want labels and which one.

The test of the decisions is fine from my POV.

I already changed this to your suggestion. I also realized (while working on other tasks and having to create a first label all the time) that this is annoying :D
Additionally I refactored the relevant code, which is related to T26396: [Segmentation] Refactor functions to create new (empty) segmentations.

Has been solved with b2f602ab37d5 by merging / landing D601.