@kalali Aren't you already working on that topic? I thought, i just reviewed something in that direction?!?

In T28142#226704, @floca wrote:

@kalali Aren't you already working on that topic? I thought, i just reviewed something in that direction?!?

Not that I'm aware of :)
However, together with @kleina, @s434n and @a178n we will now find a way to work on that issue in parallel.

oops, sorry. than I have mixed something up.

I refactored both views massively. What I did was to somehow bring both plugins in line with each other to see the differences and the similarities. This simplifies to understand how things are implemented and what needs to be done to remove redundancy. I will highlight some points that I find striking:

• the multilabel plugin view did not compare the world geometry to the selected segmentation node
  • I was able to draw a mask which was then positioned somewhere else (jumped) because of this (e.g. using brain.nrrd)
• hiding the selected segmentation node disables the tools for the segmentation plugin but not for the multilabel segmentation plugin
• the auto selection mode for showing / hiding the selected / not selected nodes in the data manager / render windows if the node selection is changed does not work anymore for the segmentation plugin (was already mentioned in T28256: [Segmentation] Auto-selection preference was hijacked for something else)
• the multilabel segmentation plugin did not listen to render window part changes (no subclass of IRenderWindowPartListener)
• the multilabel segmentation plugin lists some segmentation tools that don't even exist (FastMarching2D, Two Thresholds Auto Threshold Multiple Otsu)
• the multilabel segmentation view plugin is not able to accept binary images as a segmentation

Since we are now in the "final" release phase I suggest to use the corresponding checklists to check the new / modified behavior of D533 and simultaneously verify the checklists and test the UI behavior of both segmentation plugin views.

In T28142#228390, @kalali wrote:

Since we are now in the "final" release phase I suggest to use the corresponding checklists to check the new / modified behavior of D533 and simultaneously verify the checklists and test the UI behavior of both segmentation plugin views.

+1

The changes have already been merged. If there are no critical bugs found since the last release (where the changes of the related D533 were already included) we can continue with this task / subtasks.
I'd like to discuss our goals concerning this task for MITK v2022.04.

Continued working on this and added fixes for:

• T26396: [Segmentation] Refactor functions to create new (empty) segmentations
• T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem
• T28256: [Segmentation] Auto-selection preference was hijacked for something else
• T28640: [Segmentation] Add tool checks for dynamic plugin view

Not all tasks are done, some discussion is still required.

Because of T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View I disabled the interpolation if a labelsetimage is selected as the working node with more than 1 label (actually more than 2 labels: exterior + first label).

Other than that everything else seems to work as expected. I removed all of the duplicate MultiLabel segmentation stuff and merged the relevant things with the classic segmentation plugin view.
The differential is now online and we can use the upcoming release test phase to check the functionality of the now merged segmentation plugin view.

Segmentation utilities still exists in two forms, in the classic segmentation plugin and in the multilabel segmentation plugin.